Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 11:02:39 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     <ye.xingchen@zte.com.cn>
Cc:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <chi.minghao@zte.com.cn>
Subject: Re: [PATCH] mtd: rawnand: orion: use  
 devm_platform_get_and_ioremap_resource()
Message-ID: <20221122110226.3cdac73a@xps-13>
In-Reply-To: <202211220933274886024@zte.com.cn>
References: <202211220933274886024@zte.com.cn>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

ye.xingchen@zte.com.cn wrote on Tue, 22 Nov 2022 09:33:27 +0800 (CST):

> From: Minghao Chi <chi.minghao@zte.com.cn>
>=20

Double space in the subject

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>=20
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/mtd/nand/raw/orion_nand.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/ori=
on_nand.c
> index 1bfecf502216..00bd7be76e07 100644
> --- a/drivers/mtd/nand/raw/orion_nand.c
> +++ b/drivers/mtd/nand/raw/orion_nand.c
> @@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_de=
vice *pdev)
>  	struct mtd_info *mtd;
>  	struct nand_chip *nc;
>  	struct orion_nand_data *board;
> -	struct resource *res;
>  	void __iomem *io_base;
>  	int ret =3D 0;
>  	u32 val =3D 0;
> @@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_de=
vice *pdev)
>  	info->controller.ops =3D &orion_nand_ops;
>  	nc->controller =3D &info->controller;
>=20
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	io_base =3D devm_ioremap_resource(&pdev->dev, res);
> +	io_base =3D devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

If we no longer use res, why not just devm_platform_ioremap_resource() ?

>=20
>  	if (IS_ERR(io_base))
>  		return PTR_ERR(io_base);


Thanks,
Miqu=C3=A8l