Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 19:09:11 +0900
From:   Max Staudt <max@enpas.org>
To:     <wg@grandegger.com>, <mkl@pengutronix.de>
Cc:     "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <linux-can@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down
Message-ID: <20221122190911.4a272f5a.max@enpas.org>
In-Reply-To: <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
References: <20221110061437.411525-1-william.xuanziyang@huawei.com>
        <20221111010412.6ca0ff1c.max@enpas.org>
        <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Marc, Wolfgang,

Could you please include William's patch to can327, provided that you
see no issue with it?


Thanks :)

Max


On Tue, 22 Nov 2022 10:10:50 +0800
"Ziyang Xuan (William)" <william.xuanziyang@huawei.com> wrote:

> Hello,
> 
> Gently ask.
> 
> Is there any other problem? And can it be applied?
> 
> Thanks.
> 
> > (CC Vincent, he may be interested)
> > 
> > 
> > On Thu, 10 Nov 2022 14:14:37 +0800
> > Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> >   
> >> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
> >> is down. Not tested, just compiled.  
> > 
> > Looks correct to me, so:
> > 
> > Reviewed-by: Max Staudt <max@enpas.org>
> > 
> > 
> > Thank you very much for finding and fixing this!
> > 
> > Max
> > 
> > .
> >