Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71d10db8151c3b78d84a252a688e2892448eaa95.camel@linux.ibm.com>
Subject: Re: [PATCH v3 5/9] KVM: s390: selftest: memop: Move testlist into
 main
From:   Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To:     Thomas Huth <thuth@redhat.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>
Cc:     David Hildenbrand <david@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>, kvm@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Shuah Khan <shuah@kernel.org>,
        Sven Schnelle <svens@linux.ibm.com>
Date:   Tue, 22 Nov 2022 10:34:02 +0100
In-Reply-To: <c801611e-61db-73d2-2ff1-cd06350215b2@redhat.com>
References: <20221117221758.66326-1-scgl@linux.ibm.com>
         <20221117221758.66326-6-scgl@linux.ibm.com>
         <c801611e-61db-73d2-2ff1-cd06350215b2@redhat.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-11-22 at 08:52 +0100, Thomas Huth wrote:
> On 17/11/2022 23.17, Janis Schoetterl-Glausch wrote:
> > This allows checking if the necessary requirements for a test case are
> > met via an arbitrary expression. In particular, it is easy to check if
> > certain bits are set in the memop extension capability.
> > 
> > Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> > ---
> >   tools/testing/selftests/kvm/s390x/memop.c | 132 +++++++++++-----------
> >   1 file changed, 66 insertions(+), 66 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
> > index 286185a59238..10f34c629cac 100644
> > --- a/tools/testing/selftests/kvm/s390x/memop.c
> > +++ b/tools/testing/selftests/kvm/s390x/memop.c
> > @@ -690,87 +690,87 @@ static void test_errors(void)
> >   	kvm_vm_free(t.kvm_vm);
> >   }
> >   
[...]
> > 
> > +	} testlist[] = {
> > +		{
> > +			.name = "simple copy",
> > +			.test = test_copy,
> > +			.requirements_met = true,
> > +		},
> > +		{
> > +			.name = "generic error checks",
> > +			.test = test_errors,
> > +			.requirements_met = true,
> > +		},
> > +		{
> > +			.name = "copy with storage keys",
> > +			.test = test_copy_key,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "copy with key storage protection override",
> > +			.test = test_copy_key_storage_prot_override,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "copy with key fetch protection",
> > +			.test = test_copy_key_fetch_prot,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "copy with key fetch protection override",
> > +			.test = test_copy_key_fetch_prot_override,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "error checks with key",
> > +			.test = test_errors_key,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "termination",
> > +			.test = test_termination,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "error checks with key storage protection override",
> > +			.test = test_errors_key_storage_prot_override,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "error checks without key fetch prot override",
> > +			.test = test_errors_key_fetch_prot_override_not_enabled,
> > +			.requirements_met = extension_cap > 0,
> > +		},
> > +		{
> > +			.name = "error checks with key fetch prot override",
> > +			.test = test_errors_key_fetch_prot_override_enabled,
> > +			.requirements_met = extension_cap > 0,
> 
> I wonder whether it would rather make sense to check for "extension_cap & 1" 
> instead of "extension_cap > 0" ?

The cap should always have been a bitmap, but unfortunately I didn't initially
define it as one, the storage key extension must be supported if the cap > 0.
So the test reflects that and may catch an error in the future.
> 
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
Thanks!