Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939410AbXHJShY (ORCPT ); Fri, 10 Aug 2007 14:37:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756553AbXHJShL (ORCPT ); Fri, 10 Aug 2007 14:37:11 -0400 Received: from smtp3.hushmail.com ([65.39.178.135]:64261 "EHLO smtp3.hushmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756531AbXHJShJ (ORCPT ); Fri, 10 Aug 2007 14:37:09 -0400 Date: Fri, 10 Aug 2007 14:37:06 -0400 To: , , Subject: [PATCH 1/4] /drivers/net ioremap balancing/returncode check (es3210.c) Reply-to: postfail@hushmail.com From: "Scott Thompson" Content-type: text/plain; charset="UTF-8" Message-Id: <20070810183707.36A1ADA81F@mailserver7.hushmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 39 patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / return check: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for iounmap this audit was only for files directly in drivers/net directory, not the full tree. I split patches up by file changed as each file had different 'owner' to ease accept/reject/revision process. Signed-off-by: Scott Thompson hushmail.com> ---------------------------------------------------------- diff --git a/drivers/net/es3210.c b/drivers/net/es3210.c index 822e5bf..d7d6b90 100644 --- a/drivers/net/es3210.c +++ b/drivers/net/es3210.c @@ -307,6 +307,10 @@ out1: free_irq(dev->irq, dev); out: release_region(ioaddr + ES_SA_PROM, ES_IO_EXTENT); + + if (ei_status.mem) + iounmap(ei_status.mem); + return retval; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/