Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca0d8320-21f1-6c54-87b9-a34d077e6473@wolfvision.net>
Date:   Tue, 22 Nov 2022 12:23:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [linux-next-v2 3/5] arm64: dts: rockchip: Add support of
 regulator for ethernet node on Rock 3A SBC
Content-Language: en-US
To:     Anand Moon <linux.amoon@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Chukun Pan <amadeus@jmu.edu.cn>, Peter Geis <pgwipeout@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221116200150.4657-1-linux.amoon@gmail.com>
 <20221116200150.4657-4-linux.amoon@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20221116200150.4657-4-linux.amoon@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkQyOEN2QnpaS0wxd2xibUMzM2lGMHg4Ym10V1Fhd2V0SVF0OFVEczRQTWFG?=
 =?utf-8?B?ejZuK0FpMDdiVk1zSGMraUlWRis1ZURIN0lRQUxVazZ1VUc1SnpTZVQ2UWUx?=
 =?utf-8?B?N0lYVTZ6bmlsYzhtc0xSMXZHekR0TkRQbDRmenduYWFPdXNUSk9Ea0tUZS94?=
 =?utf-8?B?Ti9nMlhrdkxaZnBuM2Z6VEM5Tnhqa0FqS0RnOHQ2eWhpVDg2QlB2czRPNGN1?=
 =?utf-8?B?M0NIQmZ1TW4rS0orRW4vcWVmZUxFbXo1RjBTakJaYW5MNFY5YkRUVnY3N01O?=
 =?utf-8?B?KzR2OTlibG9OZWhja3M1NVJqZDA1YkxYT2RWSi9BT1dyWmY4TXRsYjFaaW9L?=
 =?utf-8?B?ZnBZaEVOdVlQS3c0d1JkeEtDd2ZCQktGdWVpcWlGMFN2aE9jUXI2MEN1S2c1?=
 =?utf-8?B?czhNbWFWc0hUdU5UM1ZiVVJrWjhmSVE3dHJrTHptajg3Nit4MWFkN2xpdnhY?=
 =?utf-8?B?QTFuMFhOaGFWc296VDk3cXZQYUlQVmRYdEE5cmJDTHhEM1lPekpvRGRFOE1K?=
 =?utf-8?B?SHByRlpncnJkQmplL3U5MkhaNzcrbDhIVDZla3U2clYwVnZ1czdWZmFVOUky?=
 =?utf-8?B?VWFPSzk0ejVSeis5N1c0TDZiYktKRUV3b29kNG1TcGdyaHIvTWpNV0EyaSts?=
 =?utf-8?B?RVJwNW0wbWZ6UTBpWFdsZTNvZmJleEd2WVltU1dWTllMV2cvL0p4ejM5TVlZ?=
 =?utf-8?B?ekE5VnEvblFodnREaUwycElzdFZ1eUNMaWM5UVprTUd5R2szYjNZb1RRWjVR?=
 =?utf-8?B?TFBscVlzVVM5Q2VkSW1ZS2Fobk1nU3RiY2ZEVzFkRGt2NWFMdTd0WHlTKyt1?=
 =?utf-8?B?RXFWSXJqYWlMN1RVVXJsQllncXlsUFFyMjg1a2N6S05jUks1SVRyVkxMRFBv?=
 =?utf-8?B?Q1hvQmdnMEc2ZE9JakNoalgySFdDdExjdU9TckpuODQrMXk5UExtRXgrZFdO?=
 =?utf-8?B?UC9qZmdNakVaT1IwQ0I2cThTZkxONktheDRSR21jb1NkRENNZ0hZSncwWi91?=
 =?utf-8?B?QlJQait5NWFTVU5DcE1tUVZ4dzRiem54d3FwQzFyTGdISEVicnc3b0xJQXho?=
 =?utf-8?B?Q0h5alkrdXYyM1BycVFIZlU3UkFWWWRsVzJBbkJ2VXBWaXZaelZ2QVJjK2k0?=
 =?utf-8?B?OVJMS2VSK1M3SjgzM2M0OUZJdnNlb2Q5VWk2RDVUS1FjaXJqaHlnVXJoc0ll?=
 =?utf-8?B?SnpNRU5hUHFpTVVvdXNCdUJSSmZhZzBncDMwSXNXeTY5MTZNRTN2SG1wWVVk?=
 =?utf-8?B?WlUrVW9DZmhEZVFEYmUvVWgzVlNrU3RhVVVJR0xXZWZwc2VzK1lraGlCdGto?=
 =?utf-8?B?TGJDelJ5RGwraGcySUxKaGJFOEx6OHlOeXM4Zm5UWjMwWG9rTHBiVEQrZzdC?=
 =?utf-8?B?U1pXMCs2UUQ2SFdjbUZxNk4yVVlHVzhjQVMwZnM2dk9YYkN0dys2NEIyY1dJ?=
 =?utf-8?B?SFVXeG0rR0JzTHB3TDhQYno0NmM0TTZ5TkJ5ODVaRGpHRTFZVTZiNTh4SGVo?=
 =?utf-8?B?MFVTczQxOVF1QklUOTd1bU9Kb0VBV0xieWlTS1p0V2tlZDNrOGxwQWhGQks5?=
 =?utf-8?B?U2pxRmwyRkNDdXM0bVhJaitiZkw1TEcwT1Nza0JjRzVFM1NNbjlVU2VDY1Ri?=
 =?utf-8?B?K2U3T1ZuQlhPcjRjZmJieEF3Wk9CLzl4Ti8wbmxwV2FFcEsyN3RzSXlvRURF?=
 =?utf-8?B?UmhUS1NiRWNXeTJWTi9RbzllZ3JtS0hhQVFzU040Q3lmTGJvWHVoTU1MQ2Fu?=
 =?utf-8?B?ZW9mMWFvQTNXVTZVYWRaQVF4RGZzRmN2UXZNa25ua3FFeFlDdEE4SC9sTWla?=
 =?utf-8?B?UGp4T2Y4SjJzeFZnaWp3U1UrWk51UWhNU3JMaS8zUE5nUlMrTUlENWlQdTZ2?=
 =?utf-8?B?RU14ZFRYNW14UEhzZEV2Wm50Ry9JQWJTZDREclpadVYrNmtNaUJHUFZGRzAz?=
 =?utf-8?B?cHkxd0dvalAzQStnVnQ5dU03bm9UMVBDb1NSeS9XU3NnRDN0SlN5OEx4Q21M?=
 =?utf-8?B?dVpHRG5IWC9BVFVmSE5aUSt0VjNldWcwUUwreGlLS2g1SFdTTnFlU0NBcUk4?=
 =?utf-8?B?YkpFVEQrYVpYNmFPUExVUSszditzRlhqZ2FtN1MwNlMrUS9sRW1zV3ZJV0g4?=
 =?utf-8?B?V0ZuTDAwaHhreGxDV1lGeThvZjR4T01JVjVWVGJyTDl3UnJQMUtuV0phbUdl?=
 =?utf-8?B?ZEV1ZncvUjZIMXJoZnU3ckdmaWNIa2xCblk0Y3Nxd2RWdVNGV0xMenNvNXox?=
 =?utf-8?B?VUJrT0E5L0thajVEYnJ6ZVFtckhBPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 05e492b7-2bb4-4688-b279-08dacc7c0070
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 11:23:38.2836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iEIc0zjMtysOb2ke72aWUuxMyabkb8dsETI8lp+a1n3tLJMq4zeawfRaf0UbQwALB8qcvj1E0GXH0VhtcR2rIJNazwHlpWwSveX+zFjyERc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5888
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Anand,

On 11/16/22 21:01, Anand Moon wrote:
> Add regulator support for ethernet node
> 
> Fix following warning.
> [    7.365199] rk_gmac-dwmac fe010000.ethernet: no regulator found
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Acked-by: Michael Riesch <michael.riesch@wolfvision.net>
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

Best regards,
Michael

> ---
> v2: new patch added
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index b848282ea005..5378254c57ca 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -260,6 +260,7 @@ &gmac1 {
>  	clock_in_out = "input";
>  	phy-handle = <&rgmii_phy1>;
>  	phy-mode = "rgmii";
> +	phy-supply = <&vcc_3v3>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gmac1m1_miim
>  		     &gmac1m1_tx_bus2