Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 6/6] ufs: core: Add advanced RPMB support in ufs_bsg
Thread-Topic: [PATCH v2 6/6] ufs: core: Add advanced RPMB support in ufs_bsg
Thread-Index: AQHY/S6fGNUnGplQxEOfi3uFlr5Rnq5K1fvQ
Date:   Tue, 22 Nov 2022 11:55:27 +0000
Message-ID: <DM6PR04MB6575750D9C6F84FC3BE06AFBFC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221120222217.108492-1-beanhuo@iokpp.de>
 <20221120222217.108492-7-beanhuo@iokpp.de>
In-Reply-To: <20221120222217.108492-7-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2CXhvY2hg3RMTKJezz72taenSs+WAZM19r05t1lDRcjAgizBrwGV6REy2Z?=
 =?iso-8859-1?Q?rUpRRf8hYcWBc4bkhzdcbaVuL+oHE2wROmZm12FZv6t3t97pjvOqSF412W?=
 =?iso-8859-1?Q?9vSiLRasWgZtKMdXEkQ+ifiJDYBL/C7aU2k1zTTGaOFcy2ClwhmBW9IQU3?=
 =?iso-8859-1?Q?a6a2dzhQpgO4nKDLw+uL9oBNHKYjxnDu/lUQg2m9Pn6a5TRBlzaCRSjiFw?=
 =?iso-8859-1?Q?Q1xQdQEJXG3tSsnRH8WQxUdh+KQfPd9ZGigdxBpjkkY9yikWQqNnYathAv?=
 =?iso-8859-1?Q?8RNqdLQNfo36K+s1xCCfG6gSK5CqGiW/2UYYGdGXdlx21YX3rwtOfSaAZn?=
 =?iso-8859-1?Q?tIDVNpplaUzdumWDaJjER3qQWYIuGdO1QL/C0jJ4EYDXd0cjFON0C9mrcO?=
 =?iso-8859-1?Q?uhXV7PJo9+TpoGD7HFuAfRU/ruzBw6uhV64IygqR/1pSJJ6gc7uu0Hpj3J?=
 =?iso-8859-1?Q?J4rjifGnShqZjznkPGj/kDAH+Kd3a5dgFccBp0D6Z+Vqh1vngME0RvXDq+?=
 =?iso-8859-1?Q?39YMrw57R3DAb+iM8S/NOFk9FROT2nufu3+K7T/dF5af0/4Zpz+gHJwPTy?=
 =?iso-8859-1?Q?4OZSi1LXXKnhe57Brzhfw154dN5l8XEx1bQWhai5DtFGxA9uVIf6j5j3tI?=
 =?iso-8859-1?Q?ArY9KJkDxlI2LndByJXjc/eBSMJM3YnqacPgCWQq0NHywa9WFR7fqjcgRi?=
 =?iso-8859-1?Q?3g2AYimMNkQmanNAQCcKQ+Q9rn2tq/Op7hc9KxbHqMXggyeIp6Gtpn4cRv?=
 =?iso-8859-1?Q?CdxAShoFpWJQ4VSaD3yrOZgkvzDNLtJp3/khDo0/q8wdiz64fklKSVQv9Y?=
 =?iso-8859-1?Q?La8I7OW9rhjvZnzSPw43kK1nv/ZsZrpXdYNSudmOlts9WJcPTqqq0+LmA1?=
 =?iso-8859-1?Q?CviKXZ0stmfvM8Lz51ZX2DGD/8CtRNg0OkgvosQK9G6cQGHoJ3hkeATPL2?=
 =?iso-8859-1?Q?K6aDH6DC8JJ4hU2WO47Gb4cycQggcpgqSyxSLnF6MWCR+jYhOZRLF20llp?=
 =?iso-8859-1?Q?QZ8D85Nbv6PGm6jO4Gp1HNLzagYimPFgxFOhAHCyG9WVHFESP098KG9W7r?=
 =?iso-8859-1?Q?hKidC+CLP0ccwlRiG2vCFO7mmtQ7yfGAWb/PALCOj0uFtJpTBpd0cqZx/i?=
 =?iso-8859-1?Q?+2cV9fhjMCjZ1dQ/IapH/R4CEjOw+/bWa5i2lXd/M/uD6n/X1EKcHYhvcZ?=
 =?iso-8859-1?Q?tsBGwj+5OIKeg2BH+qmo0K7dXljjoAhyMy4HIK52I1xvAR5qgR9lWDglMZ?=
 =?iso-8859-1?Q?eSo9kZST7+LY65nx6pRrOcpZaRRNUg/TuVME9OKjX8RfnnKNMQtsV8LQC5?=
 =?iso-8859-1?Q?auOcd7SLXcqg/K8A3xJLbjmZmM8uwihtMcaIEe7bmqtaf6TNxqqwbdMLwU?=
 =?iso-8859-1?Q?iW15kQGAm3tK6TEW7snveuvhZGAKtol85eUln3/otiT0zJBLHfi7zjPy0D?=
 =?iso-8859-1?Q?dDbqUZea2cERxcH3LG9t71N36lwOLvGJ/ydkYO+xEj8VqDXCKim7nFJGsM?=
 =?iso-8859-1?Q?Pw3bhXPuB9Qc6n80t7IDX+cYirTVHXSnoj9cA7Pjkogl+DzwC0Trsky4c9?=
 =?iso-8859-1?Q?/hd8bmTN4LoOjGTLJsNHKxe2peXIippK9SvHqYr5NHV42cSYsOi3pvJ7/b?=
 =?iso-8859-1?Q?6+DC0PVli5AW3ZgKLSRoWT42av8AdxkHJx?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?Q?1Mt3tWOlrsrdRCwsPVQ24Ll8kPcufo+BW/0z3fcNAK//lYo8/LFMoihmPL?=
 =?iso-8859-1?Q?J9o3l8n4LVGQ70fXotG9MVeAAGycfxTNIj6vWNzmvhki6LWnioCnSJ1p+X?=
 =?iso-8859-1?Q?uXbUFp5zCaSupp8YqtsYUFZwJPE6s4UZadRQsmEULBpqsuWsp4aTin7/cA?=
 =?iso-8859-1?Q?vcVbxVkfyHZ0gMiIIvCDDJ+6EScBxjx6OOiLTEs3ixvoa7iVsqmn+JdCY5?=
 =?iso-8859-1?Q?Q1p643Z7mxHQqfs6vb+jv3kUuigXOjhx1Z4YatFN3RYwOnk/bLtrNE7TdG?=
 =?iso-8859-1?Q?px64p3uovLWjSDo6BMLJPgZHTXOkbNNVcP+xHNjvYqsvO+dP379B4l0VZV?=
 =?iso-8859-1?Q?/yS6u0schEap7pzQuFfiQDDnBTUPhvE8IR8YnOkyjeybuOBY0+jy1NEBFE?=
 =?iso-8859-1?Q?qOHSMxVkR2Zs+SQyERUwxKFGiKIS7ACIzLslW3cWPiD/qCGWmY95/BUeE7?=
 =?iso-8859-1?Q?ynO2TjBUEJ8qxjbMZYz3bTPVfmbRWRJ7fwiF84UGOIdC6cto1LLEFKWDJn?=
 =?iso-8859-1?Q?tvRQuulHwiFOD5cEJMXVuxM0Miv45Qa87EI067bVagHPGmcm5zOKHF7BKi?=
 =?iso-8859-1?Q?L7bolHW8g9WXCOzmydg3DAE0wrbi93w2ohU9rWhQ/LAdiB+Zz55B+Ic5G1?=
 =?iso-8859-1?Q?aiEZ7NB0JN/vvZ/Wpi1Dk6NzOP2tuSTwLwOqYPrudS5VHM59RrnN2UjQuz?=
 =?iso-8859-1?Q?govUkLBB/Z5VV5hmucJkoAQHC57klTicnozXXFnpLIbn1A0/JBVOMMrVz9?=
 =?iso-8859-1?Q?tunSRXcwrbs8RxR48Gyia3SWs9KH0YLSWnBmORLGXmJtX8dy2v3reghsiy?=
 =?iso-8859-1?Q?mkeQySawGiBmSDK6T0Xb3V1nKT5Ew3kC0zxf4s/zA/Lv6dTHSvcsgGBj9i?=
 =?iso-8859-1?Q?1FRMra9X6nPkc09GjnJB0lzF2eC/vG4IHLkd72kU2w09hjSDCgwI1cX2UH?=
 =?iso-8859-1?Q?mlZzdhFfikXsCqtQ4fxvM6f74to2tF/dsGz9qEqINWDfWOIKfWpiINI6Vk?=
 =?iso-8859-1?Q?RLLSoTJGBHcIVzssk14wiyYqg0bQTO93ZyzV82/EdSwi8HuWGbPbFndzza?=
 =?iso-8859-1?Q?nB87cdokf37x7iR0XsXsyJOUjPv3loOFNdW1kybycGiGRdhrP8ugrAPT50?=
 =?iso-8859-1?Q?WaFwrN6epkaPT/+PXU2mX0QKc4u5R/AKlKsegTcVnpXLTWFxDdcChwDPlv?=
 =?iso-8859-1?Q?PHZudG2dpkO1V/b8SaYa2OFTWOLNhWBDhaazP0puuoMsg/wHnE/5yPZ7GE?=
 =?iso-8859-1?Q?FJCi6Azo4o3QTDZqkAQtrwwaib3DCJ2zKM9247kQUt446bga0QRnhlYdqu?=
 =?iso-8859-1?Q?EASWuhHfQqnPKOzvgu3c6GfjKQ=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 298d6502-3c4c-4831-a94a-08dacc807286
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 11:55:27.5498
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f4TdI4VgmCU8mKg8OgWUxXmpibD4qx9VvXwuellgTs77AnSyHA4XZ+vC7vUp8KgvY0WTrubIZkooKhU0PbLJsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR04MB4611
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static int ufs_bsg_exec_advanced_rpmb_req(struct ufs_hba *hba, struct
> +bsg_job *job) {
> +       struct ufs_rpmb_request *rpmb_request =3D job->request;
> +       struct ufs_rpmb_reply *rpmb_reply =3D job->reply;
> +       struct bsg_buffer *payload =3D NULL;
> +       enum dma_data_direction dir;
> +       struct scatterlist *sg_list;
> +       int rpmb_req_type;
> +       int sg_cnt;
> +       int ret;
> +       int data_len;
> +
> +       if (hba->ufs_version < ufshci_version(4, 0) || !hba-
> >dev_info.b_advanced_rpmb_en ||
> +           !(hba->capabilities & MASK_EHSLUTRD_SUPPORTED))
> +               return -EINVAL;
> +
> +       if (rpmb_request->ehs_req.length !=3D 2 || rpmb_request-
> >ehs_req.ehs_type !=3D 1)
> +               return -EINVAL;
Maybe you could also check:
In case of rpmb write, the request payload 4096 =D7 Advanced RPMB Block Cou=
nt,
And same goes for response payload for rpmb read.

Thanks,
Avri