Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 12:46:40 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Roger Quadros <rogerq@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove
 redundant ALE_CLEAR
Message-ID: <Y3y2oLutlESoqS6r@boxer>
References: <20221121142300.9320-1-rogerq@kernel.org>
 <20221121142300.9320-3-rogerq@kernel.org>
 <Y3u6iSiJOgcy38cL@boxer>
 <Y3wfpd1p8zbyYByy@lunn.ch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y3wfpd1p8zbyYByy@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iAz86iet7+uP09WWdcHYBCQHRLjj4pOvdJFtXlx6BWG/q6NLNUTe1nIVfiWE?=
 =?us-ascii?Q?xDTxX8303bLOUzRQxgnL5elOLlgnNZKovtTwRAOkNUkM9Prlqktsisxdb2aV?=
 =?us-ascii?Q?dxXjE/t9gmvs0fZM/dMg8jSLtVF2g+h2TJjIkaxvwJxmtoDFXx5Uv1FrfYLw?=
 =?us-ascii?Q?M1EspifNmeaAdjIKmR409PM1se+plLtdNy8c29iUn2GB96sN1uHzYhc8apKR?=
 =?us-ascii?Q?FQDeGUgf01giyK5qi6o84L18YlPowvbKAukz2c6c+Zqwqn/kSaXM7ik2+IHW?=
 =?us-ascii?Q?GARcAKgM86JJ6QyX0mIVAoWBA50qgFAfReRUFZUDjBOSMTAPVqCCbfT1gSVt?=
 =?us-ascii?Q?vtXhDAtY81vr/5FMRVeYWhv6p6kTGHObvfU1mUfw2D1TJ7WU89ffu34cKPs1?=
 =?us-ascii?Q?r0wgFd7vtF27LQ6TTYoxAHhxC0csX8axUWSsWgGRZYs7RVjTcGQ3dV4nj6Xv?=
 =?us-ascii?Q?H4t36DPAR5rQa1S2umJVHCVeCQKeaT7Ghv7Loqw92iZZTVByQNmbkc3Xg+5a?=
 =?us-ascii?Q?jRktU7FEh9+YZxXjPciv1qanZenMccpafgf/ZJLp7UR4PP2S2E77M6Df4im7?=
 =?us-ascii?Q?Mej/bJTNPxzp4nwCaKocIO3c3o7l8kZNDmh4bTbet+p4FVVtV4W3GARRBqn8?=
 =?us-ascii?Q?b7CKxMe+UJSJ75JJTluSuDYHcq2NKe2zw7O3ss4f1nYKP01wgX4AWZH5SdCl?=
 =?us-ascii?Q?vQceFE0x2wMxWAByYE0chZsk7VmEfxFepHn8fZAJwadcJVCnOVUfG7J5qCc6?=
 =?us-ascii?Q?/Y195W/VbEjbo/hEO6PoQJdmKCcW/+cQO5Xy4ZptIoOie9bFFQE4lo2MBuYJ?=
 =?us-ascii?Q?B9b11v0g3OrGA2UjrVdZ8m+9PbJ+CD1JpR0C+N5y7A5wJUsoe36rjcoKO7ZM?=
 =?us-ascii?Q?nA3dpwL4TCukpUvEAP7L8KvCKClN0Vc7NpgLt4qE+8uYOt7mvLio8WAZB+4O?=
 =?us-ascii?Q?W13fT13MLqnI+Smpx1ZIsmbYJ4LJbyAhl4w+9NcpcaoF7XL2HmRxSNUufp5Z?=
 =?us-ascii?Q?eEs7dEa+cGMTVEoqx2QSo0BBk9NjZZs9EB7JiJ94VJ8TZ6EKe3GYsnNvV2Ju?=
 =?us-ascii?Q?9vA9eqiIhppHdicwwtQ5WrUJx+mZO19EuuyGA5wQdqA5Xyq5ku4FooAIl7t1?=
 =?us-ascii?Q?kTfErN8j/Wvxl+j7VwjJQhlpciEK5QyNOGaLXtCnkRTMw+GfJTvyjkT5YACs?=
 =?us-ascii?Q?cNhpVGOal1zpUY+ZhamJ8NZ9KCK4BJrMc8GWFaDrB5pSUFHk5jfJj7oA1QyA?=
 =?us-ascii?Q?PLnAtdFTHVIAX0xieT7OZK64R+mpOs3VucS4WiPsWsiO8jOs/zZDPZqgf94Z?=
 =?us-ascii?Q?F8znEX7wK8x/FBMxFSHFB7yJlhNDdFIlWDa3sd9j3jHtO+qMsPH7IU75vEpV?=
 =?us-ascii?Q?Na6/DNjTj0Iq23Uxl9OLpnd+xNHebQXnv3ErJpXl5HCzjFbTt+2H4QqWIMtj?=
 =?us-ascii?Q?m+x8TX8yEsase0/ykd02t5zZOUJ97dA75+kEdwTFtUdBBUTnIEv3q9u7r1FB?=
 =?us-ascii?Q?LGpDxx1sDbJvTQOA3r0JsCXNFIsj/Nnq18XnQ7JiaIFbS6OEPHIbZ6JDCgN0?=
 =?us-ascii?Q?UQHTryEhP83YulhvOTHaCYnlxIwQItfMmOKxNVgD+lcakaHjXkUL+phprElm?=
 =?us-ascii?Q?Jg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f49c19f-b418-4fef-ffef-08dacc7f3c3c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 11:46:47.0983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 08dpVJhwDuh+QmioLuVUcKAdZPG6YvG1F3Fs/JhQWKXjzoLzSYo0IIZ1/CxqQdlIPqETaBrM4KaMD3NwlKIsRmOIklWrcHrfRqXEPc7jXoA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5964
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 22, 2022 at 02:02:29AM +0100, Andrew Lunn wrote:
> On Mon, Nov 21, 2022 at 06:51:05PM +0100, Maciej Fijalkowski wrote:
> > On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote:
> > > ALE_CLEAR command is issued in cpsw_ale_start() so no need
> > > to issue it before the call to cpsw_ale_start().
> > > 
> > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support")
> > 
> > Not a fix to me, can you send it to -next tree? As you said, it's an
> > optimization.
> 
> commit fd23df72f2be317d38d9fde0a8996b8e7454fd2a
> Author: Roger Quadros <rogerq@kernel.org>
> Date:   Fri Nov 4 15:23:07 2022 +0200
> 
> The change being fixed is in net-next.

Ah right, nevertheless I had some comments there.

> 
> Roger, please take a look at the netdev FAQ and fix your Subject line.
> 
>        Andrew