Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5752689rwb; Tue, 22 Nov 2022 04:36:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf7N5uKWsD4wa4zmHmWZHV2BMVrHkGj8AaCz8XHso88g8Z8bmdXezOzo2KISJG0gnUPRBLiW X-Received: by 2002:a63:584b:0:b0:477:589f:d26f with SMTP id i11-20020a63584b000000b00477589fd26fmr7851858pgm.468.1669120602857; Tue, 22 Nov 2022 04:36:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669120602; cv=none; d=google.com; s=arc-20160816; b=qIxUl8XACmGwwZxQKNNqqWw2jFiPY7fVD9ysT0eLFN1r3REm0H/5TY9I2pTcdnfGP3 hp6SFgd1fjIpmrKrV82oiy0BbFHngBNBK1uiPKq4KtKK27wMZdH44pvEjNbmwnMlXAtx Ts8/2lNXDH/6eJaysuGuznqUkHe2ijnkNzrTZLBIAKLSyZ9dX4xoE5sYHTEWwzoCHVZ/ yxotqbXKlTs6bol0NHJpSgRQ2MV5JsE8b9zNX1lNk/O3LkbAQpOid7803i0qcVDosqLn j1VTdVAQHlSQJu5GgUPjjwWCegsVApy2yNHJjKzEe48f7kQUHKEkTI1esjQ9k+QD1Tr6 I1zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6qJMO7sVm5yqyZblKEbfoaWLTsZ3QVBtE+vxsCzLPgs=; b=RfbZwaN7+pQwjPaWVwFozTdyIcu1+tYlyuvbQnmI/20Jpyrj21OeTUkeLkeQqioNG6 O1SS0xC6LRLl6Nwy4TKi2jNHOuOOE/U212PsWM60j9ZOX3x4vxu4akcvrmSvcs13CsY+ Vq6zcyA0hmPr/ae/iku9vFv7oPvVdgJ+gs8A5pMAE4crm5rQ1wo5yT0MgCUS3XfeRpyV GLY51e3YtnBOHrk0wBb7hckvBYbvGrvdxDZ4KWys1nVoqq8sitzXv9IBs0z/GE0+okLU qENj9hF5jQ226v2p8d0I+5xJFrl4sc/d73b/YJlCGX86FWBLnBkVzyBpU7sFOnDeiZCL lnBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5pt4jZN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a632115000000b0044fb27b64c7si14260349pgh.326.2022.11.22.04.36.31; Tue, 22 Nov 2022 04:36:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5pt4jZN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233073AbiKVMI6 (ORCPT + 90 others); Tue, 22 Nov 2022 07:08:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbiKVMIq (ORCPT ); Tue, 22 Nov 2022 07:08:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3069F2A71D for ; Tue, 22 Nov 2022 04:08:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DD70B81A09 for ; Tue, 22 Nov 2022 12:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E080C433D6; Tue, 22 Nov 2022 12:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669118914; bh=i1/B8KPOq23+jpieWztQH/1k9du0dfBH3YUJ5icWXhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5pt4jZNb0tafaiF3Oqmnp2OXIsR9giOzMApVEjLuUsPGiNAWtye6goFu2yhJr79V 5PNO2nrbA8KuUnfmXOVWEvT3bG8QucY2Fx3Tsq5aSewEVF2uaxYTAAa9Si0VYkmN7S uNZ9TOSry6g2zVi0RPJUIEDzodSy0YblvpYmleLE= Date: Tue, 22 Nov 2022 13:08:31 +0100 From: Greg Kroah-Hartman To: Deepak R Varma Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: call set_lan_gain for receiver config Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 19, 2022 at 10:41:17PM +0530, Deepak R Varma wrote: > Value for the LNA gain is captured from the user as part of the struct > pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is > never called to set it. Include a call to this function as part of > setting up the rx configurations. > > Signed-off-by: Deepak R Varma > --- > drivers/staging/pi433/pi433_if.c | 3 +++ > 1 file changed, 3 insertions(+) How was this change tested? thanks, greg k-h