Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 13:27:04 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Zhang Changzhong <zhangchangzhong@huawei.com>
CC:     Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: marvell: prestera: add missing
 unregister_netdev() in prestera_port_create()
Message-ID: <Y3zAGJhQVEnzQhAH@boxer>
References: <1669115432-36841-1-git-send-email-zhangchangzhong@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1669115432-36841-1-git-send-email-zhangchangzhong@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+KJadKdUj0u6Us69pu4aIQCP6eUF2wyrDAj0D1Mj91QKMP0czXbyA0OQQlga?=
 =?us-ascii?Q?nCl/wlVT2FUm7N8d8dbXNJbfpKXPYq5qhUzBNeebzT81ps2suwuDvO2mhKS/?=
 =?us-ascii?Q?7rKOUPnJXXS1k3tgclDfWUVydGVzRoHNVES+fwwrND6yFDjiuXAXRVb0vxCX?=
 =?us-ascii?Q?45M/TkHo3TeFIvM0uWeA/8q2Xv0t/NPHzcvqWSOMu/V6lfC7qsV1f2hmEir6?=
 =?us-ascii?Q?1FzxP7XQ8Lvy5QpE1BlKrFdxfM/6yye1atc6mIsmXzYdXeyogQNR8WcjcwsH?=
 =?us-ascii?Q?2EDavOZ9VnXAG/AriqlkJPEyrUHA3/Lt3CbFBn9T7DagErrlyjk3CVVGKwD0?=
 =?us-ascii?Q?1eP40hv0nQ13PQpZjmZ+Ymq3DNTSVGsG+q8TL5Fdvwon3dUWxflV8wyjlHBC?=
 =?us-ascii?Q?k8l2b8SQzkiFnibvg5L4WlNWDZMIuDZCxGL1Za21rTWoc58S5qTnQTK3HBeZ?=
 =?us-ascii?Q?EJWi0ILepCN9QHPb+3YOHcLIVJCWHc2BwrNJMyBci72/ilJoG+gqBc0lgvNi?=
 =?us-ascii?Q?Raq7nAuChhQhICUmk2rpZ591qW9v7+QIsvlsyfY9tq0lPWG3Sgr0AouFQOGH?=
 =?us-ascii?Q?x8qvy6zhKoUL190kSCkqe1rVnMNJlsWtYJNFkrCNzgzmVPiO1kYyYwKm9tg7?=
 =?us-ascii?Q?2uUNaAwyfPwm/XCB9x2+3P1IFO1LcY6RK/gQtZouS//5lWektaHi4FpYSZU8?=
 =?us-ascii?Q?oVT1TjA+BqPFiNHB0ACL17mpNmZawekpJnPGr0L4Us2GwtC1g/iBUf374+jh?=
 =?us-ascii?Q?3VN6BE+awjRYvUtG2HztDRuHjAUubbf4/H2Y0vGblOordHoVsFjWiUKh6u2/?=
 =?us-ascii?Q?amMH37OJld1EAAIOl+AweDCr623oGPKUZKo+KxQWIVGZ1gOjh0VlHi4R4Axi?=
 =?us-ascii?Q?KEFrDeWjdM9CCLi4yZT6VD+su3T+qvMNDFEbiY9L7v4YXfdrmjozaukKXAwR?=
 =?us-ascii?Q?5kE8IAp8IvSXnbaK4yP5qMcZPXlCtiB1yCd2YMPqkImxqtnckZZcYf2tQX+I?=
 =?us-ascii?Q?pATayI3YHlqNLat1MsqdA7j2uQ6xaZui/1hDL4Ml1pRGcInw/NvzwU6BYCqm?=
 =?us-ascii?Q?7fsQVhv3AXrMKnwpdlpSoXfH6560jyYM9fixz9rf/KqnQYZJkLJNi1MhXScf?=
 =?us-ascii?Q?0zrTkDV7LETHbUOYo0RqjSw+Hr6Y3oj+rwUN1WTJGCvOHzz88dnfhjaAa3bI?=
 =?us-ascii?Q?Z6MIfoWOjSr9vK7mHNEcKbF4NjcNV90HYlHuOlTtdPZAQbkTkgESuIv7t4wC?=
 =?us-ascii?Q?AnXTlGNFJKD+QW/9oocS8yTBNydOGiMD1RMnDF3gAdhsElumDsku5eC92k9z?=
 =?us-ascii?Q?XMjPjkqzMe+jlVXgOnbV1Girs5uw+H+eWMSA0/WB4XE7PPVLlIiV/nrg1OoH?=
 =?us-ascii?Q?Xk2SHl6MazXg6EzjLcygivVw5otW34LdgGQVJDPEhnv+ghcf1RyKH+uLcjue?=
 =?us-ascii?Q?TENyKY5OFQgTZpnV6eKFeW9iYYYPukR1de7KeafBgMVpTa0sSbx6dPHjjeR5?=
 =?us-ascii?Q?i7ojr965aavCb4fDc4gCn4vH33Dh5+xCWsvttm+NafxM441LX2rqcGJ11yJx?=
 =?us-ascii?Q?3mj8LYegoPjgsUM0UeFzie6qJLx6ecRML+EF1HAFS8FSkBDSpRthyKhAiVq6?=
 =?us-ascii?Q?5A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56c9a023-a3cd-4068-c642-08dacc84e49b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 12:27:17.0603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SspCDrbSRyLtxs4a6w6KbpU7OX7pLsR20i9zQjLkXEkCyhym1XD+uYaKboRikQOtef5cONmWQ/66OodP9v6+FiUYx/lemPxy6+jZvsrePbo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4780
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 22, 2022 at 07:10:31PM +0800, Zhang Changzhong wrote:
> If prestera_port_sfp_bind() fails, unregister_netdev() should be called
> in error handling path.
> 
> Compile tested only.
> 
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Makes sense and fixes commit is correct.
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> ---
>  drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> index 24f9d60..47796e4 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> @@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
>  	return 0;
>  
>  err_sfp_bind:
> +	unregister_netdev(dev);
>  err_register_netdev:
>  	prestera_port_list_del(port);
>  err_port_init:
> -- 
> 2.9.5
>