Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 6/6] ufs: core: Add advanced RPMB support in ufs_bsg
Thread-Topic: [PATCH v2 6/6] ufs: core: Add advanced RPMB support in ufs_bsg
Thread-Index: AQHY/S6fGNUnGplQxEOfi3uFlr5Rnq5KyPtwgAAHT8A=
Date:   Tue, 22 Nov 2022 11:27:30 +0000
Message-ID: <DM6PR04MB6575811A8A988896E8738DF5FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221120222217.108492-1-beanhuo@iokpp.de>
 <20221120222217.108492-7-beanhuo@iokpp.de>
 <DM6PR04MB6575FE2AEA80828348604AF0FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
In-Reply-To: <DM6PR04MB6575FE2AEA80828348604AF0FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9JkF1KCE4Ub9ubRjHyZPxrFRyI0MGeKaaq4Z+dV8zFvI1DA8SPheiEzrL9kS?=
 =?us-ascii?Q?+bHeFlLeptOedX17448hqD7Mjy6dFfPKoOkKsXSQR/VOfXEXqhu7yhy18hl+?=
 =?us-ascii?Q?8xTDebyRKTJilXx70la0Nq1hElPF/M//XGEG4hXI6YMk/r27cz64RWOYBUvW?=
 =?us-ascii?Q?7P1f4heVtRthGAGCq55iydofE9K45Ph9ZN41vfP8MgYU+f5S01XFAeri260l?=
 =?us-ascii?Q?mYn++G4TRRoHQbApgJ78UL/hfV8HqQ+z7AmEWftUEDX7j13ujifUWrbC+rTB?=
 =?us-ascii?Q?GuQTWs2AFirlkUrw9w+afT0MW6ezj51UD2oDTfnpLCSRXBl7fEK5uO8OUXok?=
 =?us-ascii?Q?/vhMKULQxcC9GhqVThIH+Euv+5Rvl0Z7HlK7VQy3PvM97pmAYLq2fHiyKDr/?=
 =?us-ascii?Q?W74FjELS9Xk/d0mbKUL5mPExuHCXKWk0dbJMVaBKRP0jh7IVJMRVhEQ58zJv?=
 =?us-ascii?Q?GOLk6tq6jY1P3AX/LKuYmpf5DKcNS/NCez8/j75qhsnTQO4aF8UJL6TnJqRx?=
 =?us-ascii?Q?+dGw9WIdEJIiIF0gbWvHPJmKymeozIvoV3dZEv7ai3RbZ/F6hqnfrNnYo216?=
 =?us-ascii?Q?xK/6qw2mMVdW//Iro7RWJe1qyw9W1U9AVCPXQluJv/AjB3skY/dszu110Eff?=
 =?us-ascii?Q?DqzT5Sr//6gsrEopG0Ps5y+uGbOt4AJ1Y3Mwj7oMMeCTiVAyYTrZGsLWndkB?=
 =?us-ascii?Q?zTXMKE2G+ZancAGQU7U/FE2M0h6E9OP6AeTQjupRUHbx0Kad3RBX3g7WyRo8?=
 =?us-ascii?Q?8bkbGO84TsOGk2xa/5hBMFzEREBVk9mYt1npOKViASHSeruFLnIdgBhpR5VJ?=
 =?us-ascii?Q?9IsyXPZp3Wrf87FccIJwwcg50BLuNkdqe3ejS7z6T73XJAJlCHWYRMUl1+gt?=
 =?us-ascii?Q?J85yFR0zojEVANRUxqddPYJst8tzxCjpHihl3li77OZLdk61V/EGy8muQA/V?=
 =?us-ascii?Q?pAdPEunxesn2sssb2AmvXGzT8/5EATHIHz7LzrTJWEYG4j+xMgff1aX1jPPH?=
 =?us-ascii?Q?Ybox37/SLgQyS/gItMs0wHc9BhD7xUpFo5rMAEvs8bDW8ZDYpK1uQy1B0Xeu?=
 =?us-ascii?Q?fkueBLqYrkIUN/Rkf/shr/t5JmToTzFv5flE6mJWtmiVWEXs74YqhCnxJAMp?=
 =?us-ascii?Q?j6bs5CAGLUIgJpcp6/IzmKG8BhSIm4OLWZ9bTyFUlYnDlokPRYRT7pGyxda8?=
 =?us-ascii?Q?ojaJRqJBM7qj55pFKgtB+luI9xbbErxfD1kefwfNDRkOMUUfksCQntJZ7UXy?=
 =?us-ascii?Q?G5z2oEgOr4vPV2WbtIz8Dk+GgeR9051/WjNxNMqGa80AAI4LEIcam7VbYCqM?=
 =?us-ascii?Q?yMt09LzxK4QhCjLZJphUWNB1M8LxWJS05r7ydbOIeyjj6D0bz52DEXUvfQul?=
 =?us-ascii?Q?NjU7i2RZsZwoqQnwWFYQHkEpfVyx1GKzn/96TPsAiwZdlnqIfQ0dV8DIsDpE?=
 =?us-ascii?Q?77qgLdM0nddCqvqigV5SiwWSnUReBfsHCXdzMw09y1iyqrre/dB5FylpDJJi?=
 =?us-ascii?Q?a6iG1I6433+P+Ul7SGwg7ZhEt1XWKYGHAhqwIO6Q3HgPHPHSr3Y/ckuCvyKj?=
 =?us-ascii?Q?JWr8iSxueVb+zcGNBSBGcO9+e8Kj3+94n3MKrWDb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?lXu/KgcQJXnkzFJh/PVavqNeJ3zI+7FDE+oSO9jDE1pibYaT/Bn+I8JXBfhM?=
 =?us-ascii?Q?2cm7bIw6pw31ZiJN3oXrzIy5exW6BtOmBqMtUShzU3p6OxDexT8QXJKhoZ2F?=
 =?us-ascii?Q?yo9wKR7R8Iim0831hCXeYnFteSd2zchYq9zWkZVF8LduGjqakpxQdj/fDbmi?=
 =?us-ascii?Q?RnB2uCrQmfQbJIx5Q5OjmH+vvvVgwy6knL7HR2faeMliNElcSdCPNa7khfwf?=
 =?us-ascii?Q?xACvA4xUk/zH7wHyYKFlDifvTB3qoeGd5y73+dySiusjaNWYudS4oCJHEAQy?=
 =?us-ascii?Q?FuKlkZIgowtszAjWglaoijOr0nsIaqHb9Yn4veaIvLS1OBmHrtOGciYCzJcX?=
 =?us-ascii?Q?qSpf0q+eouUps9Dlm/efCwDzjZqcsK6o7ietfQc0bcU7hFI0meCHXx1VLE/B?=
 =?us-ascii?Q?bhA89bgMqCBLsWFpj19J4DxOEsN74R54a46TzRNKLn3IrQhPF84hICdZ9+LY?=
 =?us-ascii?Q?VuyYO2Kmz0FM6jB50RRL+206P8JlMLH/W55AUGF5IaFmRUInkyXMLXw2X2Qt?=
 =?us-ascii?Q?DOddM+QSsH+in615tZdzArp564iYS6rLy7LbEuTaqkHxY0P3jDRqZRuJfhid?=
 =?us-ascii?Q?FQmPV84MqzW43MixBKYcDtoLGb4vycAbbCPX/MEoc72/NKhC+vCUF3qqXTQs?=
 =?us-ascii?Q?btD4Y9sxmglth+85lve18q7Gxws78XlJ/iDJeYCDMy6CHMFEgv9gMH6MhYFh?=
 =?us-ascii?Q?iC5A7if2XQD35RqlptYv6T6EKbMKgyFCesCqL3GkmRdD4pF6K2Wdn8ewGQpO?=
 =?us-ascii?Q?tWI6YNnU9vj1+pjXUdNgAgBHDK4sAgVQRD+/tkoJXofIPPvb+TIvk6+9k4v2?=
 =?us-ascii?Q?VM84Eq+3HvTSw4J6IP35URMjnY8WdCso4e0SSkXgJLKKjQS6zGJNlmHE9Mjl?=
 =?us-ascii?Q?4PiQBVH1YblGxf5M7O+CToeJngvra0uM86I0EiZXDm46uYfSrhxmJXmuPua+?=
 =?us-ascii?Q?rkpqj+A9WyX+VwyozlfBE9/1SRJY1r9Dx7sgKl7zcF1EIS5hiapheSx991M5?=
 =?us-ascii?Q?ScGbj22axKFy0zZscbF8zeTioQwrD0Flai0H3vIfwW6MV3oH4jp0J96GGarH?=
 =?us-ascii?Q?mf6387UcC/QuqXmVUcUwIGPj9UzM5+ZNRQX3zQERofedwinkYdRHQj2PYxGc?=
 =?us-ascii?Q?uzSBZNUWFsgkql9buXI3pgGujwPcWIlwhORH1JLJcxUsmlv6xhrV/yCaD98P?=
 =?us-ascii?Q?V/BLNaEu7Ny87pLIL8PbU0VyrzlelEknXeDJIVg7ybdwEie6qZFcwFDSU3OI?=
 =?us-ascii?Q?9KJ8u2sKZh6h+PgbibTW3UhQ5qf35sq81Pn1pzmEFQ=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 802b1928-88d2-4f10-5211-08dacc7c8b24
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 11:27:30.8458
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JA34tpr1M7yeiKEXpO8ftGQh3I2yxUcJ+nEb9A1OHtDEZaYKBR5xAkqXtAW44GD6Hmf7YmELLqOut+4MmvnXrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB3808
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> > +               sg_cnt =3D dma_map_sg(hba->host->dma_dev, payload->sg_l=
ist,
> > payload->sg_cnt, dir);
> > +               if (unlikely(!sg_cnt))
> > +                       return -ENOMEM;
> > +               sg_list =3D payload->sg_list;
> > +               data_len =3D payload->payload_len;
> > +       }
> Isn't bsg_map_buffer does that for you already?
> For both request & reply?
Answering my own question - no it doesn't...

Thanks,
Avri

>=20
> Thanks,
> Avri