Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5793503rwb; Tue, 22 Nov 2022 05:07:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf7V5e1gSlz9HEGULmD8BJnoYTWiOnaCyQxbO3rbx8puRJZRlr+RCinFFPu9xP1o+eF3K0gK X-Received: by 2002:a17:903:285:b0:189:25fb:ad0d with SMTP id j5-20020a170903028500b0018925fbad0dmr7031193plr.29.1669122477209; Tue, 22 Nov 2022 05:07:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669122477; cv=none; d=google.com; s=arc-20160816; b=xAKvN4DuYWeJ/YRDZCSysivIPir+Y6lHBsQDE2t+97UbYhTIlNiSBFEJ8feiiZAH2t aTuWJkp5YcLdzyD3GpCNh2C68B0cVOC4XKUhgFgNL8y6I2bZwxXkFjatw6/GnMaYUGSD 6qnpTIJjkvGTH9mFRYiUOVLcqOuPTtonsDKI+OahoT6nczcUrW2B9i9u5fYeLwL7S6oL abYXqjyQJDuQmQC1V+toOIufPk2uN139Bfz8GWOgE+R5PEvqMcbosaZDPXP49DB860GS 50PlDZidrJG3CF/zGOjeOubtH74qzoTskzey+JmcNKO5WK0sOqgRPluGHB1qh2zMxRxa JTxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ILulZv8ft43vaTDhHYvpuq9JEJktT99CQAIqEZ8ySBQ=; b=C3IjN7ZnzjBHJHX0RVVWWLQhJ5STaiyNtKhT8LIHp//SFaBVp6Hn78HPGI3h8iznUL /vpWMAVmXgRSwgY0RDdr+HzO2uBocvOi+5K0KX8YHQRX4g0IjDEa9JAB4kiVhCQeX3Kh aDBJNMmezZ9pr0TmqpnWZMicRe4G0CxqVNjMibsoqWzU1M3M24qaxotZPlwvrPLPoPN3 edZfTbHQvSnaLYM4BjV9LkmaGvCPEmUJrU48nRKD38s0M/5Gq/nWZTAT1DXw21h7TIUM srRsuc98K+U7FwL6/uDvq80+Zh/5TKSpif5+OTZuzCT7jNnfP8tUe1gH9unwtFVpXfJ0 SAyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Vkrd8/Fq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk8-20020a17090b4a0800b00205e1caca43si16288041pjb.34.2022.11.22.05.07.44; Tue, 22 Nov 2022 05:07:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Vkrd8/Fq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233466AbiKVMux (ORCPT + 90 others); Tue, 22 Nov 2022 07:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233276AbiKVMun (ORCPT ); Tue, 22 Nov 2022 07:50:43 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95DD960EB6; Tue, 22 Nov 2022 04:50:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D0E4DCE1C8C; Tue, 22 Nov 2022 12:50:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF69C433C1; Tue, 22 Nov 2022 12:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669121435; bh=gPiGw4vRC33iKPpfayqibaQp6g5bo+fr0oWzwH7ZzE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vkrd8/FqPelYrxzfMgg6HuPXAQ+AFOCItv7dL4t/4gXXgj7GzvYB28hkC6lzaN2Br agaXFvummz6Jn1rjCouqYvw2OPzra+N9QmF5PhUNSio1FPjw+B9XcixFS+D81fY+iH IT15fGJJP0qAxh+M4djZ2zyhPUeTr7ckiM7YuRqw4sFDMQqVKgBUM7kTLBUOV365IS KHFrm+7pcFbWxHqTlqeH1G8jpQqCZqw0ltsRAc+cJQCWfF5NcSWDBA8U+yu4D9AJar KP4rRDruHMV6tKkIYV2JPyWkh2oj8SIWAIBzH8Syb7+jfu/7no+LbG5KSrQnoTgsaC /Pg3hq2hkZuUg== Date: Tue, 22 Nov 2022 14:48:31 +0200 From: Leon Romanovsky To: Moshe Shemesh Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] devlink: remove redundant health state set to error Message-ID: References: <1668933412-5498-1-git-send-email-moshe@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1668933412-5498-1-git-send-email-moshe@nvidia.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 20, 2022 at 10:36:52AM +0200, Moshe Shemesh wrote: > Reporter health_state is set twice to error in devlink_health_report(). > Remove second time as it is redundant. > > Signed-off-by: Moshe Shemesh > Reviewed-by: Eran Ben Elisha > --- > net/core/devlink.c | 2 -- > 1 file changed, 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky