Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f50021f-2dbf-4e5e-d85f-bf41a02b6b6a@suse.com>
Date:   Tue, 22 Nov 2022 14:59:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 2/2] module: Merge same-name module load requests
Content-Language: en-US
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Prarit Bhargava <prarit@redhat.com>, pmladek@suse.com,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>
References: <aa8d9456-b260-d999-0296-8e6ab876af7a@suse.com>
 <Y07xX2ejlg0oFoEy@bombadil.infradead.org>
 <d0bc50e3-0e42-311b-20ed-7538bb918c5b@suse.com>
 <Y277Jb9i2VeXQoTL@bombadil.infradead.org>
 <e070839f-c224-047b-9411-91143c1d8394@redhat.com>
 <Y3Jg8X7qv2AKPU1J@bombadil.infradead.org>
 <5467e66d-55de-ca8f-c1ae-ffe6efe7290d@redhat.com>
 <Y3Pol5H4kJioAV9W@bombadil.infradead.org>
 <c2e841b7-e2b3-09f9-8187-328131d72c5d@redhat.com>
 <049a8f8a-baf8-744d-6250-575fc0dc533e@suse.com>
 <Y3vLbDAeILx7gJPT@bombadil.infradead.org>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <Y3vLbDAeILx7gJPT@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dFNklkcDJ0YWg0RjNoazJGVytNWFdKcXNhL0lWdWZZTHBPNkJTOWd0RXc3?=
 =?utf-8?B?RThEQjR0SkVrRmdJazljZ2hsd0FFZERlY0pvVmZKeFBWRmMzOFZuNGpuaFBs?=
 =?utf-8?B?MHRYK0NSOVRCQ21acXRmYlZpVGpXTDBpRzNuL21DSE9JSmM5Yng0d3F0NnA1?=
 =?utf-8?B?ZG81aUNrT1RZcTloblNZdWhmNXVzM0N6ZGt1Zmg1ZkZqOWZWclJLME5lTW5m?=
 =?utf-8?B?VndxWFc1c1J6Tis4SENyT3F0WnFUKzBmU1hvTzUvalB6OTk1aUtLN3NOR2Zs?=
 =?utf-8?B?KzIwQUdYV3FYb2p1RThkRllwdG1pM085cHpIc3NSV0JCVVZ6SmJzeElKVGlK?=
 =?utf-8?B?eGNidjBoMHpvWENXSTk0YlROekFsNXNkd0Y5ZkxlTlVsY25XZ1U3Q004aG5o?=
 =?utf-8?B?S3lWc2ladHArM3lGblF2ZC8wb1JsdUtrRGNDRGdXM1kwOWNqeFlSK2pIRUE5?=
 =?utf-8?B?cnAyWEgrU3VaSElMNXk2dUJxS1I2Zm1xamo1UUFsdi9oeXdCZjlmWmgwVCtv?=
 =?utf-8?B?Wm5jRkhiMUFyYWpINE5pT1hrVmZ5OXdBc2ZXZkxDNk5FMGtMOElFbWExSVhO?=
 =?utf-8?B?d2dIRUtzUmgwdmVtUnBsSkdkOHVTbllXRWtvUDUwcTh5UitRV0Zld1Urd3hm?=
 =?utf-8?B?aUJQeGdTMDdXMnZCYityTHJEMDArcUkwOFc3Z0c3S3JlWUxOZVZicVBDZmgx?=
 =?utf-8?B?RXE1ekxiMHQyT1duNDZDbmJ4VjR2aTMwU05IbEpWdVVvdnh0SVpxUDlJSity?=
 =?utf-8?B?bThKcjQ5TWNPcjVQeVBTcDBjbGtCaUZ2VUVIUHVYd0pLT0IvYy94VkxBcHpz?=
 =?utf-8?B?WHFzNUJBNHNVc0ZzTGQ1Tm94YTArSE11WDJWVGpoTzBFMGx3cG9xbStDeWJy?=
 =?utf-8?B?ZzBPZDN1UEd1UVlNYS9BdlA4bjJGbDlCbU5icTMxOWtwSEhSMWt3VEpFUnV4?=
 =?utf-8?B?amdkTnhid05aUGRiaHl5UUNadFlIRUtWd0wyZ2Q1cFZYOVR4RDUvdmZkTXU0?=
 =?utf-8?B?a0RUZXZYcmc3WW12SFBtdlAyUmMya1ZUR0NiMmp4bFliRVYrbmVrZlRwSGE0?=
 =?utf-8?B?WjFOa1RXZlB6dG1tQ3NqWGJBV0EyUWpOc3FreHo0dks3WUwwMVBJaTRaYjgz?=
 =?utf-8?B?Z1F0aytZclI2M2pGUzV0WHdqRHIwT2R4a1h2YmIyNHRVdnVLMVRVMEFteUpN?=
 =?utf-8?B?NUQ3M25ZYlllQ3dwcE9tM0JGL1IvWnBJeW1iWHA2SG82R012YjgwSVhpOFpv?=
 =?utf-8?B?SFNlMTdnZWhJcUlMM25yMDdzWDRrY0F4Q3loQnF2cHFRYWVlaFByREVWb1Fm?=
 =?utf-8?B?VzJSeFpCYjJTSUQxY0VUVTlyREgrdG1kTytuS3NwMXM2bFVCVUVkbWFJVk1p?=
 =?utf-8?B?OEZrakw0NmlkajhjMlo4VkxEVnh5UGhNUUJENXZlWVZobElzc2R4ZTVueXI2?=
 =?utf-8?B?djd6bVdaTStQTytLZ0RuNEhvQ2l3a1FKSHBxbTBrTlJrdUhxbXRnUjFobFkr?=
 =?utf-8?B?dE8zeVZKZlZTWkpFNi9pM1BSV1B3Ykx4ZW00UWhQMDQ0NHkrUDI1TDh1allO?=
 =?utf-8?B?dS9IVDlPZW8vczdNZjRaRkxNTUlGRUZmRCtSSHJrWHJWUmlwdzBNR2J3UFpk?=
 =?utf-8?B?dXpQb1lzUm56eTJlbGYwTWkremZDbnJzbDhodXhoMkV5eHByNVBkQzcxMDRr?=
 =?utf-8?B?TzQwZCt2eGNjd3grM2g1OFd2UmkrYm8rK3V0YjNQYlZXY3FtWkRyZE16bCtx?=
 =?utf-8?B?OE5FdHVlMW1pMU1YdHdFSlJnd2JyaEg4eHcvdmpNdHR5T2FWMk1ha3J1WnhW?=
 =?utf-8?B?WlFjOTF0YmlIWDVSek9IVTRXL1Y1MVBidVBFZ1BFVmlHMVVYR0pEQ2NqV1Rr?=
 =?utf-8?B?OFR4cWw0ayttbjNoenA0WW5nakRFcGNnRjlTN2VQTGlTcW9sbkVaVW9zTU4w?=
 =?utf-8?B?T2h3YmRCWEZJMXRpS3Axb0thd1I0Y2FlVEF6QjNZZTc1K3ROSllPSkd3Q0lr?=
 =?utf-8?B?eno0YXNpVnVVbGdBK3Y5TU1KcCtsQktYNEZuL0x3djNkSWkvVTZUdWcyU2Fu?=
 =?utf-8?B?ODI2THA2bkcxY2I5bHk3eEtnbWYzeGx0YXQzZFc0QWVSNjExekQzNFNYYTBF?=
 =?utf-8?Q?liLar6QBml2YbFTOHbKCT5jFI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f02c376-925c-449c-1bca-08dacc91c0a3
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3395.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 13:59:20.3085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uu6WxfxgiK7feBzWwRTuy0y2SUX9d+NFqAKFPqQANoe7t+xPyjf1IrI+AC7VN2ItQgJeLxkm9/jNBQtE+lh+RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8744
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/21/22 20:03, Luis Chamberlain wrote:
> To be clear I don't care about the patch mentioned in the above URL, I care
> about this:
> 
> https://lkml.kernel.org/r/d0bc50e3-0e42-311b-20ed-7538bb918c5b@suse.com
> [...]
> 
> Petr, you had mentioned in the commit log for your second patch in this
> thread that your change fixes a regression. What I asked for was for a
> patch that fixes that regression alone first so we can send to stable.
> So what issue is that alternative patch fixing?

This alternative patch fixes the discussed regression with failing inserts of
acpi_cpufreq and pcc_cpufreq delaying boot. As mentioned, the situation can in
the worst case prevent udev from loading drivers for other devices and might
cause timeouts of services waiting on them and subsequently a failed boot.

The patch attempts a different solution for the problem that 6e6de3dee51a was
trying to solve. Rather than waiting for the unloading to complete, it returns
a different error code (-EBUSY) for modules in the GOING state. This should
avoid the error situation that was described in 6e6de3dee51a (user space
attempting to load a dependent module because the -EEXIST error code would
suggest to user space that the first module had been loaded successfully),
while avoiding the delay issue too.

Petr