Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5932621rwb; Tue, 22 Nov 2022 06:49:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf56S5/BnKfWusX45JzbgdxP9cpXYVXM4ArMnG/b1w9T8+Tf93OvODOVe+KtrGzv9mPOg2Rn X-Received: by 2002:a17:902:cf0e:b0:17c:5b01:f227 with SMTP id i14-20020a170902cf0e00b0017c5b01f227mr4076663plg.3.1669128554244; Tue, 22 Nov 2022 06:49:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669128554; cv=none; d=google.com; s=arc-20160816; b=rCy1/5sTwkEpGZMFeADOCvoLU2cHENd0lbEuv8tcVRC4Fw+nEdhKXinO3O4++1fOE+ J4n8dtDabqdFLPhI7rFYBM0NNgtOnoHHIfDcjbcFL0730DPuaUmOO5fYL0TEwBbJM2yJ 5bofnhapRNx1JkuKfTf++s6ViLJu0uWDGxMshGeWfEiuv9NvN2tem9ZxjFJi/H+ZSW0M f/gR++2wlFe2MUP04G/mTczGaCQqH2LS4jnrPT3kEmLUrSRHfXJoNaXC+sDT16wzaraK hJCjSFjDl1zaZVtEf8/I81ft+2eIVrmCBNel1eyTZUCGlXSGmH6yghS0XDz3Z0XEFesD yY/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FY+JqUTCgihErrGkfvd81tTDafGHo4/Ls5aZBztvCRI=; b=elMftTCd/PpgeBDIO+eokiwjz2gyfjE9EaRxjyIsIlG92jSBGAqICmYZGp/oKzuaXG OGWeSN6O/Jse2maa9834zf6xJb2ubrMQlghn4Fu4NdqS9Ydw3WUN7bV6b7eb23YdcgH4 LfEY5HEXAYTlLVSTEfHzeIDaWh2wHi9TcO+5rrxlHzcWFq6G3+fiL5wzE+th7Rz3nXUF 3Sfl14w713P/CsRqttAh434dSlWZjH/Y4Rq4EzOFCiaBmiwwop+EcCPZXUeQlm30ujhR gk5smzagiBvdk6s9WFISoGWn2YcxNnDpO8VA4wd9VSxeu82u+RUzAmuKdHHTe0Y+wRbK jCtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=AYvzjRrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a63e707000000b0046f71a7292dsi6094090pgi.384.2022.11.22.06.49.02; Tue, 22 Nov 2022 06:49:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=AYvzjRrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234023AbiKVObK (ORCPT + 90 others); Tue, 22 Nov 2022 09:31:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233916AbiKVObC (ORCPT ); Tue, 22 Nov 2022 09:31:02 -0500 X-Greylist: delayed 4084 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 22 Nov 2022 06:31:01 PST Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CD9065E44; Tue, 22 Nov 2022 06:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FY+JqUTCgihErrGkfvd81tTDafGHo4/Ls5aZBztvCRI=; b=AYvzjRrTruNeQnueKgELb+zCk8 UVbGiVtGj9aoxeLpY3IHAd6Yyk/0XAO+o2htBjsFecMi89SKtq9feHUApjGt4pHm9mbOA9I+V6mQy eA1GZ6fQ6GWJNN3dCHh8ww04qprqnImBnhWQLBqyOQGGeGjftBRgox+qxDxtDwCs7Pe3JTcckNuWw 22NGy7Gh2WlrpbVnmNlxHaFUiSJQ0FGaPuTPCZR61CqiCeq1X2BlTCgPo3VjT41nAbu/kZbhSbP3E nCOY/8g75zWymxjFr1MTnfhgzD0q7u7PDtf6dQ4r8PSil1SrtlAunMWnkjmPGBICS5bbVJH8nkYfS sle/jWGg==; Received: from [177.102.6.147] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oxTEh-006xXr-3p; Tue, 22 Nov 2022 14:22:52 +0100 Message-ID: <3f0bc380-e6c9-d1fa-a22f-6ba9051d4219@igalia.com> Date: Tue, 22 Nov 2022 10:22:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH V3 03/11] alpha: Clean-up the panic notifier code Content-Language: en-US To: linux-alpha@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , richard.henderson@linaro.org Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Petr Mladek References: <20220819221731.480795-1-gpiccoli@igalia.com> <20220819221731.480795-4-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220819221731.480795-4-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > The alpha panic notifier has some code issues, not following > the conventions of other notifiers. Also, it might halt the > machine but still it is set to run as early as possible, which > doesn't seem to be a good idea. > > So, let's clean the code and set the notifier to run as the > latest, following the same approach other architectures are > doing - also, remove the unnecessary include of a header already > included indirectly. > > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: Richard Henderson > Reviewed-by: Petr Mladek > Signed-off-by: Guilherme G. Piccoli > > --- > > V3: > - No changes. > > V2: > - Fixed rth email address; > - Added Petr's review tag - thanks! > Hi Alpha maintainers, is there anything else to be done here? I'd really appreciate any advice on how to get this merged. I'm also adding here Richard's linaro email (and trimming huge CC list). Thanks in advance! Cheers, Guilherme