Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 10:46:39 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     zyjzyj2000@gmail.com, leon@kernel.org,
        Bob Pearson <rpearsonhpe@gmail.com>,
        linux-rdma@vger.kernel.org, Mark Bloch <mbloch@nvidia.com>,
        Tom Talpey <tom@talpey.com>, tomasz.gromadzki@intel.com,
        Dan Williams <dan.j.williams@intel.com>,
        Xiao Yang <yangx.jy@fujitsu.com>, y-goto@fujitsu.com,
        linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH v6 04/10] RDMA/rxe: Allow registering persistent
 flag for pmem MR only
Message-ID: <Y3zgzyMN71AmIFPI@nvidia.com>
References: <20221116081951.32750-1-lizhijian@fujitsu.com>
 <20221116081951.32750-5-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221116081951.32750-5-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5cszWiyyyOE1vQhECA9GkYx6vmaceVjRohz4RPvgV0cjcz+njRBtQQJaS2BS?=
 =?us-ascii?Q?AQCBnDHtU9HtZyIRHc++hlWbc/qo4qxbQ8phh0qTPGZyEvFBnKLHigftgTFL?=
 =?us-ascii?Q?vZBXxyvLD4J2cHtxnGfDYeYwxJoTWlS7t5LbTuRNQxGo7w+75gxMRrv7f4J0?=
 =?us-ascii?Q?p9R1yon+5PRe7nz9I8n77azp5Fq66l86qpxNGW7Rtg0SzuEHjftBodWSmdyH?=
 =?us-ascii?Q?uC/Od8g6/cyHfbaoAA0j+liYhAOUDdCeGIitJ9IlHFJeU4J5iBP8P0m4P9wD?=
 =?us-ascii?Q?DQYwuaxCrLH3J+rXFPnJWjG+e0enrRS5aul72LgCZPDONWgvr4X/81pz9TsX?=
 =?us-ascii?Q?K4lySkG6XZLf1NRQqYU0DRzI0GHyYcfk4kiKHKdLpTDv/vaUGMmwC4XIiFF7?=
 =?us-ascii?Q?vCbqn8j8P80bLyKEV2PMfcb1Qd3Zsgfii4KhUU/ZRQ0MwPKq98ugtYQ2rmzM?=
 =?us-ascii?Q?50Apu+2Ln+hi2ymCMmLvG9cdX+gVzPFoQSQwrrVlzkW6NKEaKkcquONj6z+L?=
 =?us-ascii?Q?37cnb9DF6qAKv/1P1i43Kndzc8a6VElIGRhHULvpRbR3W63kuBVjsN79xXb1?=
 =?us-ascii?Q?dEEcAHQfrpoNnfRiFwXSUsTLSjQhLdDJc1M4QaLiBcnwZUdfbN9+VZKklgur?=
 =?us-ascii?Q?2mecPXw5ial611XhuJUmdLEuTQJsHmoEMFZpQHggEa6p2eJVKkFruL/czZLi?=
 =?us-ascii?Q?5/NhWImjMJdkcq6m1nIEw46EcLoyvVDgv4O7jbydPRA7h3a4AXIPB2HcSfAF?=
 =?us-ascii?Q?MlwJMBJH/D6BzJVU8+uXXrfFt3TzXYa/pjHLCf6MbX9Ff4Byj0AcNCYOQusp?=
 =?us-ascii?Q?YRLY9PUOH38LJ69PVqZZWZWxIvSIUTiBbAq6q1rvTElwL1KTJhHvex5YgCm2?=
 =?us-ascii?Q?3n6xPJ0nQM0mUUckjrT+XQKFskmeBaZIGJwGXp7hBPa1lAk1gsxzogA1LUzL?=
 =?us-ascii?Q?aQf/2FZw+B8mB4fU8gudRZLNQRKaeKH6nX7jn8Vz3Dqd53MAd3ifh5qG1yq3?=
 =?us-ascii?Q?ymCV3glZxA58CssDCOFuPN4FBNu7Fe0YhlMQzlbGVhUheR8tD/X8IArM9KlG?=
 =?us-ascii?Q?UEnkjMJBodFmVGUAVO/7exbBCsRe/5XciGABlZHp4c+zr9R1BL9ToifvsECv?=
 =?us-ascii?Q?+znyTrD0U2V+4FwdsLMfAZKv6/h/RNYGAK76z4bsGa/bkqoA3QjLbjEcwQh8?=
 =?us-ascii?Q?sw6hdLFESqsvE8J+oNfXrKWU8EcbRzGb2iF/3QJlkwh+XtZMBIyK2vFX98HB?=
 =?us-ascii?Q?UacVrsIpM+KP7UYFLmAledts3RVFmr0eKNlOL51VeM1U7i9sQLtyuuxCJFUK?=
 =?us-ascii?Q?/Rq2rFY9w3SLO3L/pFvIJ6h1AUhfprQb6cAdFel9J0UUZW3pAk7k3XtNCJVk?=
 =?us-ascii?Q?QAZgu2haRD4F4MMOgY2+Qe55/4kGjmNqR4JokcNYUA0icOimuoKkGtPy5F5+?=
 =?us-ascii?Q?SHhKM6M+1Hf8gQJHWnhtm3zw7s+OqJmBb3Ue5lLFyf4O91J+8M5sB7zxhoox?=
 =?us-ascii?Q?V0irGJs7hd+/cgO/ZnVyWQlbatfH4I1vxy2LNa+69nQBEutxAXhammT0vig9?=
 =?us-ascii?Q?BZMln2Td2Kx5vwQjx+Q=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f00b273-a126-4ea4-76e7-08dacc985de6
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 14:46:41.0389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VbTf4a5RutSvheOMQZ3v9AZpQOn22weljw5jsOtVVbjp+9q40wC0UNMNJH+kTrjd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5386
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 04:19:45PM +0800, Li Zhijian wrote:
>  int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
>  		     int access, struct rxe_mr *mr)
>  {
> @@ -148,16 +157,25 @@ int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
>  	num_buf			= 0;
>  	map = mr->map;
>  	if (length > 0) {
> -		buf = map[0]->buf;
> +		bool persistent_access = access & IB_ACCESS_FLUSH_PERSISTENT;
>  
> +		buf = map[0]->buf;
>  		for_each_sgtable_page (&umem->sgt_append.sgt, &sg_iter, 0) {
> +			struct page *pg = sg_page_iter_page(&sg_iter);
> +
> +			if (persistent_access && !is_pmem_page(pg)) {
> +				pr_debug("Unable to register persistent access to non-pmem device\n");
> +				err = -EINVAL;
> +				goto err_release_umem;

This should use rxe_dbg_mr()

Jason