Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6008690rwb; Tue, 22 Nov 2022 07:41:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf7mg7hAvNNcnsjVvdv3wP6LHcFQay7GMmDjf+ZVWTo8OaWRDDsVpRWKLG+dli/mQPlYqhQJ X-Received: by 2002:a05:6402:f28:b0:469:9acc:1d46 with SMTP id i40-20020a0564020f2800b004699acc1d46mr9433356eda.244.1669131668463; Tue, 22 Nov 2022 07:41:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669131668; cv=none; d=google.com; s=arc-20160816; b=cvXX7Xeoot1Jk4wvlefJQaBYrQrHZEVJNDNpZDcgDULBpndZqgjCBl6EFEwlYQxJK/ 4xL6xE3beXSGm4839oo7+OkZZSGaGb7Oa8/hO/OCw0wOzVAS/JAQ93vj+c1B+sdPj7bK BbeztekwISKgHjaDoZiFXWK5qB7KaB5yvPAvsY776rlinU/PRH6UyaM+uE6k0U8FQRwU r1JygN43e/VFtjZ/DF0dvzl2eNxby/T+zGdvTVE0DXQz4tvrgUv0FZRTbqjW5FXTfbK4 Zoq6EEGsTTgQQYhf9nH4xRRKHfSJNCF3JwaMS6SnG6ftQQoYTMGLgV/HQKPEutGRlUcO cK7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=5GGE7FC0VbB9ME+IIY26UDo8Q/8t4dYyVs/bf50QXJc=; b=MpbwZUQfyxAbOM6j41xyyjZ2pmyJmiGH1AnTm8c01PLYXLt8DNK4D3qmEoW/CCPew1 w3bP30r7QQ3bkqCY7xlHwoNfjMFx+JVJOcWRGDPshjIhMi8/cLi2O4M6HI/6gmpojNzk dGxDpFWSWcoHLjE/FPNU+7KhqG/UUDPHXFz02H8QFllbqBUM3rPoOZGCd2ponm1Bwu/y XrAF/FicMFnwgiIG/PTp7zGKNmyUB6hdlkZttqoazGnLoFe/RHvQJ1ZsuupyFwOE2MX/ e0iqKvJ1SRlVmYRbtPDXRAHKjbyUGPcjXjZ7Jh1gY1RQFl6IOMnnk4n5beRhLOoNij1t ZN6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=I3aeFRqR; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg22-20020a170907971600b0078e20d9c473si12797512ejc.764.2022.11.22.07.40.45; Tue, 22 Nov 2022 07:41:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=I3aeFRqR; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233083AbiKVP0Z (ORCPT + 90 others); Tue, 22 Nov 2022 10:26:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbiKVP0W (ORCPT ); Tue, 22 Nov 2022 10:26:22 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E9ED5DBB1; Tue, 22 Nov 2022 07:26:21 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4883021F44; Tue, 22 Nov 2022 15:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669130780; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5GGE7FC0VbB9ME+IIY26UDo8Q/8t4dYyVs/bf50QXJc=; b=I3aeFRqRUnN2wMgV/xasqgLeSP1x8Z/ulzGWShP9nINc4tcJ0wrjhcx7zVdEqbx1+g1z9U Gwq6r15krk/L2NExIG94NJArgapusYM9anBKsutrGCO1bQXt7FBxjy+s4SJuArwZsDzZox Lcfe2p1csPxuJvr2F9ma226d1L59wVA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669130780; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5GGE7FC0VbB9ME+IIY26UDo8Q/8t4dYyVs/bf50QXJc=; b=vHgDAT6ikewgH9hIhpgb8W7bSpmJwdgE8gXx+8dQyTzYAqqIsY93TfRROcSSpx+twIj3dr lZAannsW11a9kSDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 161AE13B01; Tue, 22 Nov 2022 15:26:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7SExBBzqfGOXFgAAMHmgww (envelope-from ); Tue, 22 Nov 2022 15:26:20 +0000 Date: Tue, 22 Nov 2022 16:25:50 +0100 From: David Sterba To: Zhen Lei Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo Subject: Re: [PATCH v2] btrfs: normalize the error handling branch in btrfs_init_sysfs() Message-ID: <20221122152550.GF5824@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20221122115002.1831-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122115002.1831-1-thunder.leizhen@huawei.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 07:50:02PM +0800, Zhen Lei wrote: > Although kset_unregister() can eventually remove all attribute files, > explicitly rolling back with the matching function makes the code logic > look clearer. > > Signed-off-by: Zhen Lei Added to misc-next, thanks.