Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42c7effb-691c-c7a1-0d7d-8ba1569c0269@linuxfoundation.org>
Date:   Tue, 22 Nov 2022 08:43:14 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] tools: selftests: Use "grep -E" instead of "egrep"
To:     Tiezhu Yang <yangtiezhu@loongson.cn>, Shuah Khan <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <1668763704-10408-1-git-send-email-yangtiezhu@loongson.cn>
Content-Language: en-US
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <1668763704-10408-1-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/18/22 02:28, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
> 
>    sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/testing/selftests`
> 
> Here are the steps to install the latest grep:
> 
>    wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
>    tar xf grep-3.8.tar.gz
>    cd grep-3.8 && ./configure && make
>    sudo make install
>    export PATH=/usr/local/bin:$PATH
> 

Does this change work without the latest grep? It seems to work on
grep (GNU grep) 3.7 when I ran quick test on kselftest_deps.sh with
your change.

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   .../selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc       |  8 ++++----
>   tools/testing/selftests/gpio/gpio-sim.sh                       |  2 +-
>   tools/testing/selftests/kselftest_deps.sh                      |  2 +-
>   tools/testing/selftests/net/toeplitz.sh                        |  2 +-
>   tools/testing/selftests/powerpc/scripts/hmi.sh                 |  2 +-
>   tools/testing/selftests/rcutorture/bin/console-badness.sh      |  2 +-
>   tools/testing/selftests/rcutorture/bin/kvm-build.sh            |  4 ++--
>   tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh      |  4 ++--
>   tools/testing/selftests/rcutorture/bin/kvm.sh                  |  4 ++--
>   tools/testing/selftests/rcutorture/bin/parse-console.sh        | 10 +++++-----
>   10 files changed, 20 insertions(+), 20 deletions(-)
> 

Please split these into sepratate 5 patches. All rcu changes in one, net in
one, powerpc  etc.

The change looks good to me.

thanks,
-- Shuah