Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19f1a4fb-42b2-580d-3736-e0e1d0cfe7fb@wolfvision.net>
Date:   Tue, 22 Nov 2022 17:10:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [linux-next-v2 4/5] arm64: dts: rockchip: Add support of
 interrupt to ethernet node on Rock 3A SBC
Content-Language: en-US
To:     Anand Moon <linux.amoon@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Chukun Pan <amadeus@jmu.edu.cn>, Peter Geis <pgwipeout@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221116200150.4657-1-linux.amoon@gmail.com>
 <20221116200150.4657-5-linux.amoon@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20221116200150.4657-5-linux.amoon@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEwyOWxCbzNNbE0zNUNvNUFBKzlsMm12b0taTC90dGdMNkY2YzZoSGV3Qk1n?=
 =?utf-8?B?TFQ0ZkxvTnl6V1ZoSFBIQ25XTlFhamNrekFuMFk5elVWQVV1SkRqNFlhdTVS?=
 =?utf-8?B?MUQ0cVRUZUR3Q2lVQjlLMHg1ZXJzcDlKK0pvb2dxYlZJMCtna0pSRnlqMkZY?=
 =?utf-8?B?S3A0VU5PYlo2czBPdGtaNzRHRGNSQ1h2VGp1Tk9STG83aEp0SVFiclBsNEhj?=
 =?utf-8?B?SlF0VnY3NUpVcWV6emRlSGhsUVpRSWgraFFES2VMa3JJcVZjRmtidmQ2YXhD?=
 =?utf-8?B?RUV6dXExTmZQdWttWEVLeCtxY1pJZFJ6bi9aSGZtN2MxRStoMGtPSEpMUHVx?=
 =?utf-8?B?U1NIWjZFZUZjOFpWOFV3SGxFZlFIUGJhbUVSdFVPdHkzMVZhM2JIWG1MbVla?=
 =?utf-8?B?RHUvdGtVTFduRkZOeXhoTkRjVU5iU1NGa3o1VmR5Sjh1Sy85bTJUNWJXR3Zm?=
 =?utf-8?B?UEw5QnQ0U011OXFEWlpmTWxmWlM0WDlqaHp3blE0S1lhUnlqL2Q1ajFkOGlU?=
 =?utf-8?B?VmtRMU1ESTJQdTRKekpPYmhwV1ZjS1NpYzdxc1ZzV2NNM2o3NUluMlFWQzg4?=
 =?utf-8?B?bDBseHpYY2pxbGxObVJBNXFJaW1DUnE0UzJGcTREaWNsWnhSWEtqNjR3b0d0?=
 =?utf-8?B?QU56bXExb2hyQWI4Qm9vZGFHZEx2RWxZOFRQV25DSUNUNktmQ2FXUVFnTXNl?=
 =?utf-8?B?TWpTZzdXM2ErWmoxaHc0VEdyR1RGR1pJNi8wbnBCMzNNQWYrdUV2VVROTnNr?=
 =?utf-8?B?djVXZEhSb1pSV0ZnWG4wSndFZ0ZwVzFnWFZGM0hhTmNaWFlFZE84VW5ObUVH?=
 =?utf-8?B?Qi9yNEFDWG9teHc4VHNyR0Rsc1R0NmFvbDBZZGtCYmhGMnhiekNBODVZRjUz?=
 =?utf-8?B?WnNBdTNhckVzY3F0RWFQR0ZDTkRBaElCbmxrUEpHYkxIRkNRYTVWcHZ6ZFZy?=
 =?utf-8?B?ZDFmYUU0TEJHMUtUQy93REJ6cFdSNGlGUlZQazYrdE9EYnpod3ZWemg0Sm45?=
 =?utf-8?B?YTZXM2Q1dVVqS203Rk9CL2lqbWx0TUY2Um4xaVdKWmdOK2NlZk9MOUp0NzZT?=
 =?utf-8?B?Q2pYdmdPc29wWFlET0FMYk9iSDRJaHF3d0RWTWkxSEV1clBGbUI2bllESWZh?=
 =?utf-8?B?NUwwNWtObThtTTUxQzdKd1JIdnNNWUp4enJScXcxd21mUy9CVHA0RzNFUzBO?=
 =?utf-8?B?T29ZeHRxTEFoanhnQ3BRRm9SSkt6SExvM2Nwd2RibXk3Y3ZPSnJCZzlVZ0N1?=
 =?utf-8?B?QUQxVUpIbzUrcEZZSnVtNThLUHNaeStmb1AxWm5sNmxVOUN0b3ZuTEpVdEp3?=
 =?utf-8?B?MXhBRm9zWlg5S2czYllUVlFXaU52TkorVnJFWEVBYURheVg2V2VOTFEzbFkr?=
 =?utf-8?B?WmVLZWRwcGM0SFFWVis0RDMzajZQNnJ4M2g5bmNLZlV5TDhjQXI5TkdTYWQw?=
 =?utf-8?B?SjF3NWlGUmhXcEs5enNuSXJmdEtka1FPaWtveStoc0lPMG1tYWcvQ3pGZkl0?=
 =?utf-8?B?bFN0ck1KeTFhV0E4VVZKWUJlTjZYN1dZTnNzZUJNd01WVXBOS1JQUlJPajVI?=
 =?utf-8?B?d1pDQUZmZE9nWUdKbWFDemEzSWFybk5vcUFZK1hLQTBncDBHK0RiVVRMdldk?=
 =?utf-8?B?Yll0LzZOcllPWTNOZ3VTcTVvQy91MU56SWN3VUw1YUNsOTZNYUhrU1VqU2Q0?=
 =?utf-8?B?dndEUGdtSmdsZTI4emZIMTJBQkR3cGo3VFlHNTVhaFh1c2R1a2xuTkdqWmVa?=
 =?utf-8?B?SEFXa2JwdjFNMEtHV2ZabjdSOGJBRytLdGwvdElnb1BpN2RIVEo1VzQ5ditx?=
 =?utf-8?B?bURJWVJiV2VZV2hhdHJJRXhxSWNHTEJnS3pybllTa2pOdHdIeEZKSXF2UUFu?=
 =?utf-8?B?TnY3M0p2eWtnUGFwRnlWalJNdU5yTE01SWVlK3R0MkRUdGpNdUlWVGxERi80?=
 =?utf-8?B?R1p2Z2d6UzEyZUNvMmhTRngyWWVMRW52eTVycW1zeVpsWHZ4Z3NraG03SzZl?=
 =?utf-8?B?T004UUNjd0QwZkNQRmZvSlpvUy9HMnpNWHBtVUFxajgyK1FNWXZyOHQxQlpV?=
 =?utf-8?B?NGVPQm5vRE9uZnNUTnVqMmF5UlJyMkNOcWxEb1VacVNScmdwMDRGbitqbzZS?=
 =?utf-8?B?cURsRHpYVzFPblNoQnpIaHNkWE04SzQ2bk5OL1I2MmVmS090SUt4RWlOc2kx?=
 =?utf-8?B?OHNZeVVlUGhSL3dRdXgvZ0UveU8zQmxveHdvaDBoNlhyYlIwWWNNcExKeHZm?=
 =?utf-8?B?NGRPRmViNlFmM1FscXdzcGRZZERnPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 75470a20-fe04-49e7-a63d-08dacca4124b
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 16:10:28.1416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xe9DeEc1JkYwUjLJ1FAzZucsCsWbTOBAAUL2g7XI4r3zr02h7TSx40zvkKeOUIKxf1Yzm8x0JaXcdYjGK2XyuRYi2IU4t4+i9fltZ4NtmMU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7647
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Anand,

On 11/16/22 21:01, Anand Moon wrote:
> As per the shematic gmac1 support gpio interrupt controller 

Typo "shematic" -> "schematic"

> GMAC1_INT/PMEB_GPIO3_A7 add the support for this.

Maybe split the commit message into two proper sentences.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v2: new patch added
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index 5378254c57ca..9f84a23a8789 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -588,10 +588,14 @@ rgmii_phy1: ethernet-phy@0 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
>  		reg = <0x0>;
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&eth_phy_rst>;
> +		pinctrl-0 = <&eth_phy_rst>, <&eth_phy_int>;
>  		reset-assert-us = <20000>;
>  		reset-deassert-us = <100000>;
>  		reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
> +		interrupt-parent = <&gpio3>;
> +		/* GMAC1_INT/PMEB_GPIO3_A7 */

This comment is pretty superfluous.

> +		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> +		#interrupt-cells = <1>;

I am not an expert here, but I believe #interrupt-cells = <1>; means
that the phy provides an array of interrupts. Are you sure this is
correct? I find it strange that the phy driver consumes one interrupt
and provides N interrupts?!

>  	};
>  };
>  
> @@ -630,6 +634,10 @@ vcc_mipi_en: vcc_mipi_en {
>  	};
>  
>  	ethernet {
> +		eth_phy_int: eth-phy-int {
> +			rockchip,pins = <3 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>;

Interrupt is active low and you pull down the line here? There is a pull
up resistor on sheet 11 of the schematic, so this does not seem right at
all.

Best regards,
Michael

> +		};
> +
>  		eth_phy_rst: eth_phy_rst {
>  			rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
>  		};