Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 17:22:59 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Akihiko Odaki <akihiko.odaki@daynix.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Yan Vugenfirer" <yan@daynix.com>,
        Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH v2] igbvf: Regard vf reset nack as success
Message-ID: <Y3z3Y5kpz2EgN3uq@boxer>
References: <20221122152630.76190-1-akihiko.odaki@daynix.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221122152630.76190-1-akihiko.odaki@daynix.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4oM1GobknaNr+7bO0rHMpsGZmE87ajlh54HZ9jI2a9qoSplF4+rt/pez5B79?=
 =?us-ascii?Q?irFIKvcfmpDw0BCKL0j40FATCdjR9NkTgFUVJkwsbd037fmzGlcUUeUPt/3o?=
 =?us-ascii?Q?4mSzFs2mXi3Re8wNhlIpVxIUQRILP52BsDeGugCJpNg2N8+8m9Dx29O/R8PE?=
 =?us-ascii?Q?VFDLFHSMmXRcp3uabf1VXQhRitAECMt4cKLTTYgNMjCEEzCj+me6ORJl/RzQ?=
 =?us-ascii?Q?x3S1s6vEdkh9GQWEOPoqez8uhxvTHE+vb8tWOWBVNHNNeCOgNU8HAlcOu9mD?=
 =?us-ascii?Q?1M2ZXPttHXhqTZdP38DsoYcA6yOdUc3nc3C8afWFj5FUh3cI7cs3HsTVgPmE?=
 =?us-ascii?Q?ww+lzCbfY1GXgwL5nDsxFGdkw5TfVkKwqvOluZCLUdgz+HN5coboMIgXs2jn?=
 =?us-ascii?Q?CLgvxqnp/+Bwdb1gnK/rwppMqqNsvMyweiTQwFiCTS7q4hYVRPyj6bQmNSKw?=
 =?us-ascii?Q?whC+EReWulaVxyZqz1xKX9QBJQoIjfl8mes+D0vFEYUtbU7s6VH/CG4LCWOF?=
 =?us-ascii?Q?Rx9RYUycRUCqwHjbYpDZYEGty96OLgAB8ebkF/1B/6L2rfQwcKDqOMO4mqiA?=
 =?us-ascii?Q?ssDcdoeMkJNbL3YrfnondyjmXQwevMTPiPPCfS7U8OmfbmUrpwP82lQuiPjt?=
 =?us-ascii?Q?s3D5wnGHuq9cVMthEVyP5XJAMPeLUV32B30nLwG6Hi0v248whGPnL+rrjcRQ?=
 =?us-ascii?Q?ai4CzDEX4+ionUWrwG3MEH6ym0+0OV1n/4eiSBOXs+2C/5JT+Y9zRkJ8XCvU?=
 =?us-ascii?Q?idLiCBVE8naouX0ebkh+wfJJCBghsnwnD6EfOodRHLgL90LvHQkaMcd2OgJh?=
 =?us-ascii?Q?x4gHBTji1v/IMqoJj8SDz+PtiuqXdKC31co+LZcYhonlfnNDEqr3efC3BAzo?=
 =?us-ascii?Q?3kYXUzRuzj1ukNdaWBqo9OXFg7sHHKS9gZbuwEEyXhbqRCalKbBp4xhDXjBI?=
 =?us-ascii?Q?+lcsvBkAu3unmNxH8V/q0dZeMNjPd0b7lvcVPW+Yh20OZ2AO0jD6jEjf7MSc?=
 =?us-ascii?Q?GtRYfK0vhBJH7HxeFOODEnhcpf66Pne+ODkGfvy/ZfDgd9tzgysev7A0n2/9?=
 =?us-ascii?Q?NHAPLXzNVFGyJqHSThN1OQzrfJ78tPF35O9Dw8WgFjB3oRMfYWIBJ2NTikfL?=
 =?us-ascii?Q?crQVtLd+bYCasUxAOz+6393Q616l7yj53OpL+8StOsXSo1VQ8eReZmBbqsyR?=
 =?us-ascii?Q?QKhL6DakYvB401dbtYVLbGTVz3Bxd1x7n07Lf1mlROn6ceiRoSG4Pt6w91JS?=
 =?us-ascii?Q?nE0RZ/KAx25MfdN/bZImNU8KzFTiquXaxNkAUDVKdxNmtri7ryn7MxqB/cZC?=
 =?us-ascii?Q?s4t0QKo5fe661Y7S9BsR7hFw9b64sHKo9ZjGzAk5vzC6qPKGXbpjRBxansN3?=
 =?us-ascii?Q?dHKRWRW2kJihIl86es1eK5Iz35pKb9ogNZih2oMGscb267jBaGek7iYz4uFZ?=
 =?us-ascii?Q?OCouHIMfpGDrxkL8ezcL1pVRPnNFFqsvPwnf9ltdoK6UCTg2S24tJNW0SBzE?=
 =?us-ascii?Q?HC48eX8FM5w+utjdqjjhx4/RAef4LhQ/Ht62JUAML60IUTev4upnO4Gf4cZb?=
 =?us-ascii?Q?cg3nixdja3oHoCNTh+103VZ72aIz3k9vIW1xlA+07MsUVkeMX8LUP+hltbNf?=
 =?us-ascii?Q?Yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 28bbf54e-954b-4dca-c859-08dacca5d948
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 16:23:11.4848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gt5NXtA4NK+C6fcB8L8FTYJ8/41vj3aomAnLZXVJ1nmkFUKfxk+MY/vnmprhc2wgIM0zs2j/KAqoetw3oAlLk1rkg9OrB/qwuTz4Bb/sFoc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5068
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 12:26:30AM +0900, Akihiko Odaki wrote:
> vf reset nack actually represents the reset operation itself is
> performed but no address is assigned. Therefore, e1000_reset_hw_vf
> should fill the "perm_addr" with the zero address and return success on
> such an occasion. This prevents its callers in netdev.c from saying PF
> still resetting, and instead allows them to correctly report that no
> address is assigned.

What's the v1->v2 diff?
Probably route to net and add fixes tag?

> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  drivers/net/ethernet/intel/igbvf/vf.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igbvf/vf.c b/drivers/net/ethernet/intel/igbvf/vf.c
> index b8ba3f94c363..2691ae2a8002 100644
> --- a/drivers/net/ethernet/intel/igbvf/vf.c
> +++ b/drivers/net/ethernet/intel/igbvf/vf.c
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /* Copyright(c) 2009 - 2018 Intel Corporation. */
>  
> +#include <linux/etherdevice.h>
> +
>  #include "vf.h"
>  
>  static s32 e1000_check_for_link_vf(struct e1000_hw *hw);
> @@ -131,11 +133,18 @@ static s32 e1000_reset_hw_vf(struct e1000_hw *hw)
>  		/* set our "perm_addr" based on info provided by PF */
>  		ret_val = mbx->ops.read_posted(hw, msgbuf, 3);
>  		if (!ret_val) {
> -			if (msgbuf[0] == (E1000_VF_RESET |
> -					  E1000_VT_MSGTYPE_ACK))
> +			switch (msgbuf[0]) {
> +			case E1000_VF_RESET | E1000_VT_MSGTYPE_ACK:
>  				memcpy(hw->mac.perm_addr, addr, ETH_ALEN);
> -			else
> +				break;
> +
> +			case E1000_VF_RESET | E1000_VT_MSGTYPE_NACK:
> +				eth_zero_addr(hw->mac.perm_addr);
> +				break;
> +
> +			default:
>  				ret_val = -E1000_ERR_MAC_INIT;
> +			}
>  		}
>  	}
>  
> -- 
> 2.38.1
>