Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f0c87d9-cff5-3bc8-07e2-7022a190cc86@wolfvision.net>
Date:   Tue, 22 Nov 2022 17:46:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [linux-next-v2 5/5] arm64: dts: rockchip: Add missing of
 ethernet-phy-id to reset the phy on Rock 3A SBC
Content-Language: en-US
To:     Anand Moon <linux.amoon@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Chukun Pan <amadeus@jmu.edu.cn>, Peter Geis <pgwipeout@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221116200150.4657-1-linux.amoon@gmail.com>
 <20221116200150.4657-7-linux.amoon@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20221116200150.4657-7-linux.amoon@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWdvSHljSUQ4anFQODlYUUhPaWFqTGU4YzMyS2c4QnE1UXRER0YzOGY5SFVY?=
 =?utf-8?B?dTg4OHpDZWtMUmIrT1U3UHBSZzk5KzZiTTB6SWYwY2dyV1JHdjBFeTVNT0pQ?=
 =?utf-8?B?TE43VFFwV05XdFhnTitvM2xtZnQwczFZUTBWc1U4LzRDL2piN1RmSGlSa2JZ?=
 =?utf-8?B?UldRVEdvZE84RkNQb3ZOd0lQK2VGRUlwTHZKejJrRzA1L0R6cGJhM2IxZm4v?=
 =?utf-8?B?d3c1OUt4cmhNRjduZUluYUNMN1lhVXhtbHdBcU00ZmQ2R0FtZm9DbFEyS1JZ?=
 =?utf-8?B?YnpCbldXZTNyUTM5RkNQZXZqTEcvODN0WWRKN3lKaTVqK0pJNVNXK1B0eXdL?=
 =?utf-8?B?aW1sQVM4Qm42dENDVTlEWEwxMlRIY0dqalA4a1REb296NHhUUkRPMjRVUVhU?=
 =?utf-8?B?U1RRdVpnNGEzaDNtekVFcU5ENWlYbm1CeWhmb016bkdFOERhRWUyTjJCRGc3?=
 =?utf-8?B?VHZVbVZvU3hYaC9FQ3NFc0NQbGRkVmNMQ1I2WGNnRXdCVVpjNEFKRGlSb2d6?=
 =?utf-8?B?dHd3Zk5lL3VFMWlIS1BOaDBWanBaMUpqQmIrRmczK215ZktMbEVNajBBWStJ?=
 =?utf-8?B?MVEwYnQ3VS9rMWVzamdhY3hiVTVQaG5OSHZIUEEzTVJGcXZ6cmJHSzBYS1Ru?=
 =?utf-8?B?Rzh5YWtmbmhGYVlDM1d4QmRvTDZNYjBnS2pJOG1zMnBWZnNZdWxrdHlCdURV?=
 =?utf-8?B?QW5rWGp2YzJrL2tCMlUvekZTMk11TFVkOE93YUJrc1BLQTFLOE1ubnJoZkRr?=
 =?utf-8?B?VWs4UGZ1WW9zMDZPdWxPeXNBU1M0QXk4YklPSXJlZFhFTW1PNEF6VHBrR0to?=
 =?utf-8?B?bm9pa09ocEk0eHgxdEhhTWJGaTVKdW80QmRFa1lTVzJSM1F5Z3N0REV5ZEI0?=
 =?utf-8?B?bE96bEc1U3FVT1oydmpucmlUNEgyemhvYzhYUDBGOVpxek0vUEJlenRPM2dU?=
 =?utf-8?B?SkVrL0Q4aUxRZGE3bTFDbmdkMU1jTC9kdTFKT2grd3d1dUFnVndXM2ZqQ25u?=
 =?utf-8?B?SUJHNitFR2NRZkJzWGdGZW9qK0ZsRVVWQmdIMUJRU1c0SFNZMHd5YktMNko2?=
 =?utf-8?B?WHhxa2k5amNTVkw3ZVJCaW53S2NoaFozQWFrQlFQMVJZOEFvSHpQZzZuQWVF?=
 =?utf-8?B?OUZQMXYzdE12K1BmaTVvTFF2a3pGVWRtM25UdGlFWkJSaW9oL2trUUtROERl?=
 =?utf-8?B?Z3dNazZLRGZpcFZKSW90NlhabTlyMkQyWDhRMEZpZnQ1OFVtMmswcVZiNEdt?=
 =?utf-8?B?Z0pyc0NidmN5cElsSjRQbVVaYzNkRURUd3ZxdGpIc1VBVGl1MGo3MGVyWkdQ?=
 =?utf-8?B?cGphU245c2hoeEJJQVdpcTVORXRLb0VvRitXTlBpSjBGS2xWV3FmZDd5Kytz?=
 =?utf-8?B?NVRHeXBKUnJGSTZ6RC9iNUNlOFJ5RitVdDlGTm1wRmRod3NSQW9CUklmRENj?=
 =?utf-8?B?dU9NUktsOFBBOHlyb0hkMWNkTC8yclRDRWNLSEZlQU5BUUhPV1FaUWV6dVAr?=
 =?utf-8?B?dGxHMEV4YjZZSUMxUmdaTmxRQ0JQSVNBT0hyemJNcnR0WHNnL0ZxaXhIWXJn?=
 =?utf-8?B?UDVROFJDa0xBR280aXRKNlFMMXFNbFl2d1YrS3N3WERXZGpua0pLK3Y3MDNV?=
 =?utf-8?B?Vk1iZSswYVYvS0xhTi9rbkVKaGQrSVcxYkF0ckxOM3RmTEpkdHhqekp5eVpB?=
 =?utf-8?B?WnRSYVloMEdtYVVWeFNZMm5kL29zVmZBdklBS01nYUxsYVl4ZUQ2ZWZLN0Yv?=
 =?utf-8?B?TlVESWMyY3h6bGxieWI3cGNhQXNBUW5ubGpqZFExbzZhU2c4Y1l3cWs4M24y?=
 =?utf-8?B?TG5VU21nb3U4WnlPQmpEMjhOM0k1Z2FGSTc0WEZOZ2ZPK0N4VEprVmdmL0hF?=
 =?utf-8?B?dlVXdU1GUmF6d2VCNFRCVUlFQktNdFZNcUZtR3dOMDdJZksySWUrSS9JU2Ny?=
 =?utf-8?B?eVoxb3ExdENOQWtHK1IveFUrQkhSMTdyVmZ0VlRHV1I2RkcvOHpuWDljcnlj?=
 =?utf-8?B?am81cGZvVUNTa1B4MytnVFl6WG9POVhTWTZUT2RMb2VyNFNxRmc2MlpjcUFQ?=
 =?utf-8?B?S1VjalVkelBqaUp6OThqWmdTWjNIc3dRQmNVU2tLeEtrbHQ5WEE2NGJHVG1Y?=
 =?utf-8?B?Uzgzd0dxS1Z4RkRGK2czNWhEVWhxU0xONCtEejlnUmxmNFp6Ym0rMEJnaGRW?=
 =?utf-8?B?eVdkalg3ZzJsSW1jajBoeWVxU3V1U0NST3RsZGdEeElxM2VUZmx1R1JLR092?=
 =?utf-8?B?d1RmWm1UTElBZE9ablBUQjF6Z1FnPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fbddf52-a960-4733-a893-08dacca91b40
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 16:46:30.6357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F6fCOSn4Y+29fUnPCiitTo88LLSOR56Yuk/qzc9JvZtMEXTOCQRCUCHhQzs674KmNXYXW9o1jTnhd+Nk+XLGtqXkl+P8PBDZsFzE+woK0eU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5780
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Anand,

On 11/16/22 21:01, Anand Moon wrote:
> Add MDIO description with ethernet-phy-id compatible string
> which enable calling reset of the phy. The PHY will then be probed,
> independent of if it can be found on the bus or not,
> and that probing will enable the GPIO.
> 
> ethernet-phy-id is read from ethenet register dump reg2 and reg3.
> 
> Fix following warning.
> [   12.323417] rk_gmac-dwmac fe010000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
> [   12.324078] rk_gmac-dwmac fe010000.ethernet eth0: no phy at addr -1
> [   12.324099] rk_gmac-dwmac fe010000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)

Without this patch, the phy on my ROCK3A is properly detected:

[    1.494963] rk_gmac-dwmac fe010000.ethernet eth0: PHY [stmmac-0:00]
driver [RTL8211F Gigabit Ethernet)

but with the patch applied, only a generic phy is recognized:

[    1.398674] rk_gmac-dwmac fe010000.ethernet eth0: PHY [stmmac-0:00]
driver [Generic PHY] (irq=POLL)

This does not seem right at all. NACK to this patch!

Best regards,
Michael

> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> V2: new to the patch series.
> 
> alarm@rock-3a:~$ sudo ethtool -d eth0
> [sudo] password for alarm:
> ST GMAC Registers
> GMAC Registers
> Reg0  0x08072203
> Reg1  0x00000000
> Reg2  0x00000404
> Reg3  0x00000000
> Reg4  0x00000002
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index 9f84a23a8789..fe36156a5017 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -585,7 +585,7 @@ &i2s2_2ch {
>  
>  &mdio1 {
>  	rgmii_phy1: ethernet-phy@0 {
> -		compatible = "ethernet-phy-ieee802.3-c22";
> +		compatible = "ethernet-phy-id0000.0404", "ethernet-phy-ieee802.3-c22";
>  		reg = <0x0>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&eth_phy_rst>, <&eth_phy_int>;