Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e83b6f9a-9144-130e-aebb-17529d3d4d64@foss.st.com>
Date:   Tue, 22 Nov 2022 17:42:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] clk: st: Fix memory leak in st_of_quadfs_setup()
Content-Language: en-US
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <windhl@126.com>, <avolmat@me.com>
CC:     <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221122133614.184910-1-xiujianfeng@huawei.com>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
In-Reply-To: <20221122133614.184910-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Xiu

On 11/22/22 14:36, Xiu Jianfeng wrote:
> If st_clk_register_quadfs_pll() fails, @lock should be freed before goto
> @err_exit, otherwise will cause meory leak issue, fix it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
>  drivers/clk/st/clkgen-fsyn.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
> index d820292a381d..40df1db102a7 100644
> --- a/drivers/clk/st/clkgen-fsyn.c
> +++ b/drivers/clk/st/clkgen-fsyn.c
> @@ -1020,9 +1020,10 @@ static void __init st_of_quadfs_setup(struct device_node *np,
>  
>  	clk = st_clk_register_quadfs_pll(pll_name, clk_parent_name, datac->data,
>  			reg, lock);
> -	if (IS_ERR(clk))
> +	if (IS_ERR(clk)) {
> +		kfree(lock);
>  		goto err_exit;
> -	else
> +	} else
>  		pr_debug("%s: parent %s rate %u\n",
>  			__clk_get_name(clk),
>  			__clk_get_name(clk_get_parent(clk)),

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice