Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 16:27:47 +0000
In-Reply-To: <CAHk-=wgR=vJnkkUS=x26=meF=i0x_9q9ytSd+DZGaFP8uoGJsg@mail.gmail.com>
Mime-Version: 1.0
References: <5f52de70-975-e94f-f141-543765736181@google.com>
 <c4b8485b-1f26-1a5f-bdf-c6c22611f610@google.com> <20221121165938.oid3pemsfkaeq3ws@google.com>
 <CAHk-=wgR=vJnkkUS=x26=meF=i0x_9q9ytSd+DZGaFP8uoGJsg@mail.gmail.com>
Message-ID: <20221122162747.opnte2csfr5hors2@google.com>
Subject: Re: [PATCH 0/3] mm,thp,rmap: rework the use of subpages_mapcount
From:   Shakeel Butt <shakeelb@google.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>, Peter Xu <peterx@redhat.com>,
        Yang Shi <shy828301@gmail.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Mina Almasry <almasrymina@google.com>,
        James Houghton <jthoughton@google.com>,
        "Zach O'Keefe" <zokeefe@google.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 21, 2022 at 09:16:58AM -0800, Linus Torvalds wrote:
> On Mon, Nov 21, 2022 at 8:59 AM Shakeel Butt <shakeelb@google.com> wrote:
> >
> > Is there a plan to remove lock_page_memcg() altogether which I missed? =
I
> > am planning to make lock_page_memcg() a nop for cgroup-v2 (as it shows
> > up in the perf profile on exit path)
>=20
> Yay. It seems I'm not the only one hating it.
>=20
> > but if we are removing it then I should just wait.
>=20
> Well, I think Johannes was saying that at least the case I disliked
> (the rmap removal from the page table tear-down - I strongly suspect
> it's the one you're seeing on your perf profile too)

Yes indeed that is the one.

-   99.89%     0.00%  fork-large-mmap  [kernel.kallsyms]  [k] entry_SYSCALL=
_64_after_hw=E2=97=86
     entry_SYSCALL_64_after_hwframe                              =20
   - do_syscall_64                                               =20
      - 48.94% __x64_sys_exit_group                              =20
           do_group_exit                                         =20
         - do_exit                                               =20
            - 48.94% exit_mm                                     =20
                 mmput                                           =20
               - __mmput                                         =20
                  - exit_mmap                                    =20
                     - 48.61% unmap_vmas                         =20
                        - 48.61% unmap_single_vma                =20
                           - unmap_page_range                    =20
                              - 48.60% zap_p4d_range             =20
                                 - 44.66% zap_pte_range          =20
                                    + 12.61% tlb_flush_mmu       =20
                                    - 9.38% page_remove_rmap     =20
                                         2.50% lock_page_memcg   =20
                                         2.37% unlock_page_memcg =20
                                         0.61% PageHuge          =20
                                      4.80% vm_normal_page       =20
                                      2.56% __tlb_remove_page_size
                                      0.85% lock_page_memcg      =20
                                      0.53% PageHuge             =20
                                   2.22% __tlb_remove_page_size  =20
                                   0.93% vm_normal_page          =20
                                   0.72% page_remove_rmap

> can be removed
> entirely as long as it's done under the page table lock (which my
> final version of the rmap delaying still was).
>=20
> See
>=20
>     https://lore.kernel.org/all/Y2llcRiDLHc2kg%2FN@cmpxchg.org/
>=20
> for his preliminary patch.
>=20
> That said, if you have some patch to make it a no-op for _other_
> reasons, and could be done away with _entirely_ (not just for rmap),
> then that would be even better.

I am actually looking at deprecating the whole "move charge"
funcitonality of cgroup-v1 i.e. the underlying reason lock_page_memcg
exists. That already does not work for couple of cases like partially
mapped THP and madv_free'd pages. Though that deprecation process would
take some time. In the meantime I was looking at if we can make these
functions nop for cgroup-v2.

thanks,
Shakeel