Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9aee9ea4-9644-3f77-4dea-11784868c885@oracle.com>
Date:   Tue, 22 Nov 2022 10:55:03 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com,
        linfeilong@huawei.com
References: <20221122181105.4123935-1-haowenchao@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20221122181105.4123935-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dlUkdlQU4rVDNEVDZFbEhzaFJZeU5ac2hkYmh3QzhuZzJ0NnVhZE9KSVJ3?=
 =?utf-8?B?Yy9FUjE2NFpkN2JzUGdKQ2k3K2o0anNMRHFlRnVXeC82MGpTSnZnUE1pc2xL?=
 =?utf-8?B?N2ZkUEVZUVQyVWlDMWh2dXh1bndvTnJuaWw1OFRkSzNFSWhQT1pxbUo5dENn?=
 =?utf-8?B?Qm5NT28zdStDMTVWNkFtTjdrN1hWUnFmTFZaeEphM2pna3Qwc3RudWpXb3Np?=
 =?utf-8?B?cllXenpIMDVGOG0rS2lOR1JwWi9VdFlaOUFtVWFWTWtINjc4YjROcHF1bU9m?=
 =?utf-8?B?dDBScWZlbW9wVWFtaUsxbjZnWTVaaytnQVZLT1FHaElUa25pejNWNDlzOWFm?=
 =?utf-8?B?eHh6M1NZV0tMSzdXQnZqT0RTbCs4S0R0amxQSmdJMmd1eml5WkUxRDVwVFp2?=
 =?utf-8?B?VXc1cDZURi9BaGJPRlJkbEpDYmlkaFpaRk01UkJSc0xyTGFuT1JQc3crYi8r?=
 =?utf-8?B?S2I0ZzdKSUVPWWYrK3lxNGhCU1FjVVdqclpFdXpIdVd2dWZ5bzZNMjBRZEN1?=
 =?utf-8?B?ZlZNYWxjOXB6Nmhic0FoOTdNdm9EdGxSMVZiNkxVYkwySEkvMlA0TkpjS2lJ?=
 =?utf-8?B?bU5idytGREhxN1ZWdGY0c2xwYmZrWGFNMkg5NHV6Qkg0dFcxYlBRY29jNnRm?=
 =?utf-8?B?WmZpQVpDcS9Ed1UrRUF2Z3N0N3RxYmRrTm9VN3lzeVNMRFZ2UktQNGdSUDl0?=
 =?utf-8?B?T2lwN21ReUNkaWhKRzRLU253MTErVUNhcmpMVVEzeU5LQXQrOEk1TU9DNGh5?=
 =?utf-8?B?cFh2aVdzQ2tVUCtXbFhMWTcvSG5GdUFqd1VSOWFuNGNWR3FRVnBnTGxFZWFH?=
 =?utf-8?B?MHczRkRBYzZQaGoxYUxuYS9EOE93MHhLZ0hlMG1qc0w3L3VuT1JuOXBDcFRo?=
 =?utf-8?B?K0lDZjFXaUJXNVpsOG5sY01ZbTlkUHBaQ0YvNTNVdTlFd1B2NXRyRFMyaVUv?=
 =?utf-8?B?RVhOcVMrUXJXM1laUVRmY3JlWVA2clJvVmZ4KzRxWm56aVhELzE4WUdHWHh2?=
 =?utf-8?B?SXNEUDBkaVRXb3BONFlvZ2ErRWxRQ2c0OTI1cmd1TDZ1L2hJOXJ2aFlKbHNl?=
 =?utf-8?B?TlBaOENFSTR3T25kYkNOd0lXeUdkL2NBTm5IYllaNGU5Y1RUZ3Q0S0NsQldv?=
 =?utf-8?B?MnltZnA4M3lCbEFSSkM3OExMemhOMVR4MDlQYTJEUGRkS3BaSE02eTRXaGZa?=
 =?utf-8?B?VDdFUkVKaUJqcnM1dHVLWkZHaHhiZWN1YWI3V2dLbk9EcXpPMmltTk1DRnpt?=
 =?utf-8?B?WEVxY2lha29UWkxOUHJEL0lIcHRlSHdmSFVtd0FkbFM0RFBDV0d5NzBZTEdy?=
 =?utf-8?B?U1UyNytVMi9BcURtY09yQWQzRGdmbktzNzdRVXdEbUEwalU5V1JRRVUwV1Bh?=
 =?utf-8?B?c3JhVHViQnpoSkUzWHRFQmt0M2lnWjZwWG1jUlllZDFxRkc3RFR2U2hzNldO?=
 =?utf-8?B?UkUrUTlGMmNKQnRFQ2dDL2MxNGNNVDcxYnJFSkNuU29ZaElUME1HMDBjYnpQ?=
 =?utf-8?B?ZlI0NUpiZ2RtWng0TzZSWmJEQU1iVFV6Q2VVK20wcnJ5OEljYkFOUnlRVEZ2?=
 =?utf-8?B?anFLeHgrNThhSTNtWThLNnhDMHpxWkZWdnBTSG03Lzd5d1ExTW5teWN1Y0NF?=
 =?utf-8?B?UGF4cFFNYkhxblZBWkc3My9VbjB3QTBJNVcvNEJLT0VqZkVOS05mTGhJek9T?=
 =?utf-8?B?R1JIbzNsQ3oyWXd1UXg0RHQyVlB4cm9IMFdZMFpMUEVYR2l6eStEUHJaVHIv?=
 =?utf-8?B?T1I2V0FvR1EreXZISjg1ejA4cDZLQktadVBQdm9DNERXOWRESVpVTFFLOWtU?=
 =?utf-8?B?L0VJUHlwN0NidmwvUzZxWXZkd1ZaTmRmbndaQUFDV0UvNSs0UlY0L1c5RHlJ?=
 =?utf-8?B?UVBsR0gwenBadkRPVWZmM1ByRW5INEVLcVRZbGJMMGRVaXRKT3hlN3ZYempG?=
 =?utf-8?B?WExIeVZ5NEFZbXF3azFTMkdpSzFLY1NwVURxcDhJK2YyTDViazc4WFhiVHl3?=
 =?utf-8?B?NVpVb3lRMHVIRXlaeURJKytGaEJFcE5yY2lhMnJlaGZKSFR3SERhYmZ4RXdX?=
 =?utf-8?B?U3dOMzZXblY2NUI1WHdxbm16V0d4L21OZXlxK29sOThFSTZ3SFBrTGp5bUlS?=
 =?utf-8?B?K0J4bVAwanlBaHM1dmRqYkFTRXdXR3R0M0tSSGJmM3RjaVpFNHlpZmtZZlZB?=
 =?utf-8?B?VFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QTVpQ1hlNWdNbUxLTkRJbkp5UFUvbW1DWGtPQTFyY1g0NHFZU05lTmM0ekNv?=
 =?utf-8?B?MHFhb1JrWmVWb3IyR1c0S3JDUFAxQTZndzRnOXR3YjBac1J6ZGtPbFZrL1BG?=
 =?utf-8?B?THFCSjdxQ1FueE0rQkV1TkpYc0xDVUhxR0NINW40K3RBSDBIOVFnOFlPeHNZ?=
 =?utf-8?B?VTBabTNzTytSZU8yZUptWkppcUZIWWlaY0hIaFB6UU04M0JWVVVLdXNJSk9a?=
 =?utf-8?B?a2t2NU9sR09Rb3BMQVlzcUxGaUcwdnZFaGM2N1dyQmNXbEhhekl3bytiTmkr?=
 =?utf-8?B?ZThXODE0alZ5VTVGUjI4T1o4RVNOSE9kUm4wMlJ6Z1lVOUxMeEFCQzRESVIv?=
 =?utf-8?B?SmJyUEY0QjdXSmg0QitxQ21ISDRoUXdwbTNadGFqenBYQkFsdFZXM0crZXUz?=
 =?utf-8?B?L2M3b01pOWMvNXNJdzE2cU1OOC9jZzJJUFBUZlFZKzN5cG5mbWN5WGg0R2J1?=
 =?utf-8?B?RUFmZzZSbEcrWUp2bTZ1WldreTZHdUpUbHB4TDEyUmFGUGdPeVhOVytCS2w2?=
 =?utf-8?B?ZldFb25YSjVuMGp1V3FBc3o4bk1makRDMTg4S2VmTTJsOWs2SUNMK0pLa3Uw?=
 =?utf-8?B?ejZ5cWZOcmpLMVNjSjlHZ3J1ZHB6OFd2eTRHOFVOOE5PcFVabWlvUmo3VHpj?=
 =?utf-8?B?ZDBUWGNXRzZKcVFrMFF2aGxuSWd4Zi9lV0hFSlVZOTc1N0M0SWhvb05iTEZL?=
 =?utf-8?B?SVA2REpXYkdrYzFteVBWaFFFR2QwWWRNVFQyNGpIS3Z0TVVSVjVPalhlNHN3?=
 =?utf-8?B?My84aXJXUG1keUgzYVhkeDlJQ0c5cUVZYW9nSldFMTdNSklaSlhpanpvdGVC?=
 =?utf-8?B?cnpBSFBqdVByWGlzUGlYMHpvbWxsMGdWMEUvMnVHb0tqMkNCZDNlU24vQkpm?=
 =?utf-8?B?cFBZQnpwVDNTMDhoeURYS09UZllKRklJYUw3S0gwMXdxZHJNWUFDMmdVN1NH?=
 =?utf-8?B?VGRsQldjVG40WFQvcTFrNUszMVBRZERUbk1kaWc5TmRzaEtQd2k3YnZMc2xO?=
 =?utf-8?B?d3dUQkQxSXBtcDJLUERtU1VqQ1A1Z000L1IzeVV1MzVNZ2hncEZWQ3U3UHpH?=
 =?utf-8?B?L2lmMVNHNUlBUWF6cnhTUUpIS2tNQjBEUFBUMkN6YlpuNTdwVmpRQ0VqcVFX?=
 =?utf-8?B?WVNYUDlqNkpvdFgxdVJ3cFZIbzd1ajg0QmpUUUVFVTN0TmtWZUkwb0dRUWZT?=
 =?utf-8?B?TlVXR3d5Qm5ZcjZkVG0vQzkxVDJuVkI5WUQydkIzMk5GM0F3dWpTdWQwSnNk?=
 =?utf-8?B?WStvSEN2K1VYaDh3ZEthMWVVVDlXZmNreC9yQi90ZVhPTkFvNnBLMlJJamN3?=
 =?utf-8?B?ZlBqOU0yd3cwUG5NWUhvVVN3UVhZZGJ3a28zZGF3VW13ZGxqZURTR0gwVVdF?=
 =?utf-8?B?Vko3SXNiaWxqNUE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9acaaffd-fb96-49dc-e658-08daccaa4d90
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 16:55:04.5914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jX7gdVqhU7zDnoAxiqMVh7jU0PSpOSG9I+S0nfTbZ3HZG+fN0WrgEoyI0DDehm+VuK/CSfJ5vjuORg/yJpXUXGswLQOrZepx8cOj19fLakA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5202
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-22_11,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211220129
X-Proofpoint-GUID: f7cTDSkrwLnIbFilVLVkN-yWmB3SlJgh
X-Proofpoint-ORIG-GUID: f7cTDSkrwLnIbFilVLVkN-yWmB3SlJgh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/22 12:11 PM, Wenchao Hao wrote:
> There are two iscsi_set_param() functions individually defined
> in libiscsi.c and scsi_transport_iscsi.c which is confused.
> 
> So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index cd3db9684e52..c3fe5ecfee59 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -2988,7 +2988,7 @@ iscsi_if_destroy_conn(struct iscsi_transport *transport, struct iscsi_uevent *ev
>  }
>  
>  static int
> -iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
> +iscsi_if_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
>  {
>  	char *data = (char*)ev + sizeof(*ev);
>  	struct iscsi_cls_conn *conn;
> @@ -3941,7 +3941,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, uint32_t *group)
>  			err = -EINVAL;
>  		break;
>  	case ISCSI_UEVENT_SET_PARAM:
> -		err = iscsi_set_param(transport, ev);
> +		err = iscsi_if_set_param(transport, ev);
>  		break;
>  	case ISCSI_UEVENT_CREATE_CONN:
>  	case ISCSI_UEVENT_DESTROY_CONN:

Reviewed-by: Mike Christie <michael.christie@oracle.com>