Date: Fri, 10 Aug 2007 21:38:54 +0100
From: Alasdair G Kergon <agk@redhat.com>
To: Jan Blunck <jblunck@suse.de>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 05/11] dm-snap: remove SECTOR_SHIFT define
Message-ID: <20070810203854.GG2064@agk.fab.redhat.com>
Mail-Followup-To: Jan Blunck <jblunck@suse.de>, dm-devel@redhat.com,
	linux-kernel@vger.kernel.org
References: <20070810200204.455820246@suse.de>> <20070810200205.703776854@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070810200205.703776854@suse.de>
User-Agent: Mutt/1.4.1i
Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE.
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 874
Lines: 23

On Fri, Aug 10, 2007 at 10:02:09PM +0200, Jan Blunck wrote:
> Sector size on Linux is always 512 bytes. Don't even try to give the
> impression this is changeable.

If that's what worries you, add a comment next to the definition,
perhaps?

It's there so you can easily locate all the places within dm that
perform these conversions by using a simple search.  Searching for '9'
wouldn't be as easy.  (I don't know about other people, but I find the
code easier to read the way it is.)

BTW When changing one thing across the whole of dm, you may combine
the sub-component patches into a single patch.

Alasdair
-- 
agk@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/