Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e6ae7c01-47ca-f1da-3b0b-1f17d9e862bf@quicinc.com>
Date:   Tue, 22 Nov 2022 11:57:19 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Georgi Djakov <djakov@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     Odelu Kukatla <quic_okukatla@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221118182245.31035-1-quic_molvera@quicinc.com>
 <20221118182245.31035-2-quic_molvera@quicinc.com>
 <536af0d9-aa00-ddf1-753d-670ec2adef91@linaro.org>
 <3ada611b-96e0-5cf0-d79d-b90ca4202ddb@quicinc.com>
 <b7cc4f5d-c1d6-919c-9604-7855ea802d17@linaro.org>
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <b7cc4f5d-c1d6-919c-9604-7855ea802d17@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/22/2022 1:50 AM, Krzysztof Kozlowski wrote:
> On 21/11/2022 18:39, Melody Olvera wrote:
>>
>> On 11/20/2022 5:13 AM, Krzysztof Kozlowski wrote:
>>> On 18/11/2022 19:22, Melody Olvera wrote:
>>>> Add documentation for virtual rpmh devices. These interconnects
>>>> are not controlled by the application processor and thus
>>>> require separate bindings. Also, move compatibles for sm8450 to
>>>> this document and add them for QDU1000/QRU1000 platforms.
>>>>
>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>> ---
>>>>  .../bindings/interconnect/qcom,rpmh-virt.yaml | 55 +++++++++++++++++++
>>>>  .../bindings/interconnect/qcom,rpmh.yaml      |  2 -
>>>>  2 files changed, 55 insertions(+), 2 deletions(-)
>>>>  create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml
>>>> new file mode 100644
>>>> index 000000000000..5cbaa51df863
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml
>>>> @@ -0,0 +1,55 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/interconnect/qcom,rpmh-virt.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm RPMh Virtual Network-On-Chip Interconnect
>>>> +
>>>> +maintainers:
>>>> +  - Georgi Djakov <georgi.djakov@linaro.org>
>>>> +  - Odelu Kukatla <quic_okukatla@quicinc.com>
>>>> +
>>>> +description: |
>>>> +   RPMh interconnect providers support system bandwidth requirements through
>>>> +   RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
>>>> +   able to communicate with the BCM through the Resource State Coordinator (RSC)
>>>> +   associated with each execution environment. Provider nodes must point to at
>>>> +   least one RPMh device child node pertaining to their RSC and each provider
>>>> +   can map to multiple RPMh resources. Virtual interconnect providers are not
>>>> +   controlled by AP and do not support QoS; they should not have associated
>>>> +   register regions.
>>>> +
>>>> +allOf:
>>>> +  - $ref: qcom,rpmh-common.yaml#
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - qcom,qdu1000-clk-virt
>>>> +      - qcom,qdu1000-mc-virt
>>>> +      - qcom,sm8450-clk-virt
>>>> +      - qcom,sm8450-mc-virt
>>> You should also move qcom,sdx65-mc-virt, qcom,sc8280xp-mc-virt,
>>> qcom,sc8280xp-clk-virt and more.
>> Ok. I wasn't sure since some of these entries don't seem to conform to
>> these bindings, even though it seems they should.
> I have impression that devices I listed conform to these bindings, this
> is why I listed them. But if you are sure that they do not, then they
> should not be moved.

You're correct; those you listed do conform to the new bindings and should be moved.
I also caught qcom,sc7280-clk-virt which needs to be moved. I'll add to the new bindings.

Thanks,
Melody
>
> Best regards,
> Krzysztof
>