Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6269990rwb; Tue, 22 Nov 2022 10:57:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5mUroFYvvIww0/mxi7SukMQocf5+1blPaI5GwJS48yBI2e41eQHvOVZ5zKE5MJfltkKs4+ X-Received: by 2002:a17:90a:7004:b0:218:ab86:3acb with SMTP id f4-20020a17090a700400b00218ab863acbmr12864156pjk.195.1669143472750; Tue, 22 Nov 2022 10:57:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669143472; cv=none; d=google.com; s=arc-20160816; b=frbpxrrSpRGCcKmO9iXaFS0M9wTAGNiWxnj/n1bbEpVGs96NXhMaV4VC6IyZ9OCZvN Xno1CmC9KykDbjrtWEoAkft7oCXue286iiWaSTb1K/sclp6p59a4d9SWllsPwbCkeP9Q p9NNG3T0v/XrblrtqHAk6ROFqHG1Go7SAnUNfdfp+z4SNH7KdopTRCU6y5wyxwuGqjGu bN/sbsu+SoHZVC97rc6/gMRFLHXD3ecZB2wlxRSl0IGtWHN6uFkBG3D+z7QFdoWkYvqK CzJt/ciWN6UrW/m55lsalj7TU8fDlQylIppqNxDzFdJfX+eWz4aDrkhhSNYxcqjkGb6A qP3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+t8W6T1lrf9+uayooiCO5n+zQVmbouITKRgCjijH/7o=; b=H01Gbx+Y+ZoypokGbIIGaURNMDIA/bAlfjazUKeUyVkvO4MdSQSrsr71264EM1uJeU Qx7YJzG/mwXNEe0E9k69z8l1CgTCXsXiGWwxzkc9nHQ/7Y5kUvjfekLdAT2B26FMARzt miNdt1Wzst0gA+XqQT1Tfply+PY6V+nRkNMjt1OC0xvznBgi6huw+gbtD7kiLY3b7mOv JssYt/wY2hZ8VDKaAYZILemWop64Ts8YsZKVLh3Av7nntg1R1eTZwTOB39jdC6FdRS5+ iX1L9R+J79T1/DMdvY4r6GCaqnXVfgFXSPvELONj0Zx4v2fv11KbfPGtc0WoMUBnnVfK WiZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id om3-20020a17090b3a8300b00218b999150csi5939608pjb.142.2022.11.22.10.57.40; Tue, 22 Nov 2022 10:57:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234490AbiKVSeY (ORCPT + 90 others); Tue, 22 Nov 2022 13:34:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232869AbiKVSeX (ORCPT ); Tue, 22 Nov 2022 13:34:23 -0500 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CF17C6B5; Tue, 22 Nov 2022 10:34:22 -0800 (PST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 6C08C2800BBC5; Tue, 22 Nov 2022 19:34:20 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 5F64AA072B; Tue, 22 Nov 2022 19:34:20 +0100 (CET) Date: Tue, 22 Nov 2022 19:34:20 +0100 From: Lukas Wunner To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , Rodrigo Vivi , LKML , Linux ACPI , Linux PCI , Linux PM , Mika Westerberg Subject: Re: [PATCH v1 0/2] PCI: hotplug: Add checks to avoid doing hotplug on PCIe Upstream Ports Message-ID: <20221122183420.GA22578@wunner.de> References: <5623410.DvuYhMxLoT@kreacher> <20221122180603.GA205176@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122180603.GA205176@bhelgaas> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 12:06:03PM -0600, Bjorn Helgaas wrote: > On Mon, Nov 21, 2022 at 07:13:15PM +0100, Rafael J. Wysocki wrote: > > PCIe Upstream Ports are not hotplug-capable by definition, but it turns out > > that in some cases, if the system is configured in a particularly interesting > > way, the kernel may be made attempt to operate an Upstream Port as a hotplug > > one which causes functional issues to appear. > > > > The following 2 patches amend the code to prevent this behavior from occurring. > > Thanks, applied to pci/hotplug for v6.2. Lukas, I didn't presume to > convert your LGTM to Reviewed-by, but would be happy add it. I figured that having both a Suggested-by and a Reviewed-by might look odd, hence went with the more neutral LGTM. But I see it was ambiguous. Either way is fine for me. :) Thanks, Lukas