Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47aa31e2-b49e-739e-dcf8-b91d1becbb73@suse.com>
Date:   Tue, 22 Nov 2022 11:53:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
To:     Wenchao Hao <haowenchao@huawei.com>,
        Chris Leech <cleech@redhat.com>,
        Mike Christie <michael.christie@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com,
        linfeilong@huawei.com
References: <20221122181105.4123935-1-haowenchao@huawei.com>
Content-Language: en-US
From:   Lee Duncan <lduncan@suse.com>
In-Reply-To: <20221122181105.4123935-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWNVVnBRUmkrS0tlZ3Axa1dVU1RsQzRyb2lybzV4YkFUYVo2bFlGU0FnRXRn?=
 =?utf-8?B?UmwyNkgwMjJ5cW1JQzRjMkNUZ3NYQ1JaRzNZaCsySkROSGMvbmRDSHhNcm15?=
 =?utf-8?B?enR4VXhMWno2ZEUzV1B4SmFpQWNjSXlEQ1JwdFZFV0JuUi9scWRvVDNzRmFC?=
 =?utf-8?B?T3c5RkV3OGVHaWV2UXErYytZam9OZG1JZTNPS0NOUDBFZWlueTJYT0s0akFs?=
 =?utf-8?B?c3VtUXFYdVlDRXRPc1dWbHJPdFRzQzJFRmR4ZHlzOUlISnBWRUZTV2V5K0hG?=
 =?utf-8?B?RFp1WXczTVNuKytJMVpDZlQ2bnZheUsrcDZGNWVMTytnYnp4SUxSbGsvbC9O?=
 =?utf-8?B?YlcxVEtnZzlRWkU3OWIzdVpnNlVFS0hkUCszMklMWnRqbmEvMC9JQm5Way9R?=
 =?utf-8?B?YUZpeUFUTGlnNXRWdndrQWFxQWUyR1p6YWkrMSt2cHI4eU81bDZRdWIxYWM4?=
 =?utf-8?B?QTUwazZCYWdnN3lKY2d0R0lSODRRc015Q3VoRHFFQURtNG5ydVd1Vkppdi9m?=
 =?utf-8?B?NTV6MFFUcm10bEhEZ0wvQ3lFaWJLV3p0b3hXekxPRTcxenM1eVVhRkx1aDFs?=
 =?utf-8?B?cjJabDlYUTJnZ05COUtkQmlFSVgvL3VQNnVDbm15cjYraUFJSURwSnBKOExz?=
 =?utf-8?B?OHYrSXBvZlZOWFlKc2s0cW9pejRIR3hUU0Q3VU4xakV6V2YrVGJWSTBJNHo1?=
 =?utf-8?B?K2pVb3A2UWFReVhPbXptQyt2T3FKayszRjZ5aE5UbW5BdEZLck9SN3A0N3RR?=
 =?utf-8?B?eEtYd1M3TStRMkFIdTJqdjFYUXc5cVBaYWtmV3RSbGxMd1hMMlRVSEdlc2tv?=
 =?utf-8?B?U1F6NGJYc3dodUt2cVRDQzRBaC9tOStPM1kyeU1mTzFXaWQrUEFKb1FGMWxZ?=
 =?utf-8?B?dzJwZTM2K3RmRTU0c1lBZXlIaXhuTFA5K0krV3JLTXQ0Rk9JRjZpaS9HQjFO?=
 =?utf-8?B?ZDE0bTFVVUpzM2lmWVM0ejdMYnlZZnlRNWRDTUE1SHRKUGREWHdPWXQ4MkZ2?=
 =?utf-8?B?SEdZNjloQ3NCZ0dHL2Uzb1lmcnlTellCZEY2cmdZSFk2b2hvWlA4S3lWZmY5?=
 =?utf-8?B?cGFXM0RZWmQxbEF1dy9MNnBSd2FmczlXeS9iNU9wRmNzSGFINTVXUzVrQVM4?=
 =?utf-8?B?MVRxSTM1MDZ1bUlPcVFHVENhdFZFaDhlYktkbEo5bWQ0UExRWkZOSVdKd09y?=
 =?utf-8?B?VEd5eW9SU2hQNjRrY21aRjRQNzQvWWRVeXZNK24vaU42enVLUDBLUXk4ZkdK?=
 =?utf-8?B?YjBXY3V0OC9FTTM5Rk4yWTZHSXYwQjcyakNCTjd5NnZJWS96bkFjQzNXZm9u?=
 =?utf-8?B?S0xrS0dVU0YzbXFYUndxQUJCcTNzVzNOUXNTZG1KZUJIeGxEbFdVbiszSWc0?=
 =?utf-8?B?TytkNStuTzhCYzBXZjhBUVNiZUJJclFhUkdrNksyL0owZEoycFU4a25uMm5D?=
 =?utf-8?B?MHhXM0pNNjdFWDlJeUVHU09RcnlBbExucG1ZWmliS1B5Y0FnczhlQ0lnak8z?=
 =?utf-8?B?VTRtRktTeExjVGV2bmxRZHFtTzZROEQ0SmFLZUppWjhMRW1mcjhoRWY3S0dJ?=
 =?utf-8?B?cGFqS01Ob05yWmhHdGZ0c1ZWblU5bHVZR0x2bVVsNzMxR1J0RVRuQjJ5VllM?=
 =?utf-8?B?enlwdSswMytDNVFKVmNRWmdlRVdDbTBrWENHbTJBTW8xY1dGS2FkWlB3RFEz?=
 =?utf-8?B?U2Mvdi9XeVFDeXVwRlhKc2NMT2dqeC9DaVQ1MHRSVzlLV1VLWVIxQWVJeXkw?=
 =?utf-8?B?dncrV01GM21nd3JJdXFqaW9mTTRBODh4Z2xRSTIybGg5dnpiNkltOVJhamtG?=
 =?utf-8?B?UFlQdjN5cHNGU0tvRm8yQWZ3UWJ4UjE2Zlh6L1RWalNGa0VQMmpNdXZsZ0dv?=
 =?utf-8?B?WFpvT21samVlUTBpekxtWXZRaFl1bmVvWEh6b3UzMVQxS1RYR2c1MFMyd0sv?=
 =?utf-8?B?K28xZVhvSUpxSUdsTlVjZGQ2Z0xqSkU2RHcybGQrZlNoK3gvVWVrVDc5aFpq?=
 =?utf-8?B?VFdjZkNZVm9idGMvaGZTYS96WnhMYU1jbUE0aU5YUEFGZHVYNlg4eDhqVUc2?=
 =?utf-8?B?eFVoT0cyS0d5cm9haXFpWEtObG1BVWxITC94TitKZFZGM3Z4R3lqVUpyb1Z2?=
 =?utf-8?Q?OUdKQSLIO73Kxlzz3mPEx3L+q?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 287d825e-2783-4a9c-85a0-08daccc33163
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 19:53:14.7828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4zkOt6SIxhqJvpDdwCVE+fxVNr49eIAybn0nzL3lvk4TcUfC0GJ9ZCydPXq2Zzdw6jBrI7/hKGbhC/BnCioPpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8751
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/22 10:11, Wenchao Hao wrote:
> There are two iscsi_set_param() functions individually defined
> in libiscsi.c and scsi_transport_iscsi.c which is confused.
> 
> So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param().
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> ---
>   drivers/scsi/scsi_transport_iscsi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index cd3db9684e52..c3fe5ecfee59 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -2988,7 +2988,7 @@ iscsi_if_destroy_conn(struct iscsi_transport *transport, struct iscsi_uevent *ev
>   }
>   
>   static int
> -iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
> +iscsi_if_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev)
>   {
>   	char *data = (char*)ev + sizeof(*ev);
>   	struct iscsi_cls_conn *conn;
> @@ -3941,7 +3941,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, uint32_t *group)
>   			err = -EINVAL;
>   		break;
>   	case ISCSI_UEVENT_SET_PARAM:
> -		err = iscsi_set_param(transport, ev);
> +		err = iscsi_if_set_param(transport, ev);
>   		break;
>   	case ISCSI_UEVENT_CREATE_CONN:
>   	case ISCSI_UEVENT_DESTROY_CONN:

Reviewed-by: Lee Duncan <lduncan@suse.com>