Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Subject: RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
Date: Fri, 10 Aug 2007 14:19:29 -0700
Message-ID: <617E1C2C70743745A92448908E030B2A0224C777@scsmsx411.amr.corp.intel.com>
In-Reply-To: <46BCC1AF.5050204@redhat.com>
Thread-Topic: [PATCH 9/24] make atomic_read() behave consistently on ia64
Thread-Index: Acfbh9QJtlFN9VLxTKq1o0TFtVPa0QAC+19A
References: <20070809135107.GA15985@shell.boston.redhat.com> <617E1C2C70743745A92448908E030B2A02213B3C@scsmsx411.amr.corp.intel.com> <46BCC1AF.5050204@redhat.com>
From: "Luck, Tony" <tony.luck@intel.com>
To: "Chris Snook" <csnook@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
       <torvalds@linux-foundation.org>, <netdev@vger.kernel.org>,
       <akpm@linux-foundation.org>, <ak@suse.de>, <heiko.carstens@de.ibm.com>,
       <davem@davemloft.net>, <schwidefsky@de.ibm.com>, <wensong@linux-vs.org>,
       <horms@verge.net.au>, <wjiang@resilience.com>, <cfriesen@nortel.com>,
       <zlynx@acm.org>, <rpjday@mindspring.com>, <jesper.juhl@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 640
Lines: 14

> That's distressing.  I'm about to resubmit with a volatile cast in 
> atomic_set as well, since people expect that behavior and I've been 
> shown a legitimate case where it could matter.  Does the assembly look 
> right with that cast in atomic_set() as well?

No.  With the casts to volatile in atomic_set and atomic64_set I
still see places where ld8 is changed to ld4 + sign-extend.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/