Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 22:05:09 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     patches@opensource.cirrus.com, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: leds-wm831x-status: init chip_pdata before access
Message-ID: <Y305hfVdhs9zwOi/@duo.ucw.cz>
References: <20221122204837.11611-1-skhan@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="FhXHQk6+4qe/wr65"
Content-Disposition: inline
In-Reply-To: <20221122204837.11611-1-skhan@linuxfoundation.org>
Precedence: bulk


--FhXHQk6+4qe/wr65
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> wm831x_status_probe() accesses status from chip_pdata before
> initializing it. Fix it.
>=20
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

Does it? ARRAY_SIZE() will be compile-time constant, no?

What is the bug? Did you test the code?

Best regards,
								Pavel


> +++ b/drivers/leds/leds-wm831x-status.c
> @@ -212,7 +212,7 @@ static int wm831x_status_probe(struct platform_device=
 *pdev)
>  	struct wm831x_status_pdata pdata;
>  	struct wm831x_status *drvdata;
>  	struct resource *res;
> -	int id =3D pdev->id % ARRAY_SIZE(chip_pdata->status);
> +	int id;
>  	int ret;
> =20
>  	res =3D platform_get_resource(pdev, IORESOURCE_REG, 0);
> @@ -229,9 +229,10 @@ static int wm831x_status_probe(struct platform_devic=
e *pdev)
>  	drvdata->wm831x =3D wm831x;
>  	drvdata->reg =3D res->start;
> =20
> -	if (dev_get_platdata(wm831x->dev))
> +	if (dev_get_platdata(wm831x->dev)) {
>  		chip_pdata =3D dev_get_platdata(wm831x->dev);
> -	else
> +		id =3D pdev->id % ARRAY_SIZE(chip_pdata->status);
> +	} else
>  		chip_pdata =3D NULL;
> =20
>  	memset(&pdata, 0, sizeof(pdata));

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--FhXHQk6+4qe/wr65
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY305hQAKCRAw5/Bqldv6
8vzcAKCF1Sez4V/92wP9hgxf2QbQ2Je2mgCgtnjWyFA3hXxYfD2gV32HBrCRHL8=
=ZoaS
-----END PGP SIGNATURE-----

--FhXHQk6+4qe/wr65--