Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 22:38:20 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bpf@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v3 6/7] net: lan966x: Add support for XDP_TX
Message-ID: <20221122213820.zf5iy6shjekpvzeu@soft-dev3-1>
References: <20221121212850.3212649-1-horatiu.vultur@microchip.com>
 <20221121212850.3212649-7-horatiu.vultur@microchip.com>
 <20221122165646.428674-1-alexandr.lobakin@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20221122165646.428674-1-alexandr.lobakin@intel.com>
Precedence: bulk

The 11/22/2022 17:56, Alexander Lobakin wrote:
> 
> From: Horatiu Vultur <horatiu.vultur@microchip.com>
> Date: Mon, 21 Nov 2022 22:28:49 +0100
> 
> > Extend lan966x XDP support with the action XDP_TX. In this case when the
> > received buffer needs to execute XDP_TX, the buffer will be moved to the
> > TX buffers. So a new RX buffer will be allocated.
> > When the TX finish with the frame, it would give back the buffer to the
> > page pool.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  .../ethernet/microchip/lan966x/lan966x_fdma.c | 78 +++++++++++++++++--
> >  .../ethernet/microchip/lan966x/lan966x_main.c |  4 +-
> >  .../ethernet/microchip/lan966x/lan966x_main.h |  8 ++
> >  .../ethernet/microchip/lan966x/lan966x_xdp.c  |  8 ++
> >  4 files changed, 90 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> > index f8287a6a86ed5..b14fdb8e15e22 100644
> > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> > @@ -411,12 +411,18 @@ static void lan966x_fdma_tx_clear_buf(struct lan966x *lan966x, int weight)
> >               dcb_buf->dev->stats.tx_bytes += dcb_buf->len;
> >
> >               dcb_buf->used = false;
> > -             dma_unmap_single(lan966x->dev,
> > -                              dcb_buf->dma_addr,
> > -                              dcb_buf->len,
> > -                              DMA_TO_DEVICE);
> > -             if (!dcb_buf->ptp)
> > -                     dev_kfree_skb_any(dcb_buf->skb);
> > +             if (dcb_buf->skb) {
> > +                     dma_unmap_single(lan966x->dev,
> > +                                      dcb_buf->dma_addr,
> > +                                      dcb_buf->len,
> > +                                      DMA_TO_DEVICE);
> > +
> > +                     if (!dcb_buf->ptp)
> > +                             dev_kfree_skb_any(dcb_buf->skb);
> 
> Damn, forgot to remind you you wanted to switch to
> napi_consume_skb() :s

Correct, I forgot to update this. Will do in the next series.

> 
> > +             }
> > +
> > +             if (dcb_buf->xdpf)
> > +                     xdp_return_frame_rx_napi(dcb_buf->xdpf);
> >
> >               clear = true;
> >       }
> 
> [...]
> 
> > --
> > 2.38.0
> 
> Thanks,
> Olek

-- 
/Horatiu