Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 23:01:20 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bpf@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <alexandr.lobakin@intel.com>,
        <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v4 4/7] net: lan966x: Update rxq memory model
Message-ID: <Y31GsPEhDOsCB70i@boxer>
References: <20221122214413.3446006-1-horatiu.vultur@microchip.com>
 <20221122214413.3446006-5-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221122214413.3446006-5-horatiu.vultur@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i54fQ0lPgg6sc5TjGX3nlqBsCBZeakgSsYAWrL1UZLGr7tMYzkJGgXGTcp9h?=
 =?us-ascii?Q?grvl819N5lXNSx1fu3gv8VSZPYqkxDt0/sYvkd/Rekc5C5wlXW5o6t8JfrH/?=
 =?us-ascii?Q?AgwtdlpkPFFPdLJrXsI6paMnEjQj24krfqqMbK/ofyK/hQx6KN/o5j8rhU1/?=
 =?us-ascii?Q?lq2zumEu5FUF7EEOcIYs8vj1edfFlYC2whvMwr4bWeE08o0QwhPSHV+whiPz?=
 =?us-ascii?Q?ZxMCqQVOfsgMuBUhLhmIElGteNJIDJZVUVbiDwWhVMDBnjqJqoFpq/Wvj//K?=
 =?us-ascii?Q?Dg6EzRuWRAZFKEvYG6Ub8tKsgL8gI4sSCSjiprQBQUH0fR9g87YvLaRAM0mY?=
 =?us-ascii?Q?qqMJQG/XNk860cIVrkLGs++CPQmvgZCUrP7hyNdixfMfPXhxqZW9TPmNCR+Q?=
 =?us-ascii?Q?/yJayU9QPor/XGGIAOn7LDX/gE2qprSLDrAdQf9jsqNwrpaNUDA2chdhTjBn?=
 =?us-ascii?Q?MviTxfsESYeYJBbHquIpYwhqaIceRWe8RCRjwe35NcS2r+wFcowVwS23ucB1?=
 =?us-ascii?Q?U0qyQEw8yVjjDL005/TC1Ww1JwA8ykEfV9WWB/DbHmrobYUC2AgRGRR8LyeW?=
 =?us-ascii?Q?0RQLKtqGFJZksyD30ZMuxHmn3p9Aew2uVn7dwgKesf5V5DIWTd4VE75xO9FG?=
 =?us-ascii?Q?uzgGELxrTj9IbTCtL4wd+4wjfBoPfz+GcLXCRKL854p2w3pH3HxRzAFgb79B?=
 =?us-ascii?Q?G0R+DEno6Y1dI/BSPfqIDRBbji6jr3cMQUvmV0v6S48oggyTLVwzlw0ZNU1r?=
 =?us-ascii?Q?HPHgr5cyrRCstfuSJOOLXG1GS00jwqhJfVSFIxNx3jnInIM1436Esj6SRBvi?=
 =?us-ascii?Q?e0z82ES+m3osK7BMvZgfpGjvx4MImwlMqG5n/zVsVAmJ2qyVqTEd2e28CH2a?=
 =?us-ascii?Q?w7e+FGhXVMpqgCOp91xI20n4YgU0DZjydM3jQ2SBLLTpRdsiQfXbaeMOOyK5?=
 =?us-ascii?Q?bGizMHzZlriA5EgJ6ARDmd/48tp/NbKH7OX7I/9tbqAV+yo+fbqIhPhWD+L2?=
 =?us-ascii?Q?v2ZfKsp1K+j6VoiR99vlI27TDxJwz4Wy15LbCG1fIXjaLZd8wUrEzpaFWVih?=
 =?us-ascii?Q?10IqkPzUQegRtRXT/W63o6VIAwgWGYTAfc1O+Dml9udFEXWeBLrw5z9Nj/38?=
 =?us-ascii?Q?o7gvS7q57yMV2xXzn7lPpT2DzqZtp7hg3Av8uZjl0Jw7G8qFOYDmpM7OkGo5?=
 =?us-ascii?Q?gdL8/JpwXH4zW0s6p8qAwCLwRN9BplEW6QvgQr/KBJ8iO21X/CRqqsgefzJO?=
 =?us-ascii?Q?lmT9UhAgV227e5t1oGAzf2wIQ7SeTSmXoKc1ekmKbL8UHeF+HEgnQ96MouSr?=
 =?us-ascii?Q?YztC5f3k3g2bdKH2GBvnrKFGsWXga5Gib62S4gNKNQrHV51IFM4BZf2PiZHD?=
 =?us-ascii?Q?4yJmOQv3Jz2IWpew/OHZ/Jbt+MsnEv1eutSDjg2AWm4FiBYLngtlizBeB3fx?=
 =?us-ascii?Q?Z3c0BHx/2dLDAcPYGjgvDnzZwrPjVbYmkhL1RqwnYHYgMG6P0TQ39SKUy5bL?=
 =?us-ascii?Q?Uaa9SPnZi5FhkE9Cs8bIp9gQuYl5ql6roF9xDMOC6DnFJCEs3D5TXnsd4JOw?=
 =?us-ascii?Q?fotl7SRawzmOvY5t3Rw6ZWRGIgJ0a0GBY5H2LxXmHrykDO2lbXldkJi3geAw?=
 =?us-ascii?Q?dQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ceea6a3f-40ee-40be-0053-08daccd51a82
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 22:01:27.2736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qAynuwvVkYJM8aWDc/95gZMFAiBLIueI3mWFo+rQMyjH37PUTa8On0fROuwh1wpKMkBc32iVRvECjFdMQY1v0NPjKuMhH0Jd2Fu8+xjO/MY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7188
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 22, 2022 at 10:44:10PM +0100, Horatiu Vultur wrote:
> By default the rxq memory model is MEM_TYPE_PAGE_SHARED but to be able
> to reuse pages on the TX side, when the XDP action XDP_TX it is required
> to update the memory model to PAGE_POOL.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  .../net/ethernet/microchip/lan966x/lan966x_fdma.c  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> index 384ed34197d58..483d1470c8362 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c
> @@ -78,8 +78,22 @@ static int lan966x_fdma_rx_alloc_page_pool(struct lan966x_rx *rx)
>  		.max_len = rx->max_mtu -
>  			   SKB_DATA_ALIGN(sizeof(struct skb_shared_info)),
>  	};
> +	struct lan966x_port *port;

port can be scoped only for the loop below?

> +	int i;
>  
>  	rx->page_pool = page_pool_create(&pp_params);
> +
> +	for (i = 0; i < lan966x->num_phys_ports; ++i) {

Quoting Alex from some other thread:

"Since we're on -std=gnu11 for a bunch of releases already, all new
loops are expected to go with the iterator declarations inside them."

TBH I wasn't aware of that personally :)

> +		if (!lan966x->ports[i])
> +			continue;
> +
> +		port = lan966x->ports[i];
> +
> +		xdp_rxq_info_unreg_mem_model(&port->xdp_rxq);
> +		xdp_rxq_info_reg_mem_model(&port->xdp_rxq, MEM_TYPE_PAGE_POOL,
> +					   rx->page_pool);
> +	}
> +
>  	return PTR_ERR_OR_ZERO(rx->page_pool);
>  }
>  
> -- 
> 2.38.0
>