Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 00:08:55 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     patches@opensource.cirrus.com, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: leds-wm831x-status: init chip_pdata before access
Message-ID: <Y31Wh3z/QU6NWZ68@duo.ucw.cz>
References: <20221122204837.11611-1-skhan@linuxfoundation.org>
 <Y305hfVdhs9zwOi/@duo.ucw.cz>
 <a77c38d1-1633-5421-6fab-6886b642fe66@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="x4sEWpz0m1JkPymp"
Content-Disposition: inline
In-Reply-To: <a77c38d1-1633-5421-6fab-6886b642fe66@linuxfoundation.org>
Precedence: bulk


--x4sEWpz0m1JkPymp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue 2022-11-22 15:39:35, Shuah Khan wrote:
> On 11/22/22 14:05, Pavel Machek wrote:
> > Hi!
> >=20
> > > wm831x_status_probe() accesses status from chip_pdata before
> > > initializing it. Fix it.
> > >=20
> > > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> >=20
> > Does it? ARRAY_SIZE() will be compile-time constant, no?
> >=20
> > What is the bug? Did you test the code?
> >=20
>=20
> Is ARRAY_SIZE() safe when accessing the status chip_pdata->status?
> I wasn't sure. If so, this change isn't necessary.

I think so. Feel free to quite C standard to prove me wrong :-).

Best regards,
								Pavel

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--x4sEWpz0m1JkPymp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY31WhwAKCRAw5/Bqldv6
8k76AJ9rMhV61HT+oU3PrDTjKlwjBHxh0ACghvisv1NhzFrW//h09qSKpeGsxY0=
=x3py
-----END PGP SIGNATURE-----

--x4sEWpz0m1JkPymp--