Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ecad0af-c801-1638-c658-6823e4ddf483@intel.com>
Date:   Tue, 22 Nov 2022 16:04:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v8 02/13] x86/resctrl: Add a new resource type
 RDT_RESOURCE_SMBA
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
References: <166759188265.3281208.11769277079826754455.stgit@bmoger-ubuntu>
 <166759200326.3281208.5387897092180999498.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166759200326.3281208.5387897092180999498.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmxVTjg5dktTVzg2bFc0cm1DWmlMaXRQRlNMMnZLZUFPN3E5WG1FOThjMXBM?=
 =?utf-8?B?S2hwSUtTZ0t2eFNyRWpta3RkZURaWm5OajY2Myt4NHBSRmZ1QmoyZ2h5YzA5?=
 =?utf-8?B?ZFR2dHlNNmRGdytDQWlaTTJwbTNRT1YrVUwxMTJlVXNVMjBhMExHK3A4ZURh?=
 =?utf-8?B?TzhxY1cwdFNTU3g0TnBkbDI0bUpVTllOTlBIcXhaRmVkTEJ0SkdiMlg2R0Fw?=
 =?utf-8?B?TlhpVm9abjF4YUs0Mk5qcU9vby9wQWp5SXRpZklnYTlTUHl5ZHdXdVY1NmZz?=
 =?utf-8?B?Q1E3SUNIa2NXdnNBQUpKZWJ0YXlTSWU3Wm9QeHN3eEx6Mm9Nb2lwc3ZUL0dD?=
 =?utf-8?B?aVZ3RVcxNlY4MnNkNjl6K2cwVEtOVnNXUlRGdllRbmNrUkJGRVdDdjMvQThX?=
 =?utf-8?B?SVhubXNhaENlajVKMlJ6R1RSSFJiNnF0TFhpdHJHYlhVRW84TXVOL3VsYnF0?=
 =?utf-8?B?SlBaWWtTaUE3U0VQZitDbWoxc1hYR2JWN2ZmOWY5K3NVeENDMk1QUnZhQWM2?=
 =?utf-8?B?SkV0L1dlMExBZGQ3aHcrTmswbmhORGRIemRyeS9ITThsanBjcm9KVFNRRjkv?=
 =?utf-8?B?RS9hRFBJWWk0ZnNuUnhPb0VqWjN1cDBIQUJUay9JNlg4OXhadkhwTElMSmpa?=
 =?utf-8?B?TjNVdTRQNGpUSURidnFaeit2UE5jdEYxeER2MDQ2N2dMUHBGeU8xR1dNT2Fs?=
 =?utf-8?B?TWNvMHl1bEV3ajBUdy9iVENNdVF2MXF5RzdoRDBsTjVXQlpMSGowY0kvUGQ2?=
 =?utf-8?B?Zjh0dTZ4RXVIdGhHdlpCMmk1YUpDZnZHVkRIQjdZVUo0ZGVOMWUxQ3ZrYUV4?=
 =?utf-8?B?RGRLVmNJdldkNFFlNElacVhWbkk2MjFVOHIyNVpuSWNHdjV6S0s2VCtXNllD?=
 =?utf-8?B?NzNTUDkyTzEybUo4MEljei9tTy9wOENaRVg1VjY2aVc1cmROUTA4ejdJMDcz?=
 =?utf-8?B?aUdIaGlmM0Y3SUd2dHlrRnV2YW1CWnFYNWU5NGc1QUxHU1lqb21zMTBRM3Er?=
 =?utf-8?B?R2RGYkkxMzFuVVA2UEROczRiM3hsV2k0dlJQZkc5b3ZsY1kvL01xNEdNaFlQ?=
 =?utf-8?B?RGdLNEpxYklOYURHb051bU1WK2l2QnZ4MXpQUUZyajJwSWh2b1dsWmpFdTR5?=
 =?utf-8?B?eWE2UGo3OUlOZTJyckhuUXJsYk5MRGNFMzZLR1JhU3oySnh6KzBUbWxHTm1W?=
 =?utf-8?B?cVRCS09nUTlGZG0vWnY2bXIweG1EbU9EWGtUdTh6c3AvVng4UWNpZGJkNnpm?=
 =?utf-8?B?b0tvUktiSENYdGNOQlRXWW9ENTdicDlYWStJc1Y2K0crWjcvUHNaNnlDTTFU?=
 =?utf-8?B?cC9qMkNDYzN1Zi9wQW1wVEtLMTNIV05UcXBHRVBkQkIxTjNvMW5aTmNzRGxZ?=
 =?utf-8?B?d1JXUUMvVnV5N3NyRGFIZmorQnlEdlVyTzV2N00zbGZkMGVDTHlDdmVQampq?=
 =?utf-8?B?Y0IvQjNCKzVrblo5Y1VHNkt2VlU3NjVDaFRuc05nRjhZT2p3QlRoV05EaWZx?=
 =?utf-8?B?WXU4K091bjY2SlhqUnZxYjJaUHBiNWNTNzVmZDg5ZVU1MGN0MnVQRXdnaUpS?=
 =?utf-8?B?dHp1YklUQXJvemxIbEE4Nm8wRVEyRytabk0wanltSjMyeDhKU01GQUxuWWpP?=
 =?utf-8?B?b3JhTzBzc3J4MVBLeThHSjZraDVsYnlWY01CRk5zV0xoQU5jeTljcmxjY3BL?=
 =?utf-8?B?RjBWRmZVZmp3SFpKbzE0bHpVRkU3RDR2N2VSMXBiMnlsb2paR1dlUUVrNUd6?=
 =?utf-8?B?Z2M3MDR5SUV1WXpEbDBVLzFkMWpRaUpTZVBnNkROUTNOS0pCNjdDcWtZUHpO?=
 =?utf-8?B?c0Qyd0RvbTNMbDh1RXZ1ZmswM2lDdlRQZXJUS0QxZGdySEpGR2p0QVh4dHMy?=
 =?utf-8?B?TnlrQnR1UkJoSEVvcllOcStwbUlramUzTDNBdW04aFQ0anQ2NXFxTHRIaDZj?=
 =?utf-8?B?aVI3Um1IVnMwWHJzdlBxb0FNaUdCL1RDT3ZyMWZzaE9CQkpjTWppOVN0d1d3?=
 =?utf-8?B?bVp2NEtBSk05dmVkQXZJWDdHN0lVOXVSMUZ3VkxkSTl5UklrRVgvMkp6L3Jk?=
 =?utf-8?B?TnI1NUtvSFBHTEk4RlkzT2FmdEpyNTNGeEE5RTN2OEZBOUd1eVI2R3MvUVE1?=
 =?utf-8?B?RTVaY2x2aERHL29uK0E0TnU3TEZZQXZEVktkVmE1S0dFMStTeUl1V3JuZThL?=
 =?utf-8?B?RHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c3be4fbb-57f6-42c4-9b41-08dacce6528f
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 00:04:44.0251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nb22WvODuPwAwc2HgNHXaYsfGXcBhzn8dvZwyB+itti8Bs2OJur9VgK5Cy9qjYdQKSKprQgbHta2TR2wtizDh57rMXAA0fexl0NhOHhHHDg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 11/4/2022 1:00 PM, Babu Moger wrote:
> Add a new resource type RDT_RESOURCE_SMBA to handle the QoS
> enforcement policies on the external slow memory.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
> ---
>  arch/x86/kernel/cpu/resctrl/core.c     |   12 ++++++++++++
>  arch/x86/kernel/cpu/resctrl/internal.h |    1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 03cfbf0fe000..4b970e7192e8 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -100,6 +100,18 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  			.fflags			= RFTYPE_RES_MB,
>  		},
>  	},
> +	[RDT_RESOURCE_SMBA] =
> +	{
> +		.r_resctrl = {
> +			.rid			= RDT_RESOURCE_SMBA,
> +			.name			= "SMBA",
> +			.cache_level		= 3,
> +			.domains		= domain_init(RDT_RESOURCE_SMBA),
> +			.parse_ctrlval		= parse_bw,
> +			.format_str		= "%d=%*u",
> +			.fflags			= RFTYPE_RES_MB,
> +		},
> +	},
>  };
>  

Looking ahead at patch #5, I think that the initialization of
msr_base and msr_update (in rdt_init_res_defs_amd()) can be moved
here also.

>  /*
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 5f7128686cfd..43d9f6f5a931 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -419,6 +419,7 @@ enum resctrl_res_level {
>  	RDT_RESOURCE_L3,
>  	RDT_RESOURCE_L2,
>  	RDT_RESOURCE_MBA,
> +	RDT_RESOURCE_SMBA,
>  
>  	/* Must be the last */
>  	RDT_NUM_RESOURCES,
> 
> 

Reinette