Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d757b376-3e36-da95-b69c-21390a0c92f5@intel.com>
Date:   Tue, 22 Nov 2022 16:26:05 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v8 13/13] Documentation/x86: Update resctrl.rst for new
 features
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
References: <166759188265.3281208.11769277079826754455.stgit@bmoger-ubuntu>
 <166759208987.3281208.3199784740546752454.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166759208987.3281208.3199784740546752454.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJJNEFrekg5ZzF6dWlhZ0RpVVVWNXVIQUY4TjJIOXI4bmY5emNOZW4zT2w5?=
 =?utf-8?B?VWtlRTVBTi8wVmsxbUZITGphRmwvSVRWQ0E1L3JqNTFYNXJrRW1GYmZ2Z0Nx?=
 =?utf-8?B?YTBTVkFoQjdBVk4wbzZXcEdyckQ0MEZYdVNpNEZqdG5GMFRaQWZOeC84MC9Y?=
 =?utf-8?B?aXcrSE03Qkg0b0dxSUxhNkpBWGVSUEpTNlBzMUhIRWJ6TDdVNUNqTmVjdElY?=
 =?utf-8?B?cWFDT2YrUmttQ2l1LzIybU1oaE5KbHRLTm9QZG95c3JIWksvZks1QmtDTTRF?=
 =?utf-8?B?Nkd5V3dGSHBGUlBNV1l2Z1JRdVhlRmNkS0NFeXUxSjQvZGh0VkxuYTZLQmF6?=
 =?utf-8?B?TXU1bGdsWTd2bll0MGpTWG5yb1ViaDQzRFZRMStEcEIyaWRVRkJnajFwbnpT?=
 =?utf-8?B?ZnQrSHV6Y2FkS0YrNjhpNGRoZ1pMK05nZ2tPelNwcTZ6aWh1dFE3UE9QZE5J?=
 =?utf-8?B?Q2xvZHFoL0NLdjV6ZnMrTnpXUXp0ei9tZUVqTG4wME5oMjQwMkFjd1NlL1ZR?=
 =?utf-8?B?NkZYd0VNMStBMmYwTlQ2R00xUm03MmZTYUR2K2w2NlNhK2ozQlp2S2UvaGRq?=
 =?utf-8?B?NUUzSlNqV3dhcnBnZUNmcnRWOG1IR2hRdmduZ1Vxa1BSU1dnTlBTNnJmWm8v?=
 =?utf-8?B?ZzYxVy8yc2FUVVpuVkhTcUE2eEM4ZURCSDZPZHNHOTl0b0lJR2Fkc09XMk1m?=
 =?utf-8?B?VFBsWmRPdGhPNGNjU054ZTJyOEJKZmxCU3dlbjBOZXJSSEtCR2Y4ZUVubXJG?=
 =?utf-8?B?OEczYllrNmZ0N2ZFVlhYT2lrRGJsZ0JQQkJYV2JDNHZjR2M1eTVGTWF1dmYr?=
 =?utf-8?B?N1lyTjd5dVlId2JFRGpXZllMQ214QUpvQ1RvZ3prSEhDMWx0T1JxMW1KUllT?=
 =?utf-8?B?M3pISW1VOEk2bEYwVGIyWGV6Zi8zS0M4RTZwYjVlVzBVZFZoREwvd2s1elVa?=
 =?utf-8?B?b1BPeE0vZkFxbWpaT0tmMlQyUjI5TkNZRDQwVnJkbXowY0RzQTJ5bW02eW1D?=
 =?utf-8?B?WGdzZFJCK3o4U1kvVTY0eEpOTUtVeWRIckQ5VGIvVXZabG1kT3VHbHVqenNH?=
 =?utf-8?B?RmIvMkdIM25ybXE4RU11ZWwvdHllVFRKRkNmaTJmdkJMbEVhcHhIUER5Ym1u?=
 =?utf-8?B?QXkvdTU3Z1hicU9UYzZuL2dKZUNSOVQvSThsTXU1Q2FRNElZNmpwdVl6a1o5?=
 =?utf-8?B?YnlneXNxdHZ6SzYxVVJ5WlZLN01nQWo3QjV2TUpnSVo2TExLVWJNTnhwdCtL?=
 =?utf-8?B?R3FmYUZUV0JjcU1HRjh0RFc2MDV2ejJQRXI0dEZCU0RFY2Rrc211NjFKQXBD?=
 =?utf-8?B?UFpKN1daQ2FXNjdjREY1dHZlNXZsMGJsZ3hXanlqcVE0OWxrVER1OEVhbE5m?=
 =?utf-8?B?WWs0OGIvRzA0S2NGdDNNd09DLy8xQVcrcHZrM25TeGw2QVVEalgzUXUySnVL?=
 =?utf-8?B?RDZua0t6dXVPcTFvT3FONFE0TmpIMEpzQjFiclk1SE1JT0MxZzIveTduRUo1?=
 =?utf-8?B?MEFWWk03aW03QXZCM2lvOXE0U1E4WDhVcDFOcXNtdG5aN2hOdFJCMFpLT0hv?=
 =?utf-8?B?NFIzczdtUHpEMmVvUzNsVko4V2FxbEU0VzRSSDJscHlta2JGVnhJNTd1V3FW?=
 =?utf-8?B?V1BtQk1LWGxVaGt0VGdFYmptK1lCWnlDZFJhbm1lVm13THRPc2tyWFhrWVI5?=
 =?utf-8?B?anBrUHQva2wvT2ZJVkdqWk5mQWllNFlyZzNCRVdtUExWWlZUNnBNQ1VEREVa?=
 =?utf-8?B?eXdienhEZDlQdlhmdUVLdGhDM24zaS81T3FQWlYwUlYzbFNtckFQYnNwR3k0?=
 =?utf-8?B?ZVo3NUlxRXJGdDdubGFBeHlNZWNXQ3NCbXlpb3JHa243c002RjFEYWxDcFlw?=
 =?utf-8?B?eTQzUFhVRFNjUGNoYzBzTkxZMCtGU1RzbUZ3c2RxKzlraWZoYXZkRTMwT1gz?=
 =?utf-8?B?MlRISmRxclhVbXNkSTV0STNPa1k4UlFwVElQSVBPMVpubC9jUms2OGY1ajJM?=
 =?utf-8?B?RWVMbWs2TWxpYWp0S3luNWdUZHBaRGFweUxKeFJmSjA0dWRJWHU2WVNkVlh4?=
 =?utf-8?B?UkZUSWtZUlVpQnRFd0hBUUVPUnFaRUs2VThRZ3VqV1ZjMWNXdUczSW1GeFJW?=
 =?utf-8?B?N1hDcHFCT0RpZktSc0RxOHVwK0c3L2lkMng2YUU5WnZRd2lqb2JLVGduRXNi?=
 =?utf-8?B?WkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cf56bbb-2bb3-437c-df02-08dacce951b0
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 00:26:09.8369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UpaULOeZevV2gR1OG6noPQNqIM9/y615aVuuo1HhPoRaNtSt1SWffo+ciCHkYdUdxRPy9UrKlFXT66tLeOVv94zvbXT1Tury0xR15lnBh0g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7356
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 11/4/2022 1:01 PM, Babu Moger wrote:
...

> @@ -464,6 +539,26 @@ Memory bandwidth domain is L3 cache.
>  
>  	MB:<cache_id0>=bw_MBps0;<cache_id1>=bw_MBps1;...
>  
> +Slow Memory Bandwidth Allocation (SMBA)
> +---------------------------------------
> +AMD hardware support Slow Memory Bandwidth Allocation (SMBA) feature.

How about
AMD hardware supports the Slow Memory Bandwidth Allocation (SMBA) feature.
or
AMD hardware supports Slow Memory Bandwidth Allocation (SMBA).

> +Currently, CXL.memory is the only supported "slow" memory device.

What does "Currently" mean here? If there is a plan for changes, could
that be shared? Otherwise maybe just remove it: "CXL.memory is the only
supported "slow" memory device."

> +With the support of SMBA, the hardware enables bandwidth allocation
> +on the slow memory devices. If there are multiple such devices in the
> +system, the throttling logic groups all the slow sources together
> +and applies the limit on them as a whole.
> +
> +The presence of SMBA (with CXL.memory) is independent of slow memory
> +devices presence. If there is no such devices on the system, then

Maybe "is no such device" or "are no such devices"?

> +setting the configuring SMBA will have no impact on the performance

"setting the configuring SMBA" is hard to parse. How about just
"configuring SMBA"?


Reinette