Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 16:22:58 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Josh Poimboeuf <jpoimboe@kernel.org>, sfr@canb.auug.org.au,
        linux-kernel@vger.kernel.org
Subject: Re: objtool warning for next-20221118
Message-ID: <20221123002258.GR4001@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1>
 <Y3thrQxfcvZSXFlr@hirez.programming.kicks-ass.net>
 <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1>
 <20221122051605.4hcbslwxez2trdvt@treble>
 <Y3yJxQJ9DwxTx7km@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y3yJxQJ9DwxTx7km@hirez.programming.kicks-ass.net>
Precedence: bulk

On Tue, Nov 22, 2022 at 09:35:17AM +0100, Peter Zijlstra wrote:
> On Mon, Nov 21, 2022 at 09:16:05PM -0800, Josh Poimboeuf wrote:
> 
> > It's complaining about an unreachable instruction after a call to
> > arch_cpu_idle_dead().  In this case objtool detects the fact
> > arch_cpu_idle_dead() doesn't return due to its call to the
> > non-CONFIG_SMP version of play_dead().  But GCC has no way of detecting
> > that because the caller is in another translation unit.
> > 
> > As far as I can tell, that function should never return.  Though it
> > seems to have some dubious semantics (see xen_pv_play_dead() for
> > example, which *does* seem to return?).  I'm thinking it would be an
> > improvement to enforce that noreturn behavior across all arches and
> > platforms, sprinkling __noreturn and BUG() on arch_cpu_idle_dead() and
> > maybe some of it callees, where needed.
> > 
> > Peter, what do you think?  I could attempt a patch.
> 
> I'm thinking the Xen case makes all this really rather difficult :/
> 
> While normally a CPU is brought up through a trampoline, Xen seems to
> have implemented it by simply returning from play_dead(), and afaict
> that is actually a valid way to go about doing it.
> 
> Perhaps the best way would be to stick a REACHABLE annotation in
> arch_cpu_idle_dead() or something?

When I apply this on -next, I still get the objtool complaint.
Is there something else I should also be doing?

							Thanx, Paul

> ---
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index c21b7347a26d..0354be027eb0 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -712,6 +712,7 @@ void arch_cpu_idle_enter(void)
>  void arch_cpu_idle_dead(void)
>  {
>  	play_dead();
> +	asm(ASM_REACHABLE);
>  }
>  
>  /*