Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122180905.737b6f52@gandalf.local.home> <CAAYs2=jdy7zrRDyTidUW1tFbKDLycLOZjSDt0_Ra7CbB6O1L2Q@mail.gmail.com>
 <20221122221711.402b360f@rorschach.local.home>
In-Reply-To: <20221122221711.402b360f@rorschach.local.home>
From:   Song Shuai <suagrfillet@gmail.com>
Date:   Wed, 23 Nov 2022 05:31:24 +0000
Message-ID: <CAAYs2=jHMLBApdU_VSaeh8ypi62T_dNCVSL0GKGRQgPhiRBQSg@mail.gmail.com>
Subject: Re: [PATCH] ftrace: Avoid needless updates of the ftrace function call
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Steven Rostedt <rostedt@goodmis.org> =E4=BA=8E2022=E5=B9=B411=E6=9C=8823=E6=
=97=A5=E5=91=A8=E4=B8=89 03:17=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, 23 Nov 2022 10:29:28 +0800
> Song Shuai <suagrfillet@gmail.com> wrote:
>
> > > @@ -2783,7 +2796,7 @@ void ftrace_modify_all_code(int command)
> > >          * traced.
> > >          */
> > >         if (update) {
> > > -               err =3D ftrace_update_ftrace_func(ftrace_ops_list_fun=
c);
> > > +               err =3D update_ftrace_func(ftrace_ops_list_func);
> > >                 if (FTRACE_WARN_ON(err))
> > >                         return;
> > >         }
> > > @@ -2799,7 +2812,7 @@ void ftrace_modify_all_code(int command)
> > >                 /* If irqs are disabled, we are in stop machine */
> > >                 if (!irqs_disabled())
> > >                         smp_call_function(ftrace_sync_ipi, NULL, 1);
> > > -               err =3D ftrace_update_ftrace_func(ftrace_trace_functi=
on);
> > > +               err =3D update_ftrace_func(ftrace_trace_function);
> > The helper function should only serve the ftrace_ops_list_func.
> >
> > And ftrace_trace_function is always different in this function with
> > FTRACE_UPDATE_TRACE_FUNC command.
> >
> > So this place should be left as it is.
>
> But it is needed to update the static variable. Without this change,
> then save_func will get set to ftrace_ops_list_func and never change
> after that and then the update to ftrace_ops_list_func will stop happenin=
g.
>
> -- Steve
Yes, you're right. Thx for your explanation.
-- Song