Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6957229rwb; Tue, 22 Nov 2022 23:20:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5sDO8E8zpfR/ClVr0LCe7GwyYo7FrrxTSgvn83q9BdgF/k2bvPr3kqjB5SyiuBHJ+W42Ga X-Received: by 2002:a17:902:8548:b0:186:8398:350 with SMTP id d8-20020a170902854800b0018683980350mr7680316plo.6.1669188042196; Tue, 22 Nov 2022 23:20:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669188042; cv=none; d=google.com; s=arc-20160816; b=TwBU5XEAdBATbwvF0q4TyMj7xs9F8nT/MBn32JWR7PCuFYNUefN7YG1OLUvQCOrqJ2 zVfT2jwhKc4I1ZEBGiFb4KRMrViCfPNm/gKCqAIMlTIFW2Iu1A/8fFr/6VNAgBtp2ILc rg5aEhgJQWmrjT2Nj9GVRXA/dyaAUv5wbs4/frkE7iepzIpKj0vsQd61JykY8CGcxabK YCJV9UHbU6UiinNNjhz7Ih/ZZRUi+ItbfYCLeo8ojB17CiVKgryRFe8A/sSeA1pkMfW5 HH5n61/CgPw5bjpfAFLmW9ild47c/pGVBNAPVvGvJU41XL6TNyLnsQGZOLc+hmcnAlQB sTwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=57379ispIxQ9mdLmC5U1VuSvVMcY3zHueAb21iEowB8=; b=np4GScFve2Hwhhu6L0ZoUJN18tBGKmR4p8TpwdsV5QM9BUqnW7zdr8k0Vqf/FfsaVq pkDODXvYSV/CdiVc6zbINK6L1uKTxIsg1kHEP4nsiBL3A75/PAFVNXK4mj/zoQkzPElu wNxuikvNwRSuJ97td++bARojInC7jYJwAIiohl7DwCVeSiVIXjltvrLtV7g56/gKmYdt epXGIFbyCatasYbGDqM32CxMd4jbxqhEKyJW/q1kromXY22ybXDtC1MQ9+4mCbnacSFd 5bE9KVpP3D/Eov5mVraLbzouFb19yGrJQjta2TcaMSFJp9+EpBahte39MQ6p9M6VR90q tMmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m3-20020a170902db0300b001872cd80411si17794098plx.193.2022.11.22.23.20.28; Tue, 22 Nov 2022 23:20:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235513AbiKWGJU (ORCPT + 89 others); Wed, 23 Nov 2022 01:09:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiKWGJS (ORCPT ); Wed, 23 Nov 2022 01:09:18 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83540F1F; Tue, 22 Nov 2022 22:09:17 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NH9fv2FgHzHtgm; Wed, 23 Nov 2022 14:08:39 +0800 (CST) Received: from [10.174.178.129] (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 14:09:15 +0800 Subject: Re: [PATCH v2 0/5] A few cleanup and bugfix patches for blk-iocost To: , , CC: , , References: <20221018121932.10792-1-shikemeng@huawei.com> From: Kemeng Shi Message-ID: <5ae7f0a0-8540-bbfe-2fe7-b18fc071ae1c@huawei.com> Date: Wed, 23 Nov 2022 14:09:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20221018121932.10792-1-shikemeng@huawei.com> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Friendly ping on 10/18/2022 8:19 PM, Kemeng Shi wrote: > This series contain a few patch to correct comment, correct trace of > vtime_rate and so on. More detail can be found in the respective > changelogs. > > --- > v2: > Thanks Tejun for review and comment! > Add Acked-by tag from Tejun. > Correct description in patch 3/5 and 4/5. > Drop "blk-iocost: Avoid to call current_hweight_max if iocg->inuse > == iocg->active" > Drop "blk-iocost: Remove redundant initialization of struct ioc_gq" > Drop "blk-iocost: Get ioc_now inside weight_updated" > --- > > Kemeng Shi (5): > blk-iocost: Fix typo in comment > blk-iocost: Reset vtime_base_rate in ioc_refresh_params > blk-iocost: Trace vtime_base_rate instead of vtime_rate > blk-iocost: Remove vrate member in struct ioc_now > blk-iocost: Correct comment in blk_iocost_init > > block/blk-iocost.c | 16 +++++++++------- > include/trace/events/iocost.h | 4 ++-- > 2 files changed, 11 insertions(+), 9 deletions(-) > -- Best wishes Kemeng Shi