Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 07:55:56 +0100
Message-ID: <87mt8i5fcz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Xiaolong Huang <butterflyhuangxx@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, baolin.wang@linux.alibaba.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] ALSA: rawmidi: fix infoleak in snd_rawmidi_ioctl_status_compat64
In-Reply-To: <20221123050911.1045190-1-butterflyhuangxx@gmail.com>
References: <20221123050911.1045190-1-butterflyhuangxx@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 23 Nov 2022 06:09:11 +0100,
Xiaolong Huang wrote:
> 
> The compat_status is declared off of the stack, so it needs to
> be zeroed out before copied back to userspace to prevent any
> unintentional data leakage.
> 
> Fixes: d9e5582c4bb2 ("ALSA: Avoid using timespec for struct snd_rawmidi_status")
> Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com>
> 
> ---
> 
> Reason for resend:
> 1. add Fixes line.
> ---
>  sound/core/rawmidi_compat.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/core/rawmidi_compat.c b/sound/core/rawmidi_compat.c
> index 68a93443583c..6afa68165b17 100644
> --- a/sound/core/rawmidi_compat.c
> +++ b/sound/core/rawmidi_compat.c
> @@ -80,6 +80,7 @@ static int snd_rawmidi_ioctl_status_compat64(struct snd_rawmidi_file *rfile,
>  	if (err < 0)
>  		return err;
>  
> +	memset(&compat_status, 0, sizeof(compat_status));
>  	compat_status = (struct compat_snd_rawmidi_status64) {
>  		.stream = status.stream,
>  		.tstamp_sec = status.tstamp_sec,

Here at the line just after your addition, compat_status is fully
initialized by substitution, so I believe the memset is superfluous.

Or have you verified that it really leaks the uninitialized memory?


thanks,

Takashi