Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 09:12:56 +0200
From:   Tony Lindgren <tony@atomide.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, b-liu@ti.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw
Message-ID: <Y33H+Pqf3QoN8/IM@atomide.com>
References: <1668416387-24984-1-git-send-email-ivo.g.dimitrov.75@gmail.com>
 <Y3z0nvoyiHQZ3MnY@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y3z0nvoyiHQZ3MnY@kroah.com>
Precedence: bulk

* Greg KH <gregkh@linuxfoundation.org> [221122 16:01]:
> On Mon, Nov 14, 2022 at 10:59:47AM +0200, Ivaylo Dimitrov wrote:
> > The check for musb->xceiv->set_power duplicates the check done in
> > usb_phy_set_power(). Moreover, not calling usb_phy_set_power() results in
> > current USB config max current not being propagated through usb_charger FW
> 
> What does "FW" mean here?
> 
> > 
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > ---
> >  drivers/usb/musb/musb_gadget.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> And is this a bugfix?  If so, what commit id does it fix?  Should it go
> to stable kernels?  What hardware was this tested on that this solved a
> problem for?
> 
> Please fix this and send a v2.

Ivaylo please also test with the musb phy changes in Linux next that might
affect this patch.

Regards,

Tony