Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7093200rwb; Wed, 23 Nov 2022 01:56:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf4gJJ21nmP4mIokaS/Bv6OygfDT4KUYJNIvN6ZWlgpwvt9GfMNcA2NtK+6K4vHkaQb7th6X X-Received: by 2002:a17:906:a156:b0:78d:9b8b:93cc with SMTP id bu22-20020a170906a15600b0078d9b8b93ccmr23638950ejb.529.1669197415478; Wed, 23 Nov 2022 01:56:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669197415; cv=none; d=google.com; s=arc-20160816; b=LolNvwinBqei1NcZVLHkiEfJcXe8Xi6T3BSlV7xdgjrSwEfwSBWDWUYopi6C0dgkrq F8YFQrT/qdiahcevT+HeglFrU+VVknYEYlRHvBLjC/H7YOncan8cdv2JOStX0OFxW7DK jvAdpLcDoCiJBFAl36sC6vAa5PcvRutSg9F7N2Ag8QHLQJSmcU8/Vo44jhPZElYf6roa IRCXnhPk1vYmmHMZeaeed5qGJDyE17VLEgJ3kvQr72U6Sx7s82/ns8Hetj5Q+dJp0RkL P6FajS9C659+cxc4pBAmbv9uEopS7216x/+hlYMcOZ+FN8b1TSOaqXEtNX1rMB3Njs5G nwPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:sender :hmm_source_type:hmm_attache_num:hmm_source_ip; bh=VHuxa1wCo9SLP/NDRCpXmBh+BgwjeiXLMwXR8ryauII=; b=JOcREVn0Xue9EvNkMxPdjnoybVsjLlAa27TqkVwW4iMlGdWgqip41eJPZmskYCSLVD L6/kNgpQLy7qp1ZpAT5dMkgs6/xOQ8dG+wYU5P3vPdPdQPldAtsWh+jULapVO/pCn2TN 1KDbKj/SKWsvbKoL6QiONbYBcaTZ0CVjcIoN/Yy+SIn0fDLKNVPOLOkrQF/LNqgRMQ/R lMRsv7/38Zfk9seFhcN2vjGqw9Ioo1IJtb/pIVUC7Zz4aslMvV1kDkNitAC7LWcGGd9d pr2jP6ZZS2zQy1vlGITbbzngwV1WXLd7Xsqh0P2NQVSM3LjaShKZUb/q3gUBGi8omwv3 D22Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a170906794900b0079ddb52369bsi3972220ejo.61.2022.11.23.01.56.32; Wed, 23 Nov 2022 01:56:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236409AbiKWH4f (ORCPT + 89 others); Wed, 23 Nov 2022 02:56:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236193AbiKWH4O (ORCPT ); Wed, 23 Nov 2022 02:56:14 -0500 Received: from 189.cn (ptr.189.cn [183.61.185.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9750A1AF; Tue, 22 Nov 2022 23:55:14 -0800 (PST) HMM_SOURCE_IP: 10.64.8.31:34556.651846289 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-123.150.8.42 (unknown [10.64.8.31]) by 189.cn (HERMES) with SMTP id C6443100302; Wed, 23 Nov 2022 15:55:11 +0800 (CST) Received: from ([123.150.8.42]) by gateway-153622-dep-6cffbd87dd-pzsb9 with ESMTP id a7ce1a020ff04a4085f415edf4631d51 for rostedt@goodmis.org; Wed, 23 Nov 2022 15:55:12 CST X-Transaction-ID: a7ce1a020ff04a4085f415edf4631d51 X-Real-From: chensong_2000@189.cn X-Receive-IP: 123.150.8.42 X-MEDUSA-Status: 0 Sender: chensong_2000@189.cn From: Song Chen To: rostedt@goodmis.org, mhiramat@kernel.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Song Chen Subject: [PATCH v2 0/2] reorganize trace_peobe_tmpl.h Date: Wed, 23 Nov 2022 16:01:38 +0800 Message-Id: <1669190498-2807-1-git-send-email-chensong_2000@189.cn> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, In the first patchset, my intension was to remove trace_probe_tmpl.h, just keep a unified process_fetch_insn and process_fetch_insn_bottom in trace_probe.c for all *probes. is_uprobe was the most important move to approach. If it was not accepted, the whole patchset couldn't stand. Then I change my goal to at least no warnings or errors when impelenting a new feature based on trace probe if it includes trace_probe_tmpl.h by provideing default behaviors. What's more, it also removes redundant code in kprobe and eprobe. Song Chen (2): kernel/trace: Introduce trace_probe_print_args and use it in *probes kernel/trace: Provide default impelentations defined in trace_probe_tmpl.h kernel/trace/trace_eprobe.c | 146 +----------------------------- kernel/trace/trace_events_synth.c | 7 +- kernel/trace/trace_kprobe.c | 106 +--------------------- kernel/trace/trace_probe.c | 27 ++++++ kernel/trace/trace_probe.h | 2 + kernel/trace/trace_probe_kernel.h | 140 ++++++++++++++++++++++++++-- kernel/trace/trace_probe_tmpl.h | 28 ------ kernel/trace/trace_uprobe.c | 2 +- 8 files changed, 171 insertions(+), 287 deletions(-) -- 2.25.1