Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7093890rwb; Wed, 23 Nov 2022 01:57:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4PafwYH4HavtXvbZLdFDpI3ENIG7g4CKiuDnAYC1YL70+tzWEkl6/7J1IT7P3qvmcVPD55 X-Received: by 2002:a17:907:2b15:b0:78d:51c0:d4d1 with SMTP id gc21-20020a1709072b1500b0078d51c0d4d1mr22688648ejc.161.1669197471776; Wed, 23 Nov 2022 01:57:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669197471; cv=none; d=google.com; s=arc-20160816; b=vKH/4bGuX5CxX4RWcSOwOA6cr8JstGkpszfmUe8btqnY6jdFQnnDtAPdur2xccp5nL xP+IGd5LYC9nUGnvhOH7/mzOkKUklZJWXlO+JNmnebPE4LyB68Fq2yiJBsHcYuhqdy8Q KCdIyAoX1ER3TowrO1DZhD4UzeM2h9ivuGHkXblzYGH109NRr7mFOZtLAhbqped6zrUA 2lqi7x2g/yccNufcH9MjZhwjOqBGELYxCwGeSmmgpyhBy2aOb6shTEuUju2BRBfTnhGM 2QZLW3qETxPJy7lApam9oKFZARWVtz2bmrD7nWlwsFHpZxOCCmoqFYAE/8Gjhk/7LvPK mfMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=26XbUthJg/tMs7H747g2gbGgSfiMyZZOL8m1eg+hpWc=; b=VEFZcPib94r6VCzl4CtrLmPOXjtgJZvioZyRhxsAI+ELVm7ZDL7yWVon0ky5TRod2B +CpLp9oCF+fhQFpCp7HAQk3z1GNhWdJZCCYNblkrtxHDmxh965ih/QQvILfG5VB/oLun 2a6F6hGJ2rP52CJxdbQVGPgUn3E08zezefoowoIiu7HXR3YmiwtLWlkGLGSTJOvxkKLS eAZdIiu/N/1VAiWnzBbhnuD2b42Al57ICD95I6MZ7ZDdV0IICC9aLm2F+0wxMnFaFuqK fOMcTxybnBXsbFStlOn2jAAQctVDYPXBfqjp0F6SqNwny2M+6TbreDaPUafQ8jR3I+bl w51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=BzjTR8A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf35-20020a1709077f2300b007ade22f401bsi17843093ejc.759.2022.11.23.01.57.30; Wed, 23 Nov 2022 01:57:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=BzjTR8A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237115AbiKWJJb (ORCPT + 88 others); Wed, 23 Nov 2022 04:09:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237068AbiKWJJO (ORCPT ); Wed, 23 Nov 2022 04:09:14 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CAF6630C for ; Wed, 23 Nov 2022 01:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=26XbUthJg/tMs7H747g2gbGgSfiMyZZOL8m1eg+hpWc=; b=BzjTR8A8V852bhy6ymyvQTou12 wx+VKWTOVMkDgqno1C+vM53mTcl+xBL+UrllMfgT/zWkCpYHfh+SnWEFbxpVydfWNVAnW9zCd4CBB P8TM3NT/EpDGpVP3b52fNHeUhaHaxRRQK8MxsjWrsaPzaZaACj0hl6l/GVU5cbncs2PhPmfgz7tmI wHBa5EDsmsE/skp6kWmVCujxaurF1AMBTO7859qdKP1Srh3I9i1zNhBZ/WryiI+J2Ksd5vnYSoSSK nm2C6NNlXZA9l6Fm12LPo4Gu1TiMdZrndbEF3CdpPtskEus/BwhjG8X3iju94Mb8wuqPFYJcF+Xvc xHtEFUNA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxlkj-007Mq0-O8; Wed, 23 Nov 2022 09:09:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E4E6630036C; Wed, 23 Nov 2022 10:08:59 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BF7502D815CDE; Wed, 23 Nov 2022 10:08:59 +0100 (CET) Date: Wed, 23 Nov 2022 10:08:59 +0100 From: Peter Zijlstra To: Steven Rostedt Cc: Uros Bizjak , linux-kernel@vger.kernel.org, Josh Poimboeuf , Jason Baron , Ard Biesheuvel Subject: Re: [PATCH] jump_label: use atomic_try_cmpxchg in static_key_slow_inc_cpuslocked Message-ID: References: <20221019140850.3395-1-ubizjak@gmail.com> <20221122161446.28907755@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122161446.28907755@gandalf.local.home> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 04:14:46PM -0500, Steven Rostedt wrote: > > + for (int v = atomic_read(&key->enabled); v > 0; ) > > Although it's permitted by the compiler, the kernel style is to not add > declarations in conditionals. I'm thinking the whole motivation for upping to C99 was exactly so that we could start using this pattern.