Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07fdc7fb-2a1a-ac70-e0c5-ba9b2fca6464@intel.com>
Date:   Wed, 23 Nov 2022 10:16:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2] ASoC: soc-pcm: Add NULL check in BE reparenting
Content-Language: en-US
To:     Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
References: <1669098673-29703-1-git-send-email-quic_srivasam@quicinc.com>
CC:     <agross@kernel.org>, <andersson@kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <robh+dt@kernel.org>,
        <quic_plai@quicinc.com>, <bgoswami@quicinc.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <srinivas.kandagatla@linaro.org>,
        <quic_rohkumar@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <swboyd@chromium.org>, <judyhsiao@chromium.org>,
        <devicetree@vger.kernel.org>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <1669098673-29703-1-git-send-email-quic_srivasam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFR1YmZvY0RXVkplK21hRkQrTjlSa09TZS9lejJzZmdYQUxPVDNORWNqR2Qr?=
 =?utf-8?B?QVB1OTVRM09iclJFaU5Pc0FzeXVnQ3RUWmozMTh2dC9Sd0tyN2lQQ3ZXRVd1?=
 =?utf-8?B?V0Rib1lxMXZPV0piNzhoN1RNMGs3cGFEZG9MMC9XZWJteXkxeWdkNFN6MFlJ?=
 =?utf-8?B?SFRyVkJraVk5OTBVUmY5MXN3Sm5rcHgyZWVKeEVkQTc4OEFtWWloYWpRYnp4?=
 =?utf-8?B?cHhWR1laN3FsZjNIbjlOTVQ5cFBjNUxiSHc4OGVSTnEvWi9pUzd3Zk1rUGxM?=
 =?utf-8?B?ZkNhZWxTVVp5dkQvRGhKbWFzZkppKytiQVNnblBHSVhyYS9jdXZ0Q1F5bXpB?=
 =?utf-8?B?YjV4Tm5BSUx5WDJGeld6MytjSTVaU2ZRa3lGbzJTQTFYQXFQUml3S0RLK3Yx?=
 =?utf-8?B?YUhaMXhEMVZyVzR3a3VyckZwME55R2JLNXdRQ1BLQzNBSmp0RzcySmtva0tQ?=
 =?utf-8?B?eGlIczZaTFFDL1A0VDNvSHJjeWd3NkorazZwVjBEazErYTU5ZzlpcGlOMjJx?=
 =?utf-8?B?TkpEYnN2dGlLaUhHWDNaZko4ajAzSFVsN29lQlIyclR6cVYxTzV3Q25adG9G?=
 =?utf-8?B?R0Fnak56OTF3WWRka2Nlc0pMRWpUUCtFV3F3cmJzSUVVOTU2MS8rNkhYN3Fa?=
 =?utf-8?B?T1BEa3g1MVZBaktmV3NNSS9wK01MU29yYXZCTGVYZmdaWHg3Y2Y0TFZ4Z3No?=
 =?utf-8?B?UDNPRGV3ZUhkSGx0RlNwbzB3anVWMW1kaTl5akthdkVlWG1iR3NuMmdtY3JB?=
 =?utf-8?B?NGdJeU9pY0hzMFZzaXVML3hEN1JTQXRYYk1Hd0p5Z1dCUUhMQnp2K2RHOHVG?=
 =?utf-8?B?Y0h1aUJ0Sk56NXNvUUVkOC9maDkwYiswZmc2Zm5QRkRMa1Y3MWtVUk5tSkZU?=
 =?utf-8?B?amhkTmNWWVJhUzNBQ2FEMUhaQmtNMmZIR1Vkd2JOQkRkZVVNZWRielZRdTA5?=
 =?utf-8?B?TWtkc1JDMmFFUGVLMzN6Vi83d2xSNEsyejArajh4a1Q0RDg2VlZ4Zk82SWtG?=
 =?utf-8?B?WG0xYnA5Vnp5aWZMdXdnVkxQSm9WRlZkaGREdDJ2S0FYUzdYa25xOGJzOGpi?=
 =?utf-8?B?Sm16U1B3bkxocVhWaWNaQXJQUDdINGpteHhjQUdmTDJGTURMalJLL0gzM1ZN?=
 =?utf-8?B?WXN5bS9lQk8vZEQrdG1vZG4rSCt6aVN5bUU3YXZITzNDR25xM24zN3NMTG9z?=
 =?utf-8?B?VDhDLy9OMUhsWXN2VUhEakdDcHRuZGFoSTNBY2tJYjRocS9VVE1JWE9pdUxa?=
 =?utf-8?B?aUJlT2lTQmNsMDVaSkRHNmV6dzE4V2VRWGJ5d05UWlhHZG5kd2lKMWFsVTAw?=
 =?utf-8?B?dktMRkIxL1RjUWlzdyt2Z2NGcTdJbDJrUVFvdE95K1VSbTJVdkQvU1Y4VSs5?=
 =?utf-8?B?cjNUTTArelNQZlpvaXJvVERmM0J4cklQWkRWZVg2TFNyMWgrV3hhU1ZnanBS?=
 =?utf-8?B?b0MvSlkvcFV4WGJieW5zd2MydGNuaXRXL2hCV1dRMjY3djF6ZFc1UWVDcjFx?=
 =?utf-8?B?djNuaHN0R05Pb253dm9EMVl5Q3BGSkFMUi84NlRKei9UZjFhcnBKUHpDdStI?=
 =?utf-8?B?cDV1YUsrWFlXRVNMVVQ0VjJnWWFiSGxqYkhTS1MrcWdhTWpZRTBSLzVld1dX?=
 =?utf-8?B?d0J3Rm93WE9TVXNhVUlzT1NWR2Jqb3JIOUhNazZIUS9IMFdPYkxCUFc4anJY?=
 =?utf-8?B?bUpodEdIaHUrd2V0N3JLNWVtTXFGZ2V1VFhobVJVbUdydTRMZEtDQ203UG5I?=
 =?utf-8?B?S3E2UFZxUnF5KzR3cDQzWXdPSFpGNHgzMzloZC9VRThiNlRJSTNLMEZZakRB?=
 =?utf-8?B?MWdEcTI5RGlqQjBMMmVzZ3c2MkZGNGFQN040SEovRGtBS1FzL3E0K2JiWTFE?=
 =?utf-8?B?Qk4vQWgvWW1RUmtMcG1YRThNU0ZoR05ZdjNUVmNwdXZFVEVsZUJGMHFUSHRy?=
 =?utf-8?B?UDQ0N2tvWkVmVUZnY3RNQklrSEczQXg4aGF5QVpoejRhd1hoNTYxQ3JISWpQ?=
 =?utf-8?B?NHJpQzgvZ2FUMFU5a1VNNzhjaURqTFROV05uVk40MnZsT2dQcWl4VVBkbGho?=
 =?utf-8?B?WDlJRFJPRTlxa05OR3dKNU5rcVQ4WmlORjF3Q1pkWDh3ejl5bGdGWTlFV2lP?=
 =?utf-8?B?RE1VOEhtbVcxR254d2ErNWdSVVUyekh0dUdlZ3dvTGFTd3pUcWpsQWExK1ZT?=
 =?utf-8?B?M2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d6e019c-84af-49a3-8698-08dacd3372a4
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:16:49.0362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: upa9BG+1tMKb7TTKNGZaD13uUTLcxiCtzb/+lp12IDcuVSlJ4ULODu2n71xqbyBIvi+Va3N2JUtrLCanFkP7ZU7cNIPKSScEStqiYdRWfUQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7129
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-11-22 7:31 AM, Srinivasa Rao Mandadapu wrote:
> Add NULL check in dpcm_be_reparent API, to handle
> kernel NULL pointer dereference error.
> The issue occurred in fuzzing test.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Changes Since V1:
>      -- Update commit title.
> 
>   sound/soc/soc-pcm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 493f003..a7810c7 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -1247,6 +1247,8 @@ static void dpcm_be_reparent(struct snd_soc_pcm_runtime *fe,
>   		return;
>   
>   	be_substream = snd_soc_dpcm_get_substream(be, stream);
> +	if (!be_substream)
> +		return;
>   
>   	for_each_dpcm_fe(be, stream, dpcm) {
>   		if (dpcm->fe == fe)

The explanation provided is hardly satisfactory. The reason I asked, is 
that be_substream should never be null by the time we get to 
dpcm_be_reparent(). There is a number of invocations of 
snd_soc_dpcm_get_substream() within sound/soc/*.c and yet most of them 
are not checked - as they do not need to be.

I believe that the problem may lie elsewhere and this patch just covered 
things up.


Regards,
Czarek