Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Aleksey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        "minchan@kernel.org" <minchan@kernel.org>,
        "ngupta@vflare.org" <ngupta@vflare.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "Dmitry Rokosov" <DDRokosov@sberdevices.ru>
Subject: Re: [RFC PATCH v1 0/4] Introduce merge identical pages mechanism
Thread-Topic: [RFC PATCH v1 0/4] Introduce merge identical pages mechanism
Thread-Index: AQHY/duSaivivX4eVEi4n5R4teXteK5JpjKAgABo/ACAAAH8AIAAmLKAgAEMI4CAAFIJAA==
Date:   Wed, 23 Nov 2022 09:07:40 +0000
Message-ID: <20221123090732.7aktww2jk6axdrld@cab-wsm-0029881.lan>
References: <20221121190020.66548-1-avromanov@sberdevices.ru>
 <Y3vjQ7VJYUEWl2uc@cmpxchg.org> <Y3w7VP5CKvm6XmoJ@google.com>
 <Y3w8/q/HoSbqamoD@google.com>
 <20221122121413.ssieckg523urj37h@cab-wsm-0029881.lan>
 <Y32eA93V7w1Wu3VH@google.com>
In-Reply-To: <Y32eA93V7w1Wu3VH@google.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2068E6DE403ECC48BB19CC683B9416B6@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

On Wed, Nov 23, 2022 at 01:13:55PM +0900, Sergey Senozhatsky wrote:
> On (22/11/22 12:14), Aleksey Romanov wrote:
> > > IIRC that was patent in question:
> > >=20
> > > https://patentimages.storage.googleapis.com/e2/66/9e/0ddbfae5c182ac/U=
S9977598.pdf
> >=20
> > I think the patent is talking about "mapping the virtual address" (like
> > in KSM). But zram works with the "handle" abstraction, which is a boxed
> > pointer to the required object. I think my implementation and the paten=
t
> > is slightly different.=20
> >=20
> > Also, the patent speaks of "compressing" pages. In this case, we can ad=
d
> > zs_merge() function (like zs_compact()), that is, remove the merge logi=
c
> > at the allocator level. zsmalloc doesn't say anything about what object=
s
> > it can work with. Implementation at the zsmalloc level is possible,
> > though more complicated that at the zram level.=20
> >=20
> > I believe that we can implement at least one of the options I proposed.
> >=20
> > What do you think?
>=20
> Oh, yeah, I'm not saying that we cannot have something like that
> in zram/zsmalloc, just wanted to give some historical retrospective
> on this and point at some implementation details that should be
> considered.

Okay, in this case, can you review my patches please?

--=20
Thank you,
Alexey=