Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7123462rwb; Wed, 23 Nov 2022 02:27:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ojIJNyHyazSOEdmdfB+rT2hmMXBSbqNJxCTMHSELT2URMAPndYxypdzHe8Lat/8ij3F36 X-Received: by 2002:aa7:cc14:0:b0:468:58d4:a10e with SMTP id q20-20020aa7cc14000000b0046858d4a10emr25453265edt.222.1669199257428; Wed, 23 Nov 2022 02:27:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669199257; cv=none; d=google.com; s=arc-20160816; b=xVSn+HtowwYR10OY/fxZh4x6WAxiSZzHu06Ds7qeyaXfF1RuEXQWYwO6vOZl7FRcd2 IGlkioSZwuVAXHtkzyFqVgRAQW7t5WMFol7An9dYQLsFXGPHxbRC+7tQ9BeDc6hdpngR MEyW0NEGx2V7ce4/djhHE7ypF90afCyZ18czpJWDFB3WPWQFltJ0Ld6WncBr5UJXsyvd +X5qfomI6tGoEZVkWJRhzIEkDkB/31qmyW4nYjsfiT6QQIHOjB8hs7qOWKrKXq9Bv2H6 k+TGIqnXCBYL5QZxuyAsu4DClVEdQNVStYUJWUm88vnAIA0SV4Q9CVFCzoQxB0XoUwk+ Smpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wWEmLn201VG/emz7uMjG8m3rPcFeNGQJM68ZSwNEUgw=; b=yV0lYwHqgAoK7RbvQK5uht0gWlZoO5/LTeQd5AIqfp95+zo8B36cuLvW1QuCyMQ9YL JdfOfzy+YohkMxrzW79gCLHIQNHs83iffY0kbvgArd9SlRhxMGybAAFld6AQBcfmDH39 +pbk9qUGd0Of7LOwX+NNa8CRh7+MApsQgSDi5ezC/qQRrDM3KCpR+GMxprX/BMBXurCQ AIeI+cWogUk/Q4DW3tAJHx5DSIGvzO6HIadt3GHElav4W4jI/ccNFd3nMeJDuIeQ+Tfe KN9//oqhZiX/Pgs23QYQvi0OF38uv/FoCmaPFq3RvNj7RSPRWp0Qy8n+OShbBbEQ5iIW fq6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a1709064ac100b007aea6b2696fsi11664349ejt.454.2022.11.23.02.27.13; Wed, 23 Nov 2022 02:27:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237223AbiKWKD5 (ORCPT + 89 others); Wed, 23 Nov 2022 05:03:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237475AbiKWKCQ (ORCPT ); Wed, 23 Nov 2022 05:02:16 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5ED69FAE98; Wed, 23 Nov 2022 01:54:27 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69F981FB; Wed, 23 Nov 2022 01:54:33 -0800 (PST) Received: from bogus (unknown [10.57.6.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EEAB3F587; Wed, 23 Nov 2022 01:54:24 -0800 (PST) Date: Wed, 23 Nov 2022 09:54:21 +0000 From: Sudeep Holla To: Jiapeng Chong Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support_confirmed static Message-ID: <20221123095421.ffolxbq2csqirw7u@bogus> References: <20221123034215.119461-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123034215.119461-1-jiapeng.chong@linux.alibaba.com> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 11:42:15AM +0800, Jiapeng Chong wrote: > This symbol is not used outside of bus.c, so marks it static. > > drivers/acpi/bus.c:304:6: warning: symbol 'osc_sb_ffh_opregion_support_confirmed' was not declared. Should it be static? > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3241 > Reported-by: Abaci Robot Sorry for not replying to the original report which I meant to and for some reason left it in the draft. Anyways in order to fix another bug, this variable was removed thereby removing this build/sparse warning. This warning should not appear from today's linux-next. Thanks for spotting and this patch fixing it. -- Regards, Sudeep