Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a9a16d9-221e-6fa4-0ace-fd6e8afaaa4a@suse.com>
Date:   Wed, 23 Nov 2022 10:37:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        x86@kernel.org
References: <20221122163810.29752-1-jgross@suse.com>
 <20221122163810.29752-4-jgross@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221122163810.29752-4-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFlPSzJlNEZFSDdsdnpZbnEwQWFLQXJncW04S2cwYVdkczlPeGpUZUx2QVVI?=
 =?utf-8?B?cThRZXNZSG9RdGpTMFFvRE05a29iOG1yanlpQ0Nud3F0aVloelpOelk1UkRo?=
 =?utf-8?B?aWxhSWsyUTdvc0IrcWQ0N3dxT29OL1JyTXFwODM3d3JLQTluV09FaTZ3WU1W?=
 =?utf-8?B?aFBYem9HTldkYkhQNUlCdUM3b21WS1FpOEYzWkpuem4xVitwT0IyNGlmcmg3?=
 =?utf-8?B?V1dNeHliNmlha0duMS9vaHlVQWNKNytJYXFLTDNMWXphdFhGWGF2ZkFpcVVN?=
 =?utf-8?B?T2dvTFUvTmFrMTdaOHBEd3dyYXNyWUpuTzBjUThtRU14MytjUzBQL1QwR0pm?=
 =?utf-8?B?dFFEdThoYVFhSGsrQnQxY0lsVUYzSHRDczlGeUtxYUdFam1lbjRBbDVDQmJH?=
 =?utf-8?B?d3o2Qk1zQ0czWVQxRkp1cG41bForTDVYRWc0enJwZXJwZXJycGJHOG1IK2wz?=
 =?utf-8?B?WnMrdmk4YnBIaXpiTkFubDFzNHhPZW1PeGdXZWw2N1djNDMvdVFScHRHZFZB?=
 =?utf-8?B?cWZETWJWRFdINUhpTlp6MXRqYzJCMm5Uc0hHRnJaWW5YcUp5UFloZFRzc3Bn?=
 =?utf-8?B?YnVGZ3NtQkt6VjhBUnlpYU9ES0ZpUlRXUDE0MS80bkZnREpXUnBpbW1IUmhU?=
 =?utf-8?B?UGFxTmRIK09QRG5TVzh3TXJxN1d1OFdjYmtITFZLTWNET3k0MUZEUnpqWFgv?=
 =?utf-8?B?ekxTd1g1eXNidHgwK050SlhMdHVDTTZ2RlljNDFWMU9LZzBrMlpSQ0R5QzA0?=
 =?utf-8?B?dE0wdTlwRmlDL2U3N09SSHRqTXpzUnUzWFRNN0xpRkdybldaY3ZyQjVRbVJx?=
 =?utf-8?B?N3pCa2ZkNjdvSTNLdElaaXNvNE90bmo3ejNDV2ZWc002azlFclhadkFVMHpX?=
 =?utf-8?B?Vms5OW9vbjBCQ2pNcFBwSDhqMnFRNTRJUmJPRWgyb05odUlpSFpJNmt5WFhG?=
 =?utf-8?B?V2pic1RPZzdTWGZId1pWNmtiT0RKTm04VGhnUU9NOWxXVUdwdThSK3Z1eXVL?=
 =?utf-8?B?T3FvOGtORmRvb0NBZTlGcGJ3dlBsTjRSYVRVUElkNE9VaWtKenhqS1lrVXBy?=
 =?utf-8?B?VWRtY21oRVY0UjkzTFBHRHV2aVYyOHltdUpzZndrQmxQZ0ZiS3Z0RHJtUXYz?=
 =?utf-8?B?YUNBNEFCRXhPeTZQcmFsdUloQkdkeUozTFJXTGhRZ1lmaG9aTFFmMXFoTTNB?=
 =?utf-8?B?eG5Bckk2ZWxab1RXb2ZNOUwvNlNVRzRGczkvNGR3cy9HNlZnMVpUN0VLbnZk?=
 =?utf-8?B?dVhkYUVOdGdzSVdzb1g2TFRaTHhaMnZRdHluTkhValRRWVBBOFJCWXNvMEtV?=
 =?utf-8?B?M29OS2tPWXRFc0F2eE9lc2NGRGJKRXhtaDd2TXZ0Q1lwellsd2RMUTFMK1U3?=
 =?utf-8?B?aDc5YnRYSUVtMnNLM3IzL2xJd0xmQzY4NVNoc3FEZnkwK3NqeWZvZ1dWaGt5?=
 =?utf-8?B?MStYK3ZZRisvbU9HYkxYQTVOTktrNkdSblRydXpDVmZiWGdXa3UwNlBBNDBX?=
 =?utf-8?B?bmorZ2VIeVdYQXpUL3Z1bk1oRjRnN0lydVZicmxIYlVjbEZVY1dja1VJdDM0?=
 =?utf-8?B?anNBVXIzNWZ2TGV5QUttZVVEek9INVk0eDBuelRyUXg5UFRQQVR2Ri82SFNn?=
 =?utf-8?B?dFVPck5sQ2dFODZzang2eDIxUGVTUTB3enVhMU4xY3VpMGU1Q1FUdENtYzlq?=
 =?utf-8?B?Y2F2dVdINy9zeTBCcW5DUnJYQzVVTk5XbldRdUFVZmd3WUxkcjJnWDRRZFNu?=
 =?utf-8?B?K1JmRjdpVDFEWDd5K0dhb0pyd0REYkNmYzNSaHViNE1pN1BxaXBscXBMelY4?=
 =?utf-8?B?ajJ2dzJPWW5RcWl2N3RENXJrSjVuR0p4aWNZN1JJQWdFbGRGVStKWng0dnVU?=
 =?utf-8?B?aWJ2dUQ4NjJSS1MyNmpxUGgvUHBEaVdtZ1lYRHpkaXJPRi8vOEVDR0ZzdjI1?=
 =?utf-8?B?UEVPaHE0N1hhWm44SHdVTjhWMlVRTkw4citkSnNOV1cvUThoOWNOa3pHVWJI?=
 =?utf-8?B?K25uYlVuOEpOWmxCQlppQk5mOHNIZ1JHcWdsQlN0OW1VbGEyNTlIU0Y2R1Rw?=
 =?utf-8?B?cUJ2RHNqY3BBdDhMbVYvNllFUUZQc1JubjYxZWZhYm5XYjNhY3h4ODduUDZC?=
 =?utf-8?Q?pI/+elSyCG1YQSjtxqbw/kmgV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2cd3074-9759-44f8-342f-08dacd36547b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:37:25.7509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q94exXPPITLJRrX4O4d/1RterQG4+qNQSFHCJ6p4b1Q4hHSoRYg91a2B4awodEo1stBZjwTMODPtbJwCkdNvMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8858
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22.11.2022 17:38, Juergen Gross wrote:
> @@ -137,12 +138,28 @@ static void __init xen_pv_init_platform(void)
>  	xen_init_time_ops();
>  }
>  
> +static struct real_mode_header xen_rm_header;
> +
> +static __initdata struct trampoline_ref xen_dummy_trampoline = {
> +	.blob = (unsigned char *)&xen_rm_header,
> +	.blob_end = (unsigned char *)&xen_rm_header,

With both pointing to the start of the struct, doesn't it suffice
for the above to be xen_rm_header[0]? At which point there'd be no
reason to wonder whether that struct could live in .init.data ...

Jan