Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, rostedt@goodmis.org
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com,
        vsirnapalli@vmware.com, akaher@vmware.com
Subject: [PATCH] perf symbol: correction while adjusting symbol
Date:   Wed, 23 Nov 2022 15:48:16 +0530
Message-Id: <1669198696-50547-1-git-send-email-akaher@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SkL5qxrqKOdF9sserjAp4B1YToepH6KzxxnYdhQa9F9oA0fIYWLLtZonU7Vo?=
 =?us-ascii?Q?tnfFTARJflhGXMKoGeW/e5bUm6ihMFSYU7Rz9Xd3gxYVU6C1ch/hO3KH2mRr?=
 =?us-ascii?Q?TUXtDTgCtD/2WieizwCCWfIG4GWL/C1OZ/522dTR3ZCJgK44GZkOtV9cW/dJ?=
 =?us-ascii?Q?59ikWBOHo438pObcNtpgYwTjZ75ZZhXUqT40t13pLPSLMFjK1mh+2cQoE99y?=
 =?us-ascii?Q?5lS6UwUcCwejLzfAAg8meWJEBQY8ZA3tbSR3rLcsW3aYTG1vkCx0q9y2CvJ+?=
 =?us-ascii?Q?yaENqOts7DOQwNKYik5/MHHEtnS1TwBoxGkqVPHFzWqZ+Y5uFVlpA+Xhx3Ks?=
 =?us-ascii?Q?d6yuzuSBzuXmPWf4hKWdIg0t7KG7xm6v2V4Ie6Lkn7kceJuZ2W+LSSqpCQIp?=
 =?us-ascii?Q?R639GszlBXnd0CMoXhdOgAu53uHD7PTjRw/s2KLdlDChawhpTnGtVi47vPFQ?=
 =?us-ascii?Q?FqoH8MefzCQ+sSEurLKKkHKtt3nA6XunCbmeH6IcrdwvjkO9M2iuYkwRtw8/?=
 =?us-ascii?Q?2bMshaN7W/5xNlmMemnkNZmOisV7Yclb/x8s3LwWqXvCVMZ1+itcgFTZFHHk?=
 =?us-ascii?Q?eQqKK5pITdJ9XZYfA7pGiu1Ndf1f1HrrYqj/X4S1WOlprEcLVAGQgrsHhbvp?=
 =?us-ascii?Q?1isosoYss3tZKFe5KUjfv5YpmI1T3GRPst68rof2aze1oJq6vv8oc9IrUybz?=
 =?us-ascii?Q?spIdrA6dugtZjqhGZkVgNaMQeShHzSmzeQMnIKK6RaVTfpn/CMjaQw6rlHdU?=
 =?us-ascii?Q?Ulzs6VjemCloE1khmAsRGCSvUDp849acDg8jLIRDgyheGe5garpmDuJmejZH?=
 =?us-ascii?Q?hFKWzcNgooB2cBaWOcYZQzzXxC7kvkw0KEtpXag4CC7MBlRIaN6Wq204cgxH?=
 =?us-ascii?Q?rv/wAN7qnz9dVhFZRfUymMYVxV5Q6D+rz1e8qLDGmWiH0OcNVCJE7OAu2tPr?=
 =?us-ascii?Q?XqN4mXhbAklM1KkYyfw5+KNqMCkh4x2mTgG1acmKaHWb4y75YvOS5Y7uIQFD?=
 =?us-ascii?Q?ic8p48kSNJ5gefP3iWno5SCPiY1KMbyOMkOCro9D0MVvNtGD4D4RLFxDtEnf?=
 =?us-ascii?Q?N2WGFaRw0BK4TnsYtfUWPF+FiwuWQq6qIzxuHzTwC5CQqgyc5wYLYcsihpeM?=
 =?us-ascii?Q?M5wwSk1QO/IeooFCvr2PKV1DJf9oC0joxmeqSG/bAYY3AlQjeQYiBJCBTeEw?=
 =?us-ascii?Q?vLO5FbOn48P1Ds1ESssHdbtiodfmNYPXXlllqq+sY2keSgknBYot/OfBZ96t?=
 =?us-ascii?Q?Jaip9aEXSmnui1g0nkb1iFCy9qfd/HUFoOR7dGEs/lTLIq7n50EOFrYTIwH8?=
 =?us-ascii?Q?T9ccHyAZW5kD8PoyMpwwFuxxh+S2jyUpq/ZH7tRZ++ibjFdZRHZbA4Sg7POf?=
 =?us-ascii?Q?8gP+d2bqSoO56QsjwLwcEDG0DnaoZc547FDSDa22HcF7XourdyF1jygViKC7?=
 =?us-ascii?Q?gmEG/qw/8K6rekQhuDXLQa9rwtg1CwzYJlAWzAXjwdBsZBPpFVqZxzgiZEhs?=
 =?us-ascii?Q?nJFlvQ9fbDNTRHaU6be5YCENgShyL8rF8UYg5Mdm4FcV+ciACA4SK/WWMhGg?=
 =?us-ascii?Q?8WR9uquPymUVVSHGNJ+/OQ26CtPY1r8QRIKcbCzq?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbe21969-6928-43f8-c1f9-08dacd3c14e9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 10:18:36.0973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5EhuY92NDlA+BYF1y9wxI7xsv3GaKHBH7o2wtAZZbGAtEi5RU3BPIppWygzQMrLABd8mb2vJ3tmH+rJnK333tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB4091
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

perf doesn't provide proper symbol information for specially crafted
.debug files.

Sometimes .debug file may not have similar program header as runtime
ELF file. For example if we generate .debug file using objcopy
--only-keep-debug resulting file will not contain .text, .data and
other runtime sections. That means corresponding program headers will
have zero FileSiz and modified Offset.

Example: program header of text section of libxxx.so:

Type           Offset             VirtAddr           PhysAddr
               FileSiz            MemSiz              Flags  Align
LOAD        0x00000000003d3000 0x00000000003d3000 0x00000000003d3000
            0x000000000055ae80 0x000000000055ae80  R E    0x1000

Same program header after executing:
objcopy --only-keep-debug libxxx.so libxxx.so.debug

LOAD        0x0000000000001000 0x00000000003d3000 0x00000000003d3000
            0x0000000000000000 0x000000000055ae80  R E    0x1000

Offset and FileSiz have been changed. 

Following formula will not provide correct value, if program header
taken from .debug file (syms_ss):

    sym.st_value -= phdr.p_vaddr - phdr.p_offset;

Correct program header information is located inside runtime ELF
file (runtime_ss).

Fixes: 2d86612aacb7 ("perf symbol: Correct address for bss symbols")
Signed-off-by: Ajay Kaher <akaher@vmware.com>
---
 tools/perf/util/symbol-elf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index 5fba57c..8dde436 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -1129,7 +1129,7 @@ int dso__load_sym(struct dso *dso, struct map *map, struct symsrc *syms_ss,
 			   (!used_opd && syms_ss->adjust_symbols)) {
 			GElf_Phdr phdr;
 
-			if (elf_read_program_header(syms_ss->elf,
+			if (elf_read_program_header(runtime_ss->elf,
 						    (u64)sym.st_value, &phdr)) {
 				pr_warning("%s: failed to find program header for "
 					   "symbol: %s st_value: %#" PRIx64 "\n",
-- 
2.7.4