Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5bf820c6-8b07-cf0c-438b-a411815c202c@intel.com>
Date:   Wed, 23 Nov 2022 12:54:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH] mmc: mmc_test: fix missing assignment of 'file' when
 register debugfs file
To:     Ye Bin <yebin@huaweicloud.com>, ulf.hansson@linaro.org,
        wsa+renesas@sang-engineering.com, kvalo@kernel.org,
        linux-mmc@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, yebin10@huawei.com
References: <20221123095506.1965691-1-yebin@huaweicloud.com>
Content-Language: en-US
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20221123095506.1965691-1-yebin@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/11/22 11:55, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> Now, 'file' is always NULL. obviously, 'file' is used to store return value of
> 'debugfs_create_file()'.

'file' is used to remove debugfs files when the mmc_test module is removed.

> 
> Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/core/mmc_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 6cd6f8a94a71..156d34b2ed4d 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
>  	struct mmc_test_dbgfs_file *df;
>  
>  	if (card->debugfs_root)
> -		debugfs_create_file(name, mode, card->debugfs_root, card, fops);
> +		file = debugfs_create_file(name, mode, card->debugfs_root,
> +					   card, fops);
>  
>  	df = kmalloc(sizeof(*df), GFP_KERNEL);
>  	if (!df) {