Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7206554rwb; Wed, 23 Nov 2022 03:44:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5MNHkWRzzzBjtYwzRhCJv12IQLobf/0xyNEbswatA+2hBlacQL0UjfYlRvuuHC+TiVLsp7 X-Received: by 2002:a05:6a00:1d98:b0:56d:4670:6e2a with SMTP id z24-20020a056a001d9800b0056d46706e2amr17682260pfw.77.1669203873824; Wed, 23 Nov 2022 03:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669203873; cv=none; d=google.com; s=arc-20160816; b=gqTVJpzFYI8E3diaZqH07Gobeq7KnDJHEXE9Vcm60tti79WGKkDw9KwwQ3IWsdYBZY 4pZ2prxrEErUdSxSzvXhyq4bqixQZPwgvgu+tRmyeIGJIe6VPAozTUqDwWdCASBF2Bnx oSvc5o1kkXoEFVah/Fls4LNJbr1aGrU+baa8OAA2TxQjHIrRqBgT97M7iSLUdc4Y9dHX nDyj4O8WhXjdt2o5onpKErW+EZRUHk+HzFDKER+7s0EmNUeHTqI/RGDMY7yG1CaE3XOJ 8yxcmLaad+Z2mHhFYIbqCvkWniOhq8zm+88x/jr9k+afqx2a6l6n9w/FevC+oHi7dTcQ cP1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hUHYWofONES9DAZKrMaAeSlJZ2r4BDd48E0Zlx83ZeA=; b=cxFW0CEiRW43p54niePHoZbqHRtLH5vIk3OB53iu8EdNhhGxGxaklt9nJKslzqJXyA Qey+dTBCqLxfb0dBqnV/JVEvI8rwzaA2DLA/ENTC/WJsTxcRqBRjmjoOZhlqyIrgC8bA 0BBZ3h/kLDj5iwzaQ7uolIS4KFu0r4VIMGm+A3KYlrJc4S9ZcJggKlhP+jkf4o9+4A5A sgajHYbttgL3qzi/DhPM57Qwq71dj8rE561HIjbxy6yWD8DUXzkZ0gZ2SrQeZuLtFHeB XVtTbzEOemSse7QGZJTNz1jQYjcMD2Hk0vQILVsaIiSiP7WzY47P8PxBjYpmGQESCF+X u5mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yt1eTFqw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v30-20020a63465e000000b0046e96b9ecfdsi9778073pgk.801.2022.11.23.03.44.22; Wed, 23 Nov 2022 03:44:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yt1eTFqw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236260AbiKWLKp (ORCPT + 89 others); Wed, 23 Nov 2022 06:10:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236676AbiKWLIp (ORCPT ); Wed, 23 Nov 2022 06:08:45 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55812EA1; Wed, 23 Nov 2022 03:08:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF11E61BD6; Wed, 23 Nov 2022 11:08:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 756D7C433D7; Wed, 23 Nov 2022 11:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669201722; bh=DawtEQRaLys4ndNs0wAfEL55EBLaTd8iBsWdNmensMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yt1eTFqw8F/qCDrGv8Xd8AYJLVuWcTXSYUGOWKR2n5YcnhscY9OG50o0ydhHLBgux 6/1BvZ0NSLstMlNPttpy2OJvmr8ctcxIR9BBvoVjwif+B3qAIQsVcpvxLuDi1BIJYg vV8rkVmd5DElHyAx2Hz1B/6q0YYHbF19nkbqrXx+Egr2clYjMj7jfNiOvOnRbXmN+9 FcX5g35cBHVzwgqpXai9DQW37ENEAEwcdWvWkqtmHdsvWtiSEQlwoghsh+3kQMPTjG gHDbqGnDkHbuF6nvzGgIwUdHC+jrUPFjeuJdhiDEAgL8IZFFJsuEgpbDauYu4obmn2 /KfJWDPYd3z5Q== Date: Wed, 23 Nov 2022 13:08:37 +0200 From: Leon Romanovsky To: Suman Ghosh Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, sgoutham@marvell.com, sbhatta@marvell.com, jerinj@marvell.com, gakula@marvell.com, hkelam@marvell.com, lcherian@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net PATCH V2] octeontx2-pf: Fix pfc_alloc_status array overflow Message-ID: References: <20221123105938.2824933-1-sumang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123105938.2824933-1-sumang@marvell.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 04:29:38PM +0530, Suman Ghosh wrote: > This patch addresses pfc_alloc_status array overflow occurring for > send queue index value greater than PFC priority. Queue index can be > greater than supported PFC priority for multiple scenarios (e.g. QoS, > during non zero SMQ allocation for a PF/VF). > In those scenarios the API should return default tx scheduler '0'. > This is causing mbox errors as otx2_get_smq_idx returing invalid smq value. > > Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support") > Signed-off-by: Suman Ghosh > --- > Changes since v1: > - Updated commit message. > > drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky