Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7210918rwb; Wed, 23 Nov 2022 03:48:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/fxEyuTArB+6s2iGl7U8Zk3S2a74CUkZQKuxMt5L7IATk06Dfn2+BUK4ACx4RLVwfPFBW X-Received: by 2002:a17:902:b101:b0:187:31da:a274 with SMTP id q1-20020a170902b10100b0018731daa274mr8413535plr.103.1669204130371; Wed, 23 Nov 2022 03:48:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669204130; cv=none; d=google.com; s=arc-20160816; b=wRomI/JzY9/qjHFAPvOh3V9iSXnLGgBD0DKTr8tgoF9JG45pmWfeW3Yw0nNYNmkOtx d4etIsYnQgFUze+mUtkV8Y75fMHHtxCEg+HvMAfE8PCq07zppGJ9jUfNE+V4QhCLbNWX 6S9dYOzYGLXpLWcK1MLQ7AQhAkbvZIDy3saloVGWrh3nYwbcTAADgWmGiXgUb2/neHfk +tuQ1LJIeU9XlNpSSXsXAVTJYBfHvaZQFK7owpsw1gi2jBva68gVE03OKwZJCxc70Zw0 wREiP3FEIh6p97DRw1B0kUvQXFcmuT6RrLCN6sXKNIT3+BEdTFTrVbayjR0uft5/C1gF MGAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=DYtcFLHToIi2yTgTHwY0yA7tpPMJydx/gP0xkg98qPWUrIsHtJcfmn+eky6njcjh1E UuXEgh7qPggvDXWZo77gZXO6dq4cfx6YMb3R9UjL8Hln+PvqYmwGYBk7FUOrRSWpIZUx RAYv1mt3FLrBOK7XQA2GG3xbDD9ZyOKS4ZlWnNvfBNQVmQrwe3/8mjWZOln27EYddNJX ROte0aeU5P9wHFUk8IRodg9YnysbnVES8y9f0RIPYBWDtnqe1dcu1jO12pyW7ikf3MdW OnwiUGSDpHNkefl0Xb6fH1oroBc5zlWyiGML7Q8fqgQzHfno644ANRwfhloCKoqP+GX3 rYGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=ja4+W1jE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020a17090aa08c00b0020053614bd0si1416291pjp.148.2022.11.23.03.48.39; Wed, 23 Nov 2022 03:48:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=ja4+W1jE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237305AbiKWLJu (ORCPT + 88 others); Wed, 23 Nov 2022 06:09:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237649AbiKWLIe (ORCPT ); Wed, 23 Nov 2022 06:08:34 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 991B7AF086 for ; Wed, 23 Nov 2022 03:08:15 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id o7-20020a05600c510700b003cffc0b3374so1072907wms.0 for ; Wed, 23 Nov 2022 03:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=ja4+W1jEpsH8IErFm7dMfOR6osTp3PvRK/79rIXT0E+hHFA5TgZynARrHm1/8P3WnR EJt1uCTQKkJxt2DdA4lpEzHSNSq/FUNk/JGIwbSIl7yzE1uR5W+Z9l+a69RC63LmUHl1 n5ZmZ/4m51Z7+ZZPJTkVwcooV7FndRr4kiiCUZ7OD+bxCO7pgWDapJgVH7fkdi8A3RFd 510VYT98Hik+yO6mhv5z3eP7DEAjnKnJKmlDIW/gnF6lIlC/5FYtzZJX8fDE0/+rhRky w7dhyStbmJyQ7C8Ah+mhPXG8g/8h3GQ37ubmGb8n+w1ZJH0IFf9B+sJa6DHBWZN3vr8a s66A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=ghGdsO6mRNq6Yf5aQM7BZTKJBsyIUjxA8LhrWA8OXOeprZSf3jIJewJoC+dSy1Qe9E wxQ16Qh1l2yx4tf6XPKSZqWU+XDEaVKYY01ff2QmzeIDDhla4mo7Fx6w8uK81TTTF468 Vj7yU11uMP9EoVGLAq7UsT+Nqycra6jIVWs5+e0GYfGxZ/w5ER2vVtVIXJyB1EUeIzXn mcUn26cG+s7cjqAb1iwcc89n/ZG3eStYM9k8UtJDP3bMjDp3PGkUxNzx1GXxi9sNTk6Y ceOk5zkrP0bWpRxyG43q9vBjSd1Jbc8MLE4WzyI2T2J/Ge2cFtRCoAXNo8kG9mj66r+O v0Qg== X-Gm-Message-State: ANoB5pkm2TJ84GvarDyKsWpz67xhgV0JKGoIauIpZ9n4m06qRERJN4mF nutd/mC15woghV3gFNydekPynw== X-Received: by 2002:a05:600c:654c:b0:3d0:110c:d25f with SMTP id dn12-20020a05600c654c00b003d0110cd25fmr13782378wmb.125.1669201695202; Wed, 23 Nov 2022 03:08:15 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:ae74:d94f:4677:3378]) by smtp.gmail.com with ESMTPSA id f13-20020a05600c4e8d00b003c6c182bef9sm2560406wmq.36.2022.11.23.03.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 03:08:14 -0800 (PST) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Srinivas Kandagatla , Vinod Koul , Alex Elder , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Bartosz Golaszewski , Konrad Dybcio Subject: [PATCH v3 11/13] tty: serial: qcom-geni-serial: stop operations in progress at shutdown Date: Wed, 23 Nov 2022 12:07:57 +0100 Message-Id: <20221123110759.1836666-12-brgl@bgdev.pl> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221123110759.1836666-1-brgl@bgdev.pl> References: <20221123110759.1836666-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski We don't stop transmissions in progress at shutdown. This is fine with FIFO SE mode but with DMA it causes trouble so fix it now. Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio --- drivers/tty/serial/qcom_geni_serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 036231106321..82242a40a95a 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -865,6 +865,9 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port) static void qcom_geni_serial_shutdown(struct uart_port *uport) { + qcom_geni_serial_stop_tx(uport); + qcom_geni_serial_stop_rx(uport); + disable_irq(uport->irq); } -- 2.37.2