Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221119225650.1044591-1-alobakin@pm.me> <20221119225650.1044591-9-alobakin@pm.me>
In-Reply-To: <20221119225650.1044591-9-alobakin@pm.me>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 23 Nov 2022 22:03:09 +0900
Message-ID: <CAK7LNAT4asXORsS8Q-NRfGEYo4fsAnMVhQai3C+EeaDhoXv57Q@mail.gmail.com>
Subject: Re: [PATCH 08/18] net: enetc: fix mixed module-builtin object
To:     Alexander Lobakin <alobakin@pm.me>
Cc:     linux-kbuild@vger.kernel.org, Nicolas Schier <nicolas@fjasle.eu>,
        Jens Axboe <axboe@kernel.dk>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Tony Luck <tony.luck@intel.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Derek Chickles <dchickles@marvell.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Daniel Scally <djrscally@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        NXP Linux Team <linux-imx@nxp.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Nov 20, 2022 at 8:07 AM Alexander Lobakin <alobakin@pm.me> wrote:
>
> From: Masahiro Yamada <masahiroy@kernel.org>
>
> With CONFIG_FSL_ENETC=m and CONFIG_FSL_ENETC_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
>
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>
> Introduce the new module, fsl-enetc-core, to provide the common
> functions to fsl-enetc and fsl-enetc-vf.
>
> [ alobakin: add exports to common functions ]
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Reviewed-by: Alexander Lobakin <alobakin@pm.me>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  drivers/net/ethernet/freescale/enetc/Kconfig  |  5 +++++
>  drivers/net/ethernet/freescale/enetc/Makefile |  7 ++++---
>  drivers/net/ethernet/freescale/enetc/enetc.c  | 21 +++++++++++++++++++
>  .../net/ethernet/freescale/enetc/enetc_cbdr.c |  7 +++++++
>  .../ethernet/freescale/enetc/enetc_ethtool.c  |  2 ++
>  .../net/ethernet/freescale/enetc/enetc_pf.c   |  2 ++
>  .../net/ethernet/freescale/enetc/enetc_vf.c   |  2 ++
>  7 files changed, 43 insertions(+), 3 deletions(-)


I think you can grab Author since I did not finish this patch.
(and of course, I did not test it at all)

You can remove a blank line after MODULE_IMPORT_NS()

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


-- 
Best Regards
Masahiro Yamada