Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 10:35:09 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf inject: Set PERF_RECORD_MISC_BUILD_ID_SIZE
Message-ID: <Y34hjaIcCUr/80Vx@kernel.org>
References: <20221119002750.1568027-1-namhyung@kernel.org>
 <5e408880-3394-c943-6ed5-6ceb8d05fd07@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e408880-3394-c943-6ed5-6ceb8d05fd07@intel.com>
Precedence: bulk

Em Mon, Nov 21, 2022 at 10:45:14AM +0200, Adrian Hunter escreveu:
> On 19/11/22 02:27, Namhyung Kim wrote:
> > With perf inject -b, it synthesizes build-id event for DSOs.  But it
> > missed to set the size and resulted in having trailing zeros.
> > 
> > As perf record sets the size in write_build_id(), let's set the size
> > here as well.
> > 
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks, applied.

- Arnaldo

 
> > ---
> >  tools/perf/util/synthetic-events.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> > index cccd293b5312..0645795ff080 100644
> > --- a/tools/perf/util/synthetic-events.c
> > +++ b/tools/perf/util/synthetic-events.c
> > @@ -2218,8 +2218,9 @@ int perf_event__synthesize_build_id(struct perf_tool *tool, struct dso *pos, u16
> >  	len = pos->long_name_len + 1;
> >  	len = PERF_ALIGN(len, NAME_ALIGN);
> >  	memcpy(&ev.build_id.build_id, pos->bid.data, sizeof(pos->bid.data));
> > +	ev.build_id.size = pos->bid.size;
> >  	ev.build_id.header.type = PERF_RECORD_HEADER_BUILD_ID;
> > -	ev.build_id.header.misc = misc;
> > +	ev.build_id.header.misc = misc | PERF_RECORD_MISC_BUILD_ID_SIZE;
> >  	ev.build_id.pid = machine->pid;
> >  	ev.build_id.header.size = sizeof(ev.build_id) + len;
> >  	memcpy(&ev.build_id.filename, pos->long_name, pos->long_name_len);

-- 

- Arnaldo